[Bug 51583] New: win16 applications crash due to "visual styles"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51583

Bug ID: 51583
           Summary: win16 applications crash due to "visual styles"
           Product: Wine
           Version: 6.14
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Split off from bug 51564.

Issue is with
commit f304b2ae23bb537029fe51983f060f680de66a12
Author: Zhiyi Zhang 
Date:   Fri Jun 11 10:05:33 2021 +0800

winevdm: Enable visual styles.

Download attached.

[Bug 51583] win16 applications crash due to "visual styles"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51583

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
    Regression SHA1|                            |f304b2ae23bb537029fe51983f0
                   |                            |60f680de66a12
                URL|                            |https://archive.org/details
                   |                            |/TETRIS_201612

[Bug 51583] win16 applications crash due to "visual styles"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51583

--- Comment #1 from Fabian Maurer  ---
Created attachment 70433
  --> https://bugs.winehq.org/attachment.cgi?id=70433
Program to reproduce the crash

Note that the commit itself is not faulty. It just exposes another issue in
win16 code.

[Bug 51583] win16 applications crash due to "visual styles"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51583

--- Comment #2 from Fabian Maurer  ---
Created attachment 70434
  --> https://bugs.winehq.org/attachment.cgi?id=70434
Crashlog

[Bug 51583] Tetris crashes due to "visual styles"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51583

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|win16 applications crash    |Tetris crashes due to
                   |due to "visual styles"      |"visual styles"

--- Comment #3 from Fabian Maurer  ---
Also affects win32 programs, when converting from Ansi to Unicode, handles and
resource IDs should be ignored, that's what windows does as well.
Not 100% sure why tetris tries to send a HGLOBAL to another process, but that
makes it crash.

[Bug 51583] Tetris crashes due to "visual styles"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51583

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 51583] Tetris crashes due to "visual styles"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51583

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail] ---
I believe the revert patch was merged.
https://source.winehq.org/patches/data/217585

[Bug 51583] Tetris crashes due to "visual styles"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51583

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |b1eeaa657db649c256fe92c94f2
                   |                            |10982f810fd6a
             Status|NEW                         |RESOLVED

--- Comment #5 from Fabian Maurer  ---
Fixed by
https://source.winehq.org/git/wine.git/?a=commit;h=b1eeaa657db649c256fe92c94...

[Bug 51583] Tetris crashes due to "visual styles"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51583

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 6.20.