[Bug 14359] New: clear slots in new argv[]

http://bugs.winehq.org/show_bug.cgi?id=14359

Summary: clear slots in new argv[]
           Product: Wine
           Version: 1.0.0
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: kernel32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=14656)
 --> (http://bugs.winehq.org/attachment.cgi?id=14656)
clear new reserved slots in new argv[]

When constructing a new argv[] vector, then the new reserved slots should be
cleared to prevent bugs and keep valgrind(memcheck) happy.  Patch is attached
and also will be sent to [e-mail].

[Bug 14359] clear slots in new argv[]

http://bugs.winehq.org/show_bug.cgi?id=14359

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #1 from Austin English   2009-01-05 11:11:35 ---
Is this still an issue in current (1.1.12 or newer) wine? Would you mind
resubmitting the patch and asking for comments?

[Bug 14359] clear slots in new argv[]

http://bugs.winehq.org/show_bug.cgi?id=14359

--- Comment #2 from Austin English   2009-07-16 13:06:31 ---
Patch resent:
http://www.winehq.org/pipermail/wine-patches/2009-July/075696.html

not applied. Not sure why.

[Bug 14359] clear slots in new argv[]

http://bugs.winehq.org/show_bug.cgi?id=14359

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 14359] clear slots in new argv[]

http://bugs.winehq.org/show_bug.cgi?id=14359

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Bruno Jesus  2011-11-23 20:36:50 CST ---
Friendly reminder of years without new posts.

process.c have changed a lot since patch from comment 0 but as far as I can see
the patch was not applied mainly because of the following line:

Line 1370 - argv[argc]=NULL;

[Bug 14359] clear slots in new argv[]

http://bugs.winehq.org/show_bug.cgi?id=14359

--- Comment #4 from Austin English  2013-12-03 18:53:29 CST ---
(In reply to comment #3)
> Friendly reminder of years without new posts.
>
> process.c have changed a lot since patch from comment 0 but as far as I can see
> the patch was not applied mainly because of the following line:
>
> Line 1370 - argv[argc]=NULL;

Still in wine-1.7.7.

[Bug 14359] clear slots in new argv[]

http://bugs.winehq.org/show_bug.cgi?id=14359

--- Comment #5 from Alexandre Julliard  2013-12-04 03:19:34 CST ---
There's no reason to clear slots that will be set later on. I don't see any bug
here.

[Bug 14359] clear slots in new argv[]

http://bugs.winehq.org/show_bug.cgi?id=14359

--- Comment #6 from Bruno Jesus  2013-12-04 05:25:25 CST ---
(In reply to comment #5)
> There's no reason to clear slots that will be set later on. I don't see any bug
> here.

Maybe this bug is more relevant then: bug 22829

[Bug 14359] clear slots in new argv[]

https://bugs.winehq.org/show_bug.cgi?id=14359

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 14359] clear slots in new argv[]

https://bugs.winehq.org/show_bug.cgi?id=14359

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #7 from Austin English  ---
(In reply to Alexandre Julliard from comment #5)
> There's no reason to clear slots that will be set later on. I don't see any
> bug here.

WONTFIX.

[Bug 14359] clear slots in new argv[]

https://bugs.winehq.org/show_bug.cgi?id=14359

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Ken Sharp  ---
Closing