[Bug 44533] New: All releases and current in github

https://bugs.winehq.org/show_bug.cgi?id=44533

Bug ID: 44533
           Summary: All releases and current in github
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: crypt32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

wine/dlls/crypt32/base64.c
Line 822 LPCWSTR trailer = CERT_TRAILER_START_W;
Should be
LPCWSTR trailer = CERT_TRAILER_W;

Because it has to put
-----END CERTIFICATE-----

I found this with this program
http://georgekarras.blogspot.gr/2018/02/base64-using-crypt32-in-m2000-not-fo...
using CRYPT_STRING_BASE64HEADER=0x0 (without altering to 0x1 to prevent error,
but then missing headers)

[Bug 44533] base64 crypt checks trailer against wrong string

https://bugs.winehq.org/show_bug.cgi?id=44533

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|crypt32                     |-unknown
            Summary|All releases and current in |base64 crypt checks trailer
                   |github                      |against wrong string
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
            Version|unspecified                 |3.2
         Resolution|---                         |INVALID

--- Comment #1 from Zebediah Figura  ---
No, the current code is valid. CryptStringToBinary only checks whether
"-----END " is present; it does not check the whole string. This is supported
by tests; see lines 432-448 of dlls/crypt32/tests/base64.c.

[Bug 44533] base64 crypt checks trailer against wrong string

https://bugs.winehq.org/show_bug.cgi?id=44533

George Karras  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.2                         |1.8

--- Comment #2 from George Karras  ---
The line 822 isn't the fault one.
I check the code i CryptBinaryToStringW and found ok the encoder. I check my
version of wine is 1.8
Can I load the fresh crypt32.dll

[Bug 44533] base64 crypt checks trailer against wrong string

https://bugs.winehq.org/show_bug.cgi?id=44533

George Karras  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from George Karras  ---
The problem was only in 1.8