https://bugs.winehq.org/show_bug.cgi?id=48795
Bug ID: 48795 Summary: Patches website mishandles HTML attachments Product: WineHQ.org Version: unspecified Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: www-unknown Assignee: wine-bugs@winehq.org Reporter: fgouget@codeweavers.com Distribution: ---
Here is an example: https://source.winehq.org/patches/data/181590
Created from: https://www.winehq.org/pipermail/wine-devel/2020-March/162581.html
This typically happens with replies to patches: * In the plain text version the diff is prefixed with "> " characters so it is not recognized as a patch. * But in the HTML version or the email the quoting is done through HTML tags which typically leave "+++" at the start of the line. As a result the HTML part can look like a patch.
But it could also happen if someone sends a patch in an HTML-only email (e.g. due to a mail client misconfiguration).
The TestBot normally ignores HTML attachments (see NewPatch() in Patches.pm). But when patches go through the patches website the TestBot does not have access to the raw email. Instead it gets the files prepared by the patches website as in the first link. Such files erase the distinction between the plain text and HTML part and so mislead the TestBot into creating a job.
https://bugs.winehq.org/show_bug.cgi?id=48795
--- Comment #1 from François Gouget fgouget@codeweavers.com --- Created attachment 66700 --> https://bugs.winehq.org/attachment.cgi?id=66700 Test mbox containing an email with an HTML attachment
To use this test mbox, set up ~/.procmailrc to invoke patches/filter and put the resulting file in the relevant maildir directory. Then:
formail -ds procmail ~/.procmailrc <~/html.mbox
Note that the resulting file will not be added to the patches index because it is missing the "---" line that patches/updates looks for.
To get the TestBot to take the file into account run:
./testbot/bin/WinePatchesWebSubmit.pl
https://bugs.winehq.org/show_bug.cgi?id=48795
--- Comment #2 from François Gouget fgouget@codeweavers.com --- Created attachment 66701 --> https://bugs.winehq.org/attachment.cgi?id=66701 File generated from html.mbox