[Bug 58598] New: Realterm_2.0.0.70 / Crashes on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58598

Bug ID: 58598
           Summary: Realterm_2.0.0.70 / Crashes on start
           Product: Wine
           Version: 10.12
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 79134
  --> http://bugs.winehq.org/attachment.cgi?id=79134
Application error messagebox

Tested with Wine 22.04 on Ubuntu 22.04 running on VMware.

Created new 32bit prefix.
Application seems to install normally.

During startup it crashes.

Attached screenshot of message box shown with backtrace window.

[Bug 58598] Realterm_2.0.0.70 / Crashes on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58598

Janne  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://sourceforge.net/pro
                   |                            |jects/realterm/files/Realte
                   |                            |rm/2.0.0.70/Realterm_2.0.0.
                   |                            |70_Signed_Wrapper_setup.exe
                   |                            |/download

[Bug 58598] Realterm_2.0.0.70 / Crashes on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58598

--- Comment #1 from Janne  ---
Created attachment 79135
  --> http://bugs.winehq.org/attachment.cgi?id=79135
console log

[Bug 58598] Realterm_2.0.0.70 / Crashes on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58598

--- Comment #2 from Janne  ---
Created attachment 79136
  --> http://bugs.winehq.org/attachment.cgi?id=79136
backtrace

[Bug 58598] Realterm_2.0.0.70 / Crashes on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58598

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #3 from Louis Lenders  ---
Confirming.

I think it expects something present under the registry key
"HARDWARE\DEVICEMAP\PARALLEL PORTS"

With the stupid hack below, which populates it with wrong entries(!!!), the
application starts for me. Also just just disabling mountmgr.sys prevents the
crash. Maybe someone who knows more about parallel ports might have a look at
it.

diff --git a/dlls/mountmgr.sys/device.c b/dlls/mountmgr.sys/device.c
index ba019cdb13d..53f51d41529 100644
--- a/dlls/mountmgr.sys/device.c
+++ b/dlls/mountmgr.sys/device.c
@@ -1992,7 +1992,7 @@ static void create_port_devices( DRIVER_OBJECT *driver,
const char *devices )
         windows_ports_key_name = L"HARDWARE\DEVICEMAP\SERIALCOMM";
         port_prefix = L"COM";
     }
-    else
+    //else
     {
         dosdev_fmt = "lpt%u";
         windows_ports_key_name = L"HARDWARE\DEVICEMAP\PARALLEL PORTS";

[Bug 58598] Realterm_2.0.0.70 / Crashes on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58598

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |serial

[Bug 58598] Realterm_2.0.0.70 / Crashes on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58598

--- Comment #4 from Janne  ---
I tested to create symlink for lpt port to /dev folder.
Command used: sudo ln -s /dev/null /dev/lp0

After this i checked registry and there is one entry in:
HARDWARE\DEVICEMAP\PARALLEL PORTS

With this change realterm starts. 
On start there is message complaining about invalid handle but that does not
prevent starting.

Question related to that key in registry.
In case there is no lpt port on system, is there need for the PARALLEL PORT key
in registry?

In Windows 11 & computer without parallel port, this key does not exists in
registry.

[Bug 58598] Realterm_2.0.0.70 / Crashes on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58598

--- Comment #5 from Janne  ---
Windows 11 does not have PARALLEL_PORTS key in registry so i tried to remove it
in Wines registry.
After removing the key realterm started.

Steps used:

1. Open regedit 
2. Delete key PARALLEL_PORTS at HARDWARE\DEVICEMAP.
3. Leave regedit open
4. Open another terminal 
5. Start realterm

[Bug 58598] Realterm_2.0.0.70 / Crashes on start

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=58598

--- Comment #6 from Janne  ---
I tried to make a patch which prevents creation of the PARALLEL_PORTS key into
registry in case where char array devices is empty.

Made two test with patch:

1. Without symlink to lp0. Realterm starts.
2. With symlink to lp0. Key & content are created and Realterm starts.

diff --git a/dlls/mountmgr.sys/device.c b/dlls/mountmgr.sys/device.c
index ba019cdb13d..26517597c68 100644
--- a/dlls/mountmgr.sys/device.c
+++ b/dlls/mountmgr.sys/device.c
@@ -1997,6 +1997,7 @@ static void create_port_devices( DRIVER_OBJECT *driver,
const char *devices )
         dosdev_fmt = "lpt%u";
         windows_ports_key_name = L"HARDWARE\DEVICEMAP\PARALLEL PORTS";
         port_prefix = L"LPT";
+       if (strlen(devices)==0) return;
     }

/* @@ Wine registry key: HKLM\Software\Wine\Ports */