[Bug 49415] New: .desktop files (from shortcuts) broken in wine-staging

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49415

Bug ID: 49415
           Summary: .desktop files (from shortcuts) broken in wine-staging
           Product: Wine-staging
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
      Distribution: ---

In wine-staging, .desktop files are created incorrectly.

The correct (wine Github) .desktop file contains the following:

env WINEPREFIX="/home/nyanpasu64/.wine" wine start /Unix
/home/nyanpasu64/.wine/dosdevices/c:/users/nyanpasu64/Start\
Menu/Programs/OpenMPT.lnk

The incorrect (wine-staging) .desktop file contains the following, and fails to
start:

env WINEPREFIX="/home/nyanpasu64/.wine" wine /usr/bin/wine /Unix
/home/nyanpasu64/.wine/dosdevices/c:/users/nyanpasu64/Start\
Menu/Programs/OpenMPT.lnk

This is caused by the following patch:
https://github.com/wine-staging/wine-staging/blob/029c249e789fd8b05d8c1eeda4...

I think the problem is the following line (and similar lines):

-        fprintf(file, "Exec=env WINEPREFIX="%s" wine %s %s\n", prefix, path,
args);
+        fprintf(file, "Exec=env WINEPREFIX="%s" wine %s %s\n", prefix,
wine_path, args);

path is not the location of the wine binary, but instead contains "start
...lnk". I think the patch should be closer to:

-        fprintf(file, "Exec=env WINEPREFIX="%s" wine %s %s\n", prefix, path,
args);
+        fprintf(file, "Exec=env WINEPREFIX="%s" %s %s %s\n", prefix,
wine_path, path, args);

Note that I have not tested this patch.

[Bug 49415] .desktop files (from shortcuts) broken in wine-staging

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49415

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |102af10c89164cff0be68d6b407
                   |                            |2de9050b1000b
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Alistair Leslie-Hughes  ---
Thanks.

Fixed by
https://github.com/wine-staging/wine-staging/commit/102af10c89164cff0be68d6b...

[Bug 49415] .desktop files (from shortcuts) broken in wine-staging

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=49415

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Zebediah Figura  ---
Closing bugs fixed in wine-staging 5.12.