[Bug 36817] New: valgrind shows a mismatched free in msvcrt/tests/file.c

https://bugs.winehq.org/show_bug.cgi?id=36817

Bug ID: 36817
           Summary: valgrind shows a mismatched free in
                    msvcrt/tests/file.c
           Product: Wine
           Version: 1.7.21
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase, valgrind
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]

==11351== Mismatched free() / delete / delete []
==11351==    at 0x7BC4C72C: notify_free (heap.c:263)
==11351==    by 0x7BC51071: RtlFreeHeap (heap.c:1762)
==11351==    by 0x4EA624C: msvcrt_heap_free (heap.c:113)
==11351==    by 0x4EA6BDC: MSVCRT_free (heap.c:400)
==11351==    by 0x4EA1E9A: MSVCRT_fclose (file.c:3381)
==11351==    by 0x4BC07E3: test_fileops (file.c:189)
==11351==    by 0x4BCD4FC: func_file (file.c:2337)
==11351==    by 0x4C04E40: run_test (test.h:584)
==11351==    by 0x4C0523D: main (test.h:654)
==11351==  Address 0x4557010 is 0 bytes inside a block of size 2,048 alloc'd
==11351==    at 0x4029155: malloc (vg_replace_malloc.c:292)
==11351==    by 0x4EA4F16: MSVCRT_setvbuf (file.c:4509)
==11351==    by 0x4BBFDFD: test_fileops (file.c:146)
==11351==    by 0x4BCD4FC: func_file (file.c:2337)
==11351==    by 0x4C04E40: run_test (test.h:584)
==11351==    by 0x4C0523D: main (test.h:654)
==11351==

[Bug 36817] valgrind shows a mismatched free in msvcrt/tests/file.c

http://bugs.winehq.org/show_bug.cgi?id=36817

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Sebastian Lackner  ---
Created attachment 48897
  --> http://bugs.winehq.org/attachment.cgi?id=48897
msvcrt: Use MSVCRT_malloc instead of malloc in setvbuf (Valgrind).

This should fix it.

[Bug 36817] valgrind shows a mismatched free in msvcrt/tests/file.c

https://bugs.winehq.org/show_bug.cgi?id=36817

--- Comment #2 from Austin English  ---
(In reply to Sebastian Lackner from comment #1)
> Created attachment 48897 [details]
> msvcrt: Use MSVCRT_malloc instead of malloc in setvbuf (Valgrind).
>
> This should fix it.

Yep, thanks.

[Bug 36817] valgrind shows a mismatched free in msvcrt/tests/file.c

https://bugs.winehq.org/show_bug.cgi?id=36817

--- Comment #3 from Sebastian Lackner  ---
Piotr was faster, and already submitted an identical patch:

http://source.winehq.org/git/wine.git/patch/0350b6c7fd68bcdec7d7ff56fec76b6d...

Should be fixed now. ;)

[Bug 36817] valgrind shows a mismatched free in msvcrt/tests/file.c

https://bugs.winehq.org/show_bug.cgi?id=36817

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |0350b6c7fd68bcdec7d7ff56fec
                   |                            |76b6d13864670
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Austin English  ---
Fixed by 0350b6c7fd68bcdec7d7ff56fec76b6d13864670.

[Bug 36817] valgrind shows a mismatched free in msvcrt/tests/file.c

https://bugs.winehq.org/show_bug.cgi?id=36817

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.22.