[Bug 48651] New: Fix handling of child test processes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48651

Bug ID: 48651
           Summary: Fix handling of child test processes
           Product: Wine-Testbot
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Wine's test.h provides a winetest_wait_child_process() function to wait for
child processes. But when an error happens it issues some messages which the
TestBot does not recognize.

* If waiting for the child process fails the error message does not look like a
'Test failed' error message which it should to simplify things.

* But winetest_wait_child_process() does not know on which line it was called
so calling winetest_ok() would not provide the right line number.

* The failure to wait for the child process should also distinguish between
CreateProcess() errors (usually those are already reported by the caller),
timeouts and other errors.

* The Testbot does not recognize the 'child process crashed' message. This
causes it to find mismatches between the number of 'Test failed' messages and
the final summary.

* The TestBot also does not recognize the 'failures in child process' summary
line but that probably does not matter.

[Bug 48651] Fix handling of child test processes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48651

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]
           Keywords|                            |source, testcase

[Bug 48651] Fix handling of child test processes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48651

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

[Bug 48651] Fix handling of child test processes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48651

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from François Gouget  ---
This was fixed by:

commit a909baeb4e5ee8050a32832c28ff3ee79c54fbfa
Author: Francois Gouget 
Date:   Mon Mar 16 23:52:21 2020 +0100

tests: Report all errors when failing to wait for a child process.

Report the line number where the test failed to wait for the child so
    one can identify which child process did not behave as expected.
    Also wait_child_process() is meant for the general case so report
    all non-crash error cases as test failures so they are accounted for.
    Omit the "winetest_" prefix to match the other Wine test functions and
    so the underlying winetest_wait_child_process() function can be wrapped
    with the usual line-capturing macros.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48651
    Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 48651] Fix handling of child test processes

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48651

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from François Gouget  ---
Closing.