[Bug 31791] New: Cedar Logic crashes when you press F1

http://bugs.winehq.org/show_bug.cgi?id=31791

Bug #: 31791
           Summary: Cedar Logic crashes when you press F1
           Product: Wine
           Version: 1.5.13
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: hhctrl.ocx
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Saw this while trying to reproduce bug 31778.
On wine-1.5.11-188-g77632f0, installing
http://superb-dca2.dl.sourceforge.net/project/cedarlogic/CEDAR%20Logic%201.5...
went fine, and the app started up fine, but pressing F1 (or Help / Contents)
crashed with
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code
(0x7d6ad919).
Backtrace:
=>0 CreateViewer+0x229(pHHInfo=0x207c18) [dlls/hhctrl.ocx/help.c:1660]
  1 CreateHelpViewer+0x9d(filename="C:\Program Files\CEDAR
Logic\KLS_Logic.chm", caller=0x10068) [dlls/hhctrl.ocx/help.c:1808] 
  2 HtmlHelpW+0xc4(caller=0x10068, filename="C:\Program Files\CEDAR
Logic.\KLS_Logic.chm", command=0, data=0) [dlls/hhctrl.ocx/hhctrl.c:184]
  3 HtmlHelpA+0x10e(caller=0x10068, filename="C:\Program Files\CEDAR
Logic.\KLS_Logic.chm", command=0, data=0) [dlls/hhctrl.ocx/hhctrl.c:355]
  4 0x0056ca9b in cedarls (+0x16ca9a) (0x00a4f638)
...
0x7d6ad919 CreateViewer+0x229 [/home/dank/wine-git/dlls/hhctrl.ocx/help.c:1660]
in hhctrl: cmpw    $0,0x0(%esi)
1660        if (!*caption) caption = info->pCHMInfo->defTitle;

Looks like a314027b4211ddd045e12bd768962c3c47f56d68 missed a trick.
The superficial fix

-    if (!*caption) caption = info->pCHMInfo->defTitle;
+    if (!caption || !*caption) caption = info->pCHMInfo->defTitle;

lets help start.

[Bug 31791] Cedar Logic crashes when you press F1

http://bugs.winehq.org/show_bug.cgi?id=31791

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://superb-dca2.dl.sourc
                   |                            |eforge.net/project/cedarlog
                   |                            |ic/CEDAR%20Logic%201.5%20Re
                   |                            |lease/cedarlssetup.exe

[Bug 31791] Cedar Logic crashes when you press F1

http://bugs.winehq.org/show_bug.cgi?id=31791

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Erich Hoover  2012-09-27 12:23:10 CDT ---
(In reply to comment #0)
> ...
> 0x7d6ad919 CreateViewer+0x229 [/home/dank/wine-git/dlls/hhctrl.ocx/help.c:1660]
> in hhctrl: cmpw    $0,0x0(%esi)
> 1660        if (!*caption) caption = info->pCHMInfo->defTitle;
> ...

Could you try with Wine after commit a61903388eb11a8c5c5e4929ebdcaccedd67430f?

[Bug 31791] Cedar Logic crashes when you press F1

http://bugs.winehq.org/show_bug.cgi?id=31791

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Dan Kegel  2012-09-30 23:03:33 CDT ---
Sure enough, it was my old wine.  Sorry about that.

[Bug 31791] Cedar Logic crashes when you press F1

http://bugs.winehq.org/show_bug.cgi?id=31791

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  2012-10-12 13:35:48 CDT ---
Closing bugs fixed in 1.5.15.