[Bug 31557] New: Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Bug #: 31557
           Summary: Guild Wars 2 screenshots look bad
           Product: Wine
           Version: 1.5.11
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 41501
  --> http://bugs.winehq.org/attachment.cgi?id=41501
Screenshot with problem

Attached is what they look like. I've tried many combinations of settings and
they all look like that.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Luke Bratch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Samuel Nelson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Samuel Nelson  2012-09-25 14:39:35 CDT ---
This is odd.  I've gotten several great screenshots from GW2 (since release
even), but the issue started for me fairly recently.

Maybe it's related to a game setting or something?

I'll try working with it, see if I can get good screenshots again, and then
figure out which setting breaks it.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Alpo Turunen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Alpo Turunen  2012-09-30 14:13:22 CDT ---
I have this bug with Wine 1.5.14, but the screenshots look normal with Wine
1.4.1. The bug happens both with the lowest and the highest game graphic
settings. Laptop with Intel gm45 graphics device and desktop computer with
Radeon X1950Pro are both affected. Linux distribution is Ubuntu 12.04 x86,
using the xorg-edgers ppa.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #3 from Alpo Turunen  2012-09-30 14:17:02 CDT ---
Sorry, the bug I'm talking about is Guild Wars 1. The screenshots look similar
however, so they may be caused by the same bug.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

sl1pkn07  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from sl1pkn07  2012-10-01 08:54:39 CDT ---
i agree. have this issue in 1.5.14. in 1.5.13 works

nvidia 304.51

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #5 from sl1pkn07  2012-10-01 08:55:47 CDT ---
(In reply to comment #4)
> i agree. have this issue in 1.5.14. in 1.5.13 works
>
> nvidia 304.51

sorry, in archlinux 64bits

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #6 from sl1pkn07  2012-10-01 09:00:52 CDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > i agree. have this issue in 1.5.14. in 1.5.13 works
> >
> > nvidia 304.51
>
> sorry, in archlinux 64bits

whit 1.5.14 by POL (playonlinux) works. only fail with custom compilation

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #7 from Samuel Nelson  2012-10-01 09:20:46 CDT ---
(In reply to comment #4)
> i agree. have this issue in 1.5.14. in 1.5.13 works
>
> nvidia 304.51

I have the issue in Wine git from right around 1.5.13's release, too, built
using a custom prefix and the awesomium and rawfix patches (no other configure
flags).  1.5.9, using the same custom flags, works just fine.  I'll try 1.5.13
official release tonight (manually compiled with a custom prefix and the
awesomium and rawfix patches, just to keep things consistent).

I'll also try without the rawfix patch - maybe something related to that 1000
ms delay made screenshots work.

Oh, by the way, the following is the bug report with what I've been calling the
"rawfix" patch attached: http://bugs.winehq.org/show_bug.cgi?id=31702

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #8 from Austin English  2012-10-01 13:32:18 CDT ---
(In reply to comment #4)
> i agree. have this issue in 1.5.14. in 1.5.13 works

Please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #9 from sl1pkn07  2012-10-01 19:52:43 CDT ---
(In reply to comment #8)
> (In reply to comment #4)
> > i agree. have this issue in 1.5.14. in 1.5.13 works
>
> Please run a regression test:
> http://wiki.winehq.org/RegressionTesting

in 1.5.14 compiled by POL works. but compile myself (with awesomium patch)
fails

i wait the "official" POL release. i think related by newer lib"graphiclibrary"
used in my distro (archlinux), the POL wine build in ubuntu (older libs)

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #10 from Samuel Nelson  2012-10-02 10:24:43 CDT ---
Well, I remembered that I needed to do these tests, so I kept taking
screenshots.  But I forgot to switch Wine versions.  And I didn't compile any
other wine versions, with or without patches.  And I suddenly realized it was
getting late and I needed to go to sleep or I would be late for work in the
morning.

However, I did remember one thing that has some relevance:

With Wine 1.5.9, patched with raw3.patch, awesomium.patch, and the fix for raw
input being bound to a box, screenshots worked.  So it isn't related to that
1000ms delay from the raw input bounding box fix; or at least, not entirely.

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #4)
> > > i agree. have this issue in 1.5.14. in 1.5.13 works
> >
> > Please run a regression test:
> > http://wiki.winehq.org/RegressionTesting
>
> in 1.5.14 compiled by POL works. but compile myself (with awesomium patch)
> fails
>
> i wait the "official" POL release. i think related by newer lib"graphiclibrary"
> used in my distro (archlinux), the POL wine build in ubuntu (older libs)

Does PlayOn* use any different settings in winecfg (maybe overridden DLLs or
something) or different registry keys?  Maybe the regressed library is being
overridden by the prefix created by PlayOn*

I'm going to (assuming I don't get drawn in to the game again) install GW2
through PlayOnLinux and do some comparisons, myself.  Maybe that will help
narrow down where the issue lies.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #11 from sl1pkn07  2012-10-02 11:01:14 CDT ---
(In reply to comment #10)
> Well, I remembered that I needed to do these tests, so I kept taking
> screenshots.  But I forgot to switch Wine versions.  And I didn't compile any
> other wine versions, with or without patches.  And I suddenly realized it was
> getting late and I needed to go to sleep or I would be late for work in the
> morning.
>
> However, I did remember one thing that has some relevance:
>
> With Wine 1.5.9, patched with raw3.patch, awesomium.patch, and the fix for raw
> input being bound to a box, screenshots worked.  So it isn't related to that
> 1000ms delay from the raw input bounding box fix; or at least, not entirely.
>
> (In reply to comment #9)
> > (In reply to comment #8)
> > > (In reply to comment #4)
> > > > i agree. have this issue in 1.5.14. in 1.5.13 works
> > >
> > > Please run a regression test:
> > > http://wiki.winehq.org/RegressionTesting
> >
> > in 1.5.14 compiled by POL works. but compile myself (with awesomium patch)
> > fails
> >
> > i wait the "official" POL release. i think related by newer lib"graphiclibrary"
> > used in my distro (archlinux), the POL wine build in ubuntu (older libs)
>
> Does PlayOn* use any different settings in winecfg (maybe overridden DLLs or
> something) or different registry keys?  Maybe the regressed library is being
> overridden by the prefix created by PlayOn*
>
> I'm going to (assuming I don't get drawn in to the game again) install GW2
> through PlayOnLinux and do some comparisons, myself.  Maybe that will help
> narrow down where the issue lies.

in my knowledge, only change settings in winecfg if install game (new
instalation), or when update scritps (see latest game script changes in
http://www.playonlinux.com/es/app-1126-Guild_Wars_2.html)

POL don't have autoupdate installation script, the changes between installation
script change with by hand (add dlls override, add shorcuts, add executable
flags, etc). the wine version manager only change the version of wine use the
game.the build wine is a normal compilation, but if necessary include patch to
fix something (in case of GW2, in 1.5.13 add awesomium patch
(PlayOnLinux-wine-1.5.13-GuildWars2))

i use -prefix=/home/"user"/.PlayOnLinux/wine/1.5.14-GuildWars2_custom
--enable-win64 to add in POL wine manager

in my compilation add this awesomium patch
(http://bugs.winehq.org/attachment.cgi?id=36923)... result dont work bazar
(awesomium related) and the screenshot like first attachment

the "official" wine 1.5.14 (without awesomium patch) built by POL the
screenshot works (the bazar fails)

my system is archlinux64 + testing repos

greetings

sorry my english

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #12 from sl1pkn07  2012-10-02 11:08:51 CDT ---
--prefix=/home/"user"/.PlayOnLinux/wine/linux-amd64/1.5.14-GuildWars2_custom
--enable-win64

sorry

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #13 from Alpo Turunen  2012-10-02 16:26:36 CDT ---
I did a git bisect between 1.5.9 and 1.5.14. At least for GW1 screenshots the
bad commit is:
271d801ea49538e196f04290fc83cd57955fed17 is the first bad commit
commit 271d801ea49538e196f04290fc83cd57955fed17
Author: Dmitry Timoshkov 
Date:   Wed Jul 18 17:26:38 2012 +0900

gdiplus: Use predefined palette if an image doesn't provide one.

:040000 040000 35273d0d883da8cdecd886ffe7dc9cc388d98f2c
5e6a7e9463b1d9b5245579a982a12596b84179f1 M    dlls

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Regression SHA1|                            |271d801ea49538e196f04290fc8
                   |                            |3cd57955fed17

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #14 from Dmitry Timoshkov  2012-10-02 21:40:45 CDT ---
Does reverting that patch help? If yes, please attach good and bad screenshot
files.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #15 from Samuel Nelson  2012-10-02 23:44:33 CDT ---
Created attachment 41936
  --> http://bugs.winehq.org/attachment.cgi?id=41936
Log of make after reverting revision 271d801

The revision doesn't cleanly revert:

valczir@nurgle:~/dev/wine/wine-git git:(master)$ git revert
271d801ea49538e196f04290fc83cd57955fed17
error: could not revert 271d801... gdiplus: Use predefined palette if an image
doesn't provide one.
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

<<< 22:31.00 Tue Oct 02 2012 > Jobs: 1 >>>
valczir@nurgle:~/dev/wine/wine-git git:(master+*)$ git status
# On branch master
# Unmerged paths:
#   (use "git reset HEAD <file>..." to unstage)
#   (use "git add <file>..." to mark resolution)
#
#       both modified:      dlls/gdiplus/image.c
#
no changes added to commit (use "git add" and/or "git commit -a")

After that, I ran:

git checkout --theirs dlls/gdiplus/image.c
./configure --prefix ~/.wine_versions/wine-git-screenshottest

After that, make results in compile errors (full log attached).  I'm guessing
that a real merge is needed, rather than just git checkout --theirs, but I'm
not familiar with Wine's code base (at all - this is my first time actually
looking at it), and I doubt I can fix it faster than someone who is.

Doesn't mean I won't try, but I wanted to post initial results here, first. 
I'll probably give it a half-hearted whack or three tonight and/or tomorrow.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #16 from Samuel Nelson  2012-10-03 02:07:02 CDT ---
Created attachment 41937
  --> http://bugs.winehq.org/attachment.cgi?id=41937
Revert Patch

Here's the patch file (created using git format-patch) that reverts (some of)
the changes from revision 271d801, and seems to make screenshots work.

I did a very basic manual merge.  I just commented out instead of deleting so
that it's obvious which parts I changed.

At first glance, it looks like the issue is:

1) Since the image palette is unknown, a predefined palette is chosen
2) The predefined palette that was chosen somehow causes
IWICPalette_IsGrayscale() to set the variable "gray" to true (it could also be
IWICPalette_IsBlackWhite() and the variable "mono", but I believe it to be
grayscale based purely on how the images look versus the variable and function
names)

Removing the default palette logic *seems* to make screenshots work
(attachments to follow).  If no one else gets to it (or to a proper fix) first,
I'll make a slightly cleaner dirty hack patch tomorrow.  But in my opinion,
getting rid of the default palette logic is probably not the correct fix - just
a temporary hack for Guild Wars 2 until either the palette of GW2 screenshots
can be detected or the predefined palette is set to something that still makes
sense *and* allows GW2's screenshots to turn out in full color.

I spent a bit of time trying to find out which predefined palette is being
used, but the game takes *far* too long to start with WINEDEBUG=trace+all to
finish it tonight, and I can't seem to figure out which debug channel it's in
to limit those debug statements enough to get it to run decently well (enough
to get me to the log in screen in less than a half hour).  I'll check on that
after work tomorrow.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #17 from Samuel Nelson  2012-10-03 02:09:28 CDT ---
Created attachment 41938
  --> http://bugs.winehq.org/attachment.cgi?id=41938
Screenshot Before Revert

Screenshot with vanilla wine git, before reverting commit 271d801 and poking
the code with a stick until it compiled.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #18 from Samuel Nelson  2012-10-03 02:12:36 CDT ---
Created attachment 41939
  --> http://bugs.winehq.org/attachment.cgi?id=41939
Screenshot After Revert

Screenshot after reverting commit 271d801 and poking the code with a stick
until it compiled.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #19 from sl1pkn07  2012-10-03 11:38:35 CDT ---
my test through POL 4.1.8

wine 1.5.14 build by POL, without -bmp http://sl1pkn07.no-ip.com/GW2/gw001.bmp
wine 1.5.14 build by POL, with -bmp http://sl1pkn07.no-ip.com/GW2/gw002.bmp
wine 1.5.14 build by me*, without -bmp http://sl1pkn07.no-ip.com/GW2/gw003.jpg
wine 1.5.14 build by me*, with -bmp http://sl1pkn07.no-ip.com/GW2/gw004.bmp
wine 1.5.14 build by me**, without -bmp http://sl1pkn07.no-ip.com/GW2/gw005.jpg
wine 1.5.14 build by me**, with -bmp http://sl1pkn07.no-ip.com/GW2/gw006.bmp

*  awesomium.patch + screenshot samuel nelson patch
** awesomium.patch

base: build in archlinux64 + testing repos. wine 1.5.14 oficial release 
patch -p1 -i ../"patchset".patch
./tools/make_requests
./configure
--prefix=/home/sl1pkn07/.PlayOnLinux/wine/linux-amd64/1.5.14-GuildWars2_custom
--enable-win64
make depends
make

yes i dont undestand wine 1.5.14 build by POL with/out any patch and command
flag (-bmp) the screnshot take in BMP format. but if build for me without -bmp
take in JPG and with -bmp take in bmp

all jpg screenshot have render fail, with/out screenshot patch

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #20 from sl1pkn07  2012-10-03 12:18:58 CDT ---
test GIT (ea151639737f08ca76bcec0ae174296cacdc572c) with sreenshot patch (+
awesomium)

same settings

without -bmp http://sl1pkn07.no-ip.com/GW2/gw007.jpg
with -bmp http://sl1pkn07.no-ip.com/GW2/gw008.bmp

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #21 from sl1pkn07  2012-10-03 21:56:33 CDT ---
comment related (by me) http://bugs.winehq.org/show_bug.cgi?id=27168#c78

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #22 from Samuel Nelson  2012-10-03 22:19:51 CDT ---
Interesting.  Well, I'll come back to this when I can (probably later this week
or this weekend); I'm really busy at the moment.  Again, assuming that no one
who actually knows what they're doing comes along and saves the day, I will dig
further and see if I can figure out some more debugging information, as well as
a cleaner patch (the one I uploaded was ... well, ugly, to put it lightly).

I honestly don't know why the patch worked for me, but I promise that *nothing*
was changed other than the lines in that patch.  On the other hand, I was using
32 bit Wine ... but I don't think that would make a difference.

Still ... like I said, I'll try to dig further to figure out what type of
debugging output would be helpful.  And if all else fails, maybe I can fix it. 
I am *still* horribly unfamiliar with Wine's code base, but I can get lucky
sometimes.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Samuel Nelson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41937|0                           |1
        is obsolete|                            |

--- Comment #23 from Samuel Nelson  2012-10-14 00:09:59 CDT ---
Created attachment 42113
  --> http://bugs.winehq.org/attachment.cgi?id=42113
Updated patch

I took some time today to narrow down which part of the previous revert patch
was restoring proper screenshots.  It's a small block of code that is entirely
unrelated to what my first guess was.

I'm actually not sure what the code block does, or why it was removed, yet. 
Now that I've narrowed it down, I'm gonna let it sit and hope (again) that
someone who knows what they're doing takes up the torch.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #24 from sl1pkn07  2012-10-14 07:19:20 CDT ---
the new patch working

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #25 from Alpo Turunen  2012-10-16 14:24:00 CDT ---
The patch fixes the regression for Guild Wars 1 also.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #26 from Alpo Turunen  2012-10-27 07:39:05 CDT ---
The bug is not fixed in wine 1.5.16.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Forest  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #27 from Forest  2012-11-03 13:04:49 CDT ---
I think it's safe to mark this bug confirmed.

I've built an ubuntu package of wine 1.5.16 with this latest patch.  Get it
here:
https://launchpad.net/~foresto/+archive/winepatched/

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #28 from Alpo Turunen  2012-12-23 05:22:50 CST ---
Why is this bug still marked as UNCONFIRMED even when there is already a patch
for fixing it?

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #29 from Bruno Jesus  2012-12-25 14:28:33 CST ---
Confirmed by multiple users.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #30 from Alpo Turunen  2013-05-13 12:06:29 CDT ---
Created attachment 44461
  --> http://bugs.winehq.org/attachment.cgi?id=44461
Traces of gdiplus when taking a screenshot in GW1
> From reading the code, it seems the memcpy operations of wicformat have same

results on both pre-regression and post-regression code.
The only difference it that old code left gdipformat to 0 when
IsEqualGUID(&wicformat, wic_pixel_formats[i]) is false for all i, and new code
sets gdipformat = PixelFormat32bppARGB in that case.

Pleaes correct me if I'm wrong, and please take a look at trace+gdiplus of the
different versions if it helps give any idea what's wrong with the code.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |gdiplus

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Brandon Corujo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #31 from Vincent Povirk  2013-08-14 14:49:44 CDT ---
Created attachment 45611
  --> http://bugs.winehq.org/attachment.cgi?id=45611
possible fix

Does this patch help?

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45611|0                           |1
        is obsolete|                            |

--- Comment #32 from Vincent Povirk  2013-08-14 14:52:48 CDT ---
Created attachment 45612
  --> http://bugs.winehq.org/attachment.cgi?id=45612
possible fix (try 2)

Whoops, had a stupid mistake in that last patch, try this one instead.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #33 from Vincent Povirk  2013-08-14 14:58:20 CDT ---
Oh, actually that's pretty much the same as Samuel's last patch, which was a
partial revert. The code looks right to me (a WIC encoder can set a different
pixel format from the one requested, in which case it's up to the caller to
convert the image data to that format), so I wonder why Dmitry's patch removed
it.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45612|0                           |1
        is obsolete|                            |

--- Comment #34 from Vincent Povirk  2013-08-14 15:21:12 CDT ---
Created attachment 45614
  --> http://bugs.winehq.org/attachment.cgi?id=45614
possible fix (try 3)

Sorry, still fussing over this a bit.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #35 from Dmitry Timoshkov  2013-08-14 19:24:04 CDT ---
(In reply to comment #33)
> Oh, actually that's pretty much the same as Samuel's last patch, which was a
> partial revert. The code looks right to me (a WIC encoder can set a different
> pixel format from the one requested, in which case it's up to the caller to
> convert the image data to that format), so I wonder why Dmitry's patch removed
> it.

If I recall correctly removed code was causing test failures.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #36 from Vincent Povirk  2013-08-14 20:44:56 CDT ---
Then that code, the encoder, or the decoder should be fixed. We can't just
write data to the encoder in a format it's not expecting.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #37 from Dmitry Timoshkov  2013-09-24 21:25:19 CDT ---
Probably fixed by
http://source.winehq.org/git/wine.git/commitdiff/12586f76e34c64a0b33d5e4626d...

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #38 from Alpo Turunen  2013-09-26 02:59:28 CDT ---
Created attachment 46081
  --> http://bugs.winehq.org/attachment.cgi?id=46081
gdiplus trace with version from git

The patch in git didn't fix the bug. I attached a +gdiplus trace when taking a
screenshot.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Alpo Turunen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46081|application/octet-stream    |text/plain
          mime type|                            |

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #39 from Dmitry Timoshkov  2013-10-07 19:37:53 CDT ---
Does this one work better?
http://source.winehq.org/git/wine.git/?a=commit;h=b14a4ca0064a675b7f0c86a22e...

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #40 from sl1pkn07  2013-10-08 16:53:35 CDT ---
(In reply to comment #39)
> Does this one work better?
> http://source.winehq.org/git/wine.git/?a=commit;h=b14a4ca0064a675b7f0c86a22e...

this commit don't fix the issue in GW2 in JPG mode

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #41 from sl1pkn07  2013-10-08 17:14:22 CDT ---
(In reply to comment #40)
> (In reply to comment #39)
> > Does this one work better?
> > http://source.winehq.org/git/wine.git/?a=commit;h=b14a4ca0064a675b7f0c86a22e...
>
> this commit don't fix the issue in GW2 in JPG mode

shit. ignore please :/

test real git version in progress :/

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #42 from sl1pkn07  2013-10-08 17:35:55 CDT ---
(In reply to comment #41)
> (In reply to comment #40)
> > (In reply to comment #39)
> > > Does this one work better?
> > > http://source.winehq.org/git/wine.git/?a=commit;h=b14a4ca0064a675b7f0c86a22e...
> >
> > this commit don't fix the issue in GW2 in JPG mode
>
> shit. ignore please :/
>
> test real git version in progress :/

at last

b14a4ca0064a675b7f0c86a22e7fc39238080fc8 fix the screenshot in JPG mode. BMP
still working like expected

great work

greetings

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #43 from Alpo Turunen  2013-10-08 18:59:09 CDT ---
Bug is fixed. Thanks a lot!

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |b14a4ca0064a675b7f0c86a22e7
                   |                            |fc39238080fc8
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #44 from Bruno Jesus  2013-10-08 19:39:54 CDT ---
Confirmed fixed by 2 different users.

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #45 from [e-mail] 2013-10-08 22:33:26 CDT ---
> b14a4ca0064a675b7f0c86a22e7fc39238080fc8 fix the screenshot in JPG mode. BMP
> still working like expected

Do you mean it is fixed in .jpg but not in .bmp?

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

--- Comment #46 from sl1pkn07  2013-10-08 23:37:44 CDT ---
(In reply to comment #45)
> > b14a4ca0064a675b7f0c86a22e7fc39238080fc8 fix the screenshot in JPG mode. BMP
> > still working like expected
>
> Do you mean it is fixed in .jpg but not in .bmp?

i mean fix in JPG modes, BMP always work. this fix don't break BMP

greetings

[Bug 31557] Guild Wars 2 screenshots look bad

http://bugs.winehq.org/show_bug.cgi?id=31557

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #47 from Alexandre Julliard  2013-10-11 12:30:17 CDT ---
Closing bugs fixed in 1.7.4.