http://bugs.winehq.org/show_bug.cgi?id=34052
Bug #: 34052 Summary: The Witcher: Character models are sometimes invisible Product: Wine Version: 1.6-rc5 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: jeff@deseret-tech.com Classification: Unclassified
Created attachment 45258 --> http://bugs.winehq.org/attachment.cgi?id=45258 Missing character models
As described in the thread on bug #12771, which was recently closed due to the correction of one of the major reported graphical glitches in The Witcher, save games will sometimes load with invisible character models. Only the face and teeth of humans are visible, along with any gear (but not clothing) that may be carried on the character's back.
The occurrence of this issue seems hit and miss -- some people experience almost never, while others experience it almost always. Some registry tweaks involving video memory have been reported to resolve the issue for some.
I've attached a fresh screenshot of the issue, as seen with Wine 1.6-rc5. Geralt's face is clearly visible floating in the foreground, and the four floating helmets and swords in the background are supposed to be full city guard characters.
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #1 from Jeff Cook jeff@deseret-tech.com 2013-07-14 00:45:08 CDT --- Created attachment 45259 --> http://bugs.winehq.org/attachment.cgi?id=45259 Geralt in-dialogue
Close-up from a dialogue scene
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #2 from Jeff Cook jeff@deseret-tech.com 2013-07-14 00:46:00 CDT --- Created attachment 45260 --> http://bugs.winehq.org/attachment.cgi?id=45260 Shani in-dialogue
Close-up from dialogue scene
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #3 from Jeff Cook jeff@deseret-tech.com 2013-07-14 00:49:11 CDT --- I have attempted setting the VideoMemorySize key. It does not resolve the issue for me, but it increases load time on the main menu extremely much.
http://bugs.winehq.org/show_bug.cgi?id=34052
Xavier Vachon xvachon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xvachon@gmail.com
--- Comment #4 from Xavier Vachon xvachon@gmail.com 2013-07-14 02:00:44 CDT --- Many games suffer from that bug. See my report here notably for the Witcher, but also for Heroes VI and the King's bounty series : http://bugs.winehq.org/show_bug.cgi?id=32273
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #5 from Andrey Gusev andrey.goosev@gmail.com 2013-08-13 04:40:04 CDT --- Confirming on 1.7.0. Bug can be reproduced in demo http://www.fileplanet.com/183167/180000/fileinfo/The-Witcher-Demo
http://bugs.winehq.org/show_bug.cgi?id=34052
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download URL| |http://www.fileplanet.com/1 | |83167/180000/fileinfo/The-W | |itcher-Demo
http://bugs.winehq.org/show_bug.cgi?id=34052
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #6 from Austin English austinenglish@gmail.com 2013-08-13 13:06:02 CDT --- (In reply to comment #5)
Confirming on 1.7.0. Bug can be reproduced in demo http://www.fileplanet.com/183167/180000/fileinfo/The-Witcher-Demo
Confirming.
http://bugs.winehq.org/show_bug.cgi?id=34052
Josh manwesulimo2004@yahoo.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |manwesulimo2004@yahoo.co.uk
http://bugs.winehq.org/show_bug.cgi?id=34052
salamander purake salamanderrake@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |salamanderrake@gmail.com
--- Comment #7 from salamander purake salamanderrake@gmail.com 2013-10-13 10:31:53 CDT --- Also in the GoG version of the game.
http://bugs.winehq.org/show_bug.cgi?id=34052
Konrad Materka kmaterka@wp.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kmaterka@wp.pl
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #8 from Konrad Materka kmaterka@wp.pl 2013-10-19 11:00:18 CDT --- 1.7.4 also affected
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #9 from Konrad Materka kmaterka@wp.pl 2013-10-23 13:04:51 CDT --- This bug happens only from time to time on my machine, so it is really hard to find. I tried bisecting wine code, but I hard hard time to reproduce it. On newest wine it happens one time for something like 20 runs.
http://bugs.winehq.org/show_bug.cgi?id=34052
Sean sdpeterson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sdpeterson@gmail.com
--- Comment #10 from Sean sdpeterson@gmail.com --- I have the same issue with Wine 1.7.8 (tried many other versions too). It happens to me every time. I always just see eyeballs and teeth. Given the repeatability on my system, if there are any diagnostics I can run to help locate the issue, let me know.
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #11 from Konrad Materka kmaterka@wp.pl --- Sean, if you can do regression testing: http://wiki.winehq.org/RegressionTesting
http://bugs.winehq.org/show_bug.cgi?id=34052
Andrey Gusev andrey.goosev@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andrey.goosev@gmail.com
--- Comment #12 from Andrey Gusev andrey.goosev@gmail.com --- New link is http://www.gamershell.com/download_22384.shtml
Many times have launched on 1.7.11 and models are not an invisible as for now. Driver 331.38. Need to test by someone else.
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #13 from salamander purake salamanderrake@gmail.com --- I can verifiy with wine 1.7.11 and nvidia driver 331.38 on gentoo am64 that the char is no longer invisible.
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #14 from Bruno Jesus 00cpxxx@gmail.com --- Confirmed fixed by two different people that were able to reproduce the issue.
http://bugs.winehq.org/show_bug.cgi?id=34052
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #15 from Bruno Jesus 00cpxxx@gmail.com --- (In reply to comment #14)
Confirmed fixed by two different people that were able to reproduce the issue.
http://bugs.winehq.org/show_bug.cgi?id=34052
Deve deveee@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |deveee@gmail.com
--- Comment #16 from Deve deveee@gmail.com --- Tested with wine 1.7.11 and nvidia 331.38 a while ago and bug still occurs.
Perhaps problem was fixed by updating other packages?
I don't have any problems when I run game using intel graphics card. But when I use nvidia through bumblebee, I see this bug.
Wine without any changes in configuration.
http://bugs.winehq.org/show_bug.cgi?id=34052
John gandalf_cel_alb@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |gandalf_cel_alb@yahoo.com
--- Comment #17 from John gandalf_cel_alb@yahoo.com --- Tried today with wine 1.7.12 and 1.7.10 nvidia 331.38-2 on arch. Still have this bug, installed only d3dx9_36 to fix black screen. Also tried all sorts of combinations of GLSL, Video memory, Offscreen renderer and Render target mode lock, nothing seems to work
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #18 from John gandalf_cel_alb@yahoo.com --- (In reply to comment #17)
Tried today with wine 1.7.12 and 1.7.10 nvidia 331.38-2 on arch. Still have this bug, installed only d3dx9_36 to fix black screen. Also tried all sorts of combinations of GLSL, Video memory, Offscreen renderer and Render target mode lock, nothing seems to work
Ok, I tried it again on xfce4. It works perfectly in there. However when using i3 it doesn't.
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #19 from Deve deveee@gmail.com --- Is there possibility to reopen bug report? Current wine and nvidia drivers 331.38 don't solve this issue for me.
http://bugs.winehq.org/show_bug.cgi?id=34052
Blake blakehartshorn@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |blakehartshorn@gmail.com
--- Comment #20 from Blake blakehartshorn@gmail.com --- I may have just found the userside fix. Seems the issue actually relates to using native d3dx9_36.dll with the nvidia driver.
Having the same symptom everyone's describing. I'm on Fedora 20 64-bit, affects the 1.7.8 version the distro provides, also affected various versions I built on my own: 1.6.2, 1.7.11 and 1.7.12, only custom option was --without-gstreamer. Using nvidia 331.38 driver and the Steam version of the game.
After going backwards I upgraded back to 1.7.12. I then ran regedit and manually changed d3dx9_36 from native to builtin (see: HKEY_CURRENT_USER\Software\Wine\DllOverrides). Character models are now loading perfectly fine. I'll start a playthrough this week to confirm if it's stable. I'm not getting a black screen with 1.7.12.
https://bugs.winehq.org/show_bug.cgi?id=34052
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #21 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.13.
http://bugs.winehq.org/show_bug.cgi?id=34052
blkmetaller@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |blkmetaller@gmail.com
--- Comment #22 from blkmetaller@gmail.com --- For me the bug is still there, either whit wine 1.7.13
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #23 from Jeff Cook jeff@deseret-tech.com --- This bug is no longer immediately present for me. I only tried once, but the models were there.
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #24 from Deve deveee@gmail.com --- I tried once again with wine 1.7.13 and nvidia 331.38 and I still have the same bug...
http://bugs.winehq.org/show_bug.cgi?id=34052
MikhailZ m3for@mail.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |m3for@mail.ru
--- Comment #25 from MikhailZ m3for@mail.ru --- I catched this bug on every wine version I used. It is 1.7.17 now.
I found interesting fact. I hope it will be usefull. When my game was on ext4 FS this bug was in 1 cases of 10 When I moving game, steam and wine prefix on btrfs I catch it in 9 cases of 10!
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #26 from Deve deveee@gmail.com --- Why this f***ing bug closed and there is no possibility to reopen it?
In my case: - when I use nvidia with bumblebee - 10/10 - when I use nvidia prime - maybe 1-3/10, so it's playable. - with integrated intel - 0/10, playable but on medium details
Bug also occurs more rarely when I have already opened other wine application.
So, I suppose that loading data from btrfs is slower than from ext4 ;-)
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #27 from Austin English austinenglish@gmail.com --- (In reply to Deve from comment #26)
Why this f***ing bug closed and there is no possibility to reopen it?
In my case:
- when I use nvidia with bumblebee - 10/10
- when I use nvidia prime - maybe 1-3/10, so it's playable.
- with integrated intel - 0/10, playable but on medium details
Bug also occurs more rarely when I have already opened other wine application.
So, I suppose that loading data from btrfs is slower than from ext4 ;-)
There are multiple bugs, it appears. Likely your issue is either with the bumblebee driver, or btrfs.
https://bugs.winehq.org/show_bug.cgi?id=34052
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |matteo.mystral@gmail.com
--- Comment #28 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Austin English from comment #27)
There are multiple bugs, it appears. Likely your issue is either with the bumblebee driver, or btrfs.
No, it's more likely that there is a single, not clearly reproducible, bug.
I can still reproduce this sometimes with current Wine, using Nvidia binary drivers (and no bumblebee or btrfs or anything weird). I tried to investigate this some time ago but with no real luck. IIRC an interesting tidbit was that replaying a game trace recorded with apitrace multiple times might give different results on different runs.
It looks like this happens only on Nvidia binary drivers? This might be a driver bug, although I don't have any hard evidence of that. OTOH, I'm pretty sure this is not FIXED.
https://bugs.winehq.org/show_bug.cgi?id=34052
Andrey Gusev andrey.goosev@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |---
--- Comment #29 from Andrey Gusev andrey.goosev@gmail.com --- Still an issue with the latest Wine.
http://bugs.winehq.org/show_bug.cgi?id=34052
Nicky nheart@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nheart@gmail.com
--- Comment #30 from Nicky nheart@gmail.com --- Bug occurs when using optirun/primusrun to run the game.
If I use the intel gfx everything is fine. I haven't tried dri prime though
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #31 from Deve deveee@gmail.com --- (In reply to Nicky from comment #30)
Bug occurs when using optirun/primusrun to run the game.
If I use the intel gfx everything is fine. I haven't tried dri prime though
It also occurs with nvidia prime but much more rarely.
@Austin English
There are multiple bugs, it appears. Likely your issue is either with the bumblebee driver, or btrfs.
I wrote about btrfs because someone other said that it occurs much more frequently on btrfs. I suppose that some kind of data must be loaded fast enough. If it's not loaded on time, then we see this bug. It's because I wrote that ext4 is faster file system.
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #32 from Nicky nheart@gmail.com --- Possibly the same bug as bug #25325 ?
Missing models again occur only with nvidia drivers and some users report that they can get all models loaded after several tries (never happened with me though...)
http://bugs.winehq.org/show_bug.cgi?id=34052
mrboese@live.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mrboese@live.de
http://bugs.winehq.org/show_bug.cgi?id=34052
Lukas Jirkovsky l.jirkovsky@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |l.jirkovsky@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #33 from Nicky nheart@gmail.com --- I can confirm that when using DP output attached directly to the nvidia card and no primus/optirun I can get textures in all problematic games approximately every other time that I start them.
When running with primus/optirun I have yet to get textures in Witcher on Titan quest.
https://bugs.winehq.org/show_bug.cgi?id=34052
bugzilla@soulrebel.in-berlin.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@soulrebel.in-berli | |n.de
--- Comment #34 from bugzilla@soulrebel.in-berlin.de --- I can confirm on
# uname -a FreeBSD fbsdmain 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64
% wine --version wine-1.7.23
% glxinfo | grep -i version server glx version string: 1.4 client glx version string: 1.4 GLX version: 1.4 OpenGL core profile version string: 4.3.0 NVIDIA 340.32 OpenGL core profile shading language version string: 4.30 NVIDIA via Cg compiler OpenGL version string: 4.4.0 NVIDIA 340.32 OpenGL shading language version string: 4.40 NVIDIA via Cg compiler
This bug is triggered *every time* on my system. Really annoying... is there any workaround?
Thanks for your help!
https://bugs.winehq.org/show_bug.cgi?id=34052
Eric eric.desgroseilliers@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.desgroseilliers@gmail. | |com
--- Comment #35 from Eric eric.desgroseilliers@gmail.com --- There is a potential work around that works for me.
Once the game is running, switch to Virtual Console 1 (ctrl + alt + f1) and return to X (ctrl + alt + f7). This corrects the invisible character problem, although I need to repeat this each time I run the game.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #36 from bugzilla@soulrebel.in-berlin.de --- I have to correct myself: after setting the options
"OffscreenRenderingMode"="fbo" "RenderTargetLockMode"="textex"
it works /most of the time/.
I had this bug a few times as well: https://bugs.winehq.org/show_bug.cgi?id=25696
But restarting the computer (sic) "fixes" the issue.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #37 from Deve deveee@gmail.com --- @up
I'm not sure what you actually did, but http://wiki.winehq.org/UsefulRegistryKeys says that OffscreenRenderingMode is by default set to "fbo". And RenderTargetLockMode doesn't have property "textex" (only "disabled", "readdraw", "readtex").
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #38 from Deve deveee@gmail.com --- https://bugs.winehq.org/attachment.cgi?id=45260 Shani is the best :-D
I reported this bug to nvidia: https://devtalk.nvidia.com/default/topic/773623/linux/character-models-are-s...
https://bugs.winehq.org/show_bug.cgi?id=34052
arthur.huillet@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.huillet@free.fr
https://bugs.winehq.org/show_bug.cgi?id=34052
Lauern suruntuoja@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |suruntuoja@gmail.com
--- Comment #39 from Lauern suruntuoja@gmail.com --- Arch, wine 1.7.30, Xorg 1.16.2, Awesome
Compton running -> invisible characters Compton not running -> visible characters
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #40 from Nicky nheart@gmail.com --- (In reply to Deve from comment #38)
https://bugs.winehq.org/attachment.cgi?id=45260 Shani is the best :-D
I reported this bug to nvidia: https://devtalk.nvidia.com/default/topic/773623/linux/character-models-are- sometimes-invisible-in-the-witcher-game/
Hey,
nvidia guys are requesting more details. I have provided a post, but for some reason I've fallen victim to the auto banner of the nvidia forums. Please repost this:
As mentioned in the wine bug, it happens all the time to people using primus/optirun. The bug does occur when running an application directly on the nvidia card (via directly attached to the device display port) but much more rarely. It also occurs with nvidia prime setup but much more rarely.
Tl;Dr;
You need a dual video card machine where the nvidia card renders through bumblebee in order to get the bug every time. Otherwise it is a hit or a miss.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #41 from Lauern suruntuoja@gmail.com --- (In reply to Lauern from comment #39)
Arch, wine 1.7.30, Xorg 1.16.2, Awesome
Compton running -> invisible characters Compton not running -> visible characters
Forgot to mention, GTX 750 Ti with driver 343.22, single GPU so no optirun/bumblebee/whatever. GOG version of the game.
https://bugs.winehq.org/show_bug.cgi?id=34052
Kirill kirill.myxa@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kirill.myxa@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=34052
Stefan Dösinger stefan@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan@codeweavers.com
--- Comment #42 from Stefan Dösinger stefan@codeweavers.com --- Created attachment 50908 --> https://bugs.winehq.org/attachment.cgi?id=50908 wined3d: Reorder shader constants.
Can you give this patch a try? It may fix the bug.
The issue here is that The Witcher reads past the end of the vertex shader constant array and gets an undefined value back. On paper d3d promises to return (0.0, 0.0, 0.0, 0.0) in this case, which makes The Witcher happy. In practise d3d isn't reliable either, but reads > 255 return 0 and reads < 0 return other data.
If you have two GPUs please test this patch with both of them. There's a risk that this patch fixes Nvidia GPUs and breaks others.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #43 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Stefan Dösinger from comment #42)
Created attachment 50908 [details] wined3d: Reorder shader constants.
If you have two GPUs please test this patch with both of them. There's a risk that this patch fixes Nvidia GPUs and breaks others.
Indeed it does break rendering on Evergreen with Mesa :/ Specifically some wooden planks / wheels / boxes flicker with changing colors.
The patch seems to workaround the bug on Nvidia as expected.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #44 from Stefan Dösinger stefan@codeweavers.com --- I tested my patch on r600g and indeed some geometry that looked OK previously now starts to flicker.
With a different test I looked what the driver returns for reads with indices < 0 and > 255. My patch works as intended in the sense that it moves the int constants into the general range of c[-1] to c[-30]. Unfortunately the driver returns random values for uniforms that aren't defined by our shader, whereas Nvidia pretty reliably returns 0 for them. So instead of reading wrong but stable values (the int constants) the game now reads wrong and unstable values.
https://bugs.winehq.org/show_bug.cgi?id=34052
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sa@whiz.se
--- Comment #45 from Matteo Bruni matteo.mystral@gmail.com --- *** Bug 38711 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #46 from Matteo Bruni matteo.mystral@gmail.com --- Created attachment 51668 --> https://bugs.winehq.org/attachment.cgi?id=51668 Range check relative array accesses
I'm attaching an alternative fix from bug 38711. This one SHOULD work without regressions but it will probably have somewhat of a performance impact. AFAICS not even ARB_robust_buffer_access_behavior guarantees any specific result. From the spec: "Out-of-bounds reads return undefined values".
I'm not sure we want this patch in Wine but I don't know of any other "safe" fix.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #47 from Freso bugs.winehq.org@freso.dk --- The patch from comment #(In reply to Stefan Dösinger from comment #42)
Created attachment 50908 [details] wined3d: Reorder shader constants.
This patch fixes the issue for me.
https://bugs.winehq.org/show_bug.cgi?id=34052
Freso bugs.winehq.org@freso.dk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.winehq.org@freso.dk
--- Comment #48 from Freso bugs.winehq.org@freso.dk --- (In reply to Matteo Bruni from comment #46)
Created attachment 51668 [details] Range check relative array accesses
This patch also seems to work for me.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #49 from Freso bugs.winehq.org@freso.dk --- I've tested the two proposed patches. Is there anything else I can do to improve on the chances for a fix getting approved?
https://bugs.winehq.org/show_bug.cgi?id=34052
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW
--- Comment #50 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Freso from comment #49)
I've tested the two proposed patches. Is there anything else I can do to improve on the chances for a fix getting approved?
Thanks for testing!
No, I think that's all you can do. The problem is that my patch probably introduces a performance hit for a check that is usually unnecessary while Stefan's might not work depending on drivers' uniforms allocation patterns, so we don't have a clear way forward.
Maybe I should just go with something like my patch but with a registry setting to disable it?
https://bugs.winehq.org/show_bug.cgi?id=34052
neplatny.udaj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |neplatny.udaj@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #51 from Freso bugs.winehq.org@freso.dk --- I don't know the best way to move forward, but it would be great to not have to custom patch Wine on each update (though of course, at least there *is* a patch!), so if making a reg. entry for it is the best way to go, then please go for it. :)
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #52 from Lauern suruntuoja@gmail.com --- (In reply to Freso from comment #51)
I don't know the best way to move forward, but it would be great to not have to custom patch Wine on each update (though of course, at least there *is* a patch!), so if making a reg. entry for it is the best way to go, then please go for it. :)
Registry entry sounds good to me too, and would make it trivial to handle this with, for example, winetricks.
https://bugs.winehq.org/show_bug.cgi?id=34052
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |oneofone@gmail.com
--- Comment #53 from Ken Sharp imwellcushtymelike@gmail.com --- *** Bug 25696 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=34052
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sebastian.fieber@web.de
--- Comment #54 from Matteo Bruni matteo.mystral@gmail.com --- (Replying to bug 25696 comment 19) Fever, how much of a performance hit do you get with my patch?
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #55 from Fever sebastian.fieber@web.de --- (In reply to Matteo Bruni from comment #54)
(Replying to bug 25696 comment 19) Fever, how much of a performance hit do you get with my patch?
It seems like I was talking nonsense... just felt like it had less performance (last time I played the game was through NVIDIAS optimus support where you cannot switch and have lots of tearing there it felt a bit faster (or better I could turn on the AA) now I'm using bumblebee)
From what I get know from my benchmark I even get an overall performance gain
of 8 fps with this patch using primusrun. Plain wine run with primusrun I get like 30 fps in the temple quarter in vizima. With patch 38 and no artifacts. Measured over 2 minutes.
So I have to withdraw my previous comment when stating I got a performance hit.
Sorry for the false information!
Relevant System Information:
Awesome WM 1280x720 NVIDIA Corporation GK208M [GeForce GT 740M] Intel(R) Core(TM) i7-3612QM CPU @ 2.10GHz
Witcher Settings: No AA nor AF Rest to high.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #56 from Stefan Dösinger stefan@codeweavers.com --- A performance gain seems really odd. Are you sure you benchmarked it right?
I expect the performance impact of this change to only show up in a GPU-limited situation. So it'd be interesting to run on a high resolution with multisampling and filtering set to the maximum. You can also try my CSMT patches to speed up things on the CPU side and then apply Matteo's hack on top of that.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #57 from Fever sebastian.fieber@web.de --- I'm definetly not sure. I'll benchmark it again with your given advices. I also got a little heat problem with my laptop maybe that was the cause of the performance gain.
FYI I tried with your CSMT patches but this resulted for me in a very strange bug: periodically freezes of the picture. The game went on and jumped after a few seconds back to normal. Maybe I messed up the build so I'll try it again.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #58 from Fever sebastian.fieber@web.de --- This time I tried to be more precise. As soon as my cpu throttled down I stopped benchmarking (around a minute). This is without CSMT patches just because I don't have enough time today to apply the patches and recompile.
Settings: everything max 1366x768 (sry but my laptop display doesn't support higher resolutions and I don't have another machine or monitor at hand)
My results
Plain wine: 34.67 fps average (last time value has to be a thermal issue) patched wine: 33.68 fps average
I am still not quite sure if these values are correct as my cpu may be the problem, like I said I tried to only use the values before any overheating took place to get decent values but you never know :D. Maybe someone else should benchmark this too.
https://bugs.winehq.org/show_bug.cgi?id=34052
Andrew Pam xanni@glasswings.com.au changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xanni@glasswings.com.au
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #59 from Freso bugs.winehq.org@freso.dk --- Is anything holding back the/a patch right now? It would be great to not have to custom patch Wine every update. :)
https://bugs.winehq.org/show_bug.cgi?id=34052
Ian Higginson xeriouxi@fastmail.fm changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xeriouxi@fastmail.fm
https://bugs.winehq.org/show_bug.cgi?id=34052
deonix deonix@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |deonix@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=34052
Storm hewanci@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hewanci@gmail.com
--- Comment #60 from Storm hewanci@gmail.com --- Arch Linux, up to date packages NO bumblebee, NO optirun, ext4
Bug happens every single time, game is unplayable. :(
https://bugs.winehq.org/show_bug.cgi?id=34052
legluondunet@free.fr legluondunet@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |legluondunet@free.fr
--- Comment #61 from legluondunet@free.fr legluondunet@free.fr --- Bug still present with Wine 1.8rc1 each time I run the game.
My config: Ubuntu 15.10 Wily 64 bits NVIDIA GeForce GTX 770 official Ubuntu Nvidia drivers 340.93 resolution 1920x1080 Processor Intel i5-3570 3,4 Ghz 8 Go RAM
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #62 from Arthur Huillet arthur.huillet@free.fr --- Reproducing here my reply from https://devtalk.nvidia.com/default/topic/773623/linux/character-models-are-s...
---
We have investigated this issue and found out the cause of the problem. An OpenGL vertex shader (generated by Wine based on a D3D shader in the Witcher) is created with the following uniform: uniform vec4 vs_c[256];
The shader then dereferences vs_c[x], with "x" a dynamically computed value that sometimes exceeds 255. Reading outside of the bounds of a uniform array in GLSL is undefined behavior, which means that the implementation is allowed to do whatever it likes. On NVIDIA GPUs, the value returned will sometimes be 0.0, and sometimes different. Since this value is used to warp the bones of the characters (to animate them), having an unpredictable value can result in some vertices being offscreen and even some geometry disappearing entirely.
The problem is not a NVIDIA bug, since the application is asking the GPU to do something that is undefined in the specification. We have been working with Wine on the investigation of this issue, and have also communicated our findings to the developers of the game. A patch on the Wine bug tracker appears to work around the issue.
---
Arthur Huillet NVIDIA Linux Graphics
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #63 from Freso bugs.winehq.org@freso.dk --- attachment 50908 and attachment 51668 both work as workarounds, but the decisions seems to be to implement this in a toggleable fashion, since there might be a performance hit. I think we're waiting for either Fever to do more performance tests or Matteo Bruni to rewrite his patch. Not entirely sure which.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #64 from Storm hewanci@gmail.com --- I wonder, if the patches exist since several months, why a fix is still not implemented?
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #65 from Stefan Dösinger stefan@codeweavers.com --- Because it's a problem in one game only, it is arguably a game bug, and because the hack has the potential to cause a slowdown in all other games.
It would be nicer if we could get a semi-reliable 0.0 return from out of bounds reads without an explicit range check - attachment 50908 is an attempt in that direction, but it has other problems that are difficult to address.
https://bugs.winehq.org/show_bug.cgi?id=34052
Fincer fincer89@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fincer89@hotmail.com
https://bugs.winehq.org/show_bug.cgi?id=34052
Stefan Dösinger stefandoesinger@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|stefan@codeweavers.com |stefandoesinger@gmx.at
https://bugs.winehq.org/show_bug.cgi?id=34052
Sergey Isakov isakov-sl@bk.ru changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |isakov-sl@bk.ru
--- Comment #66 from Sergey Isakov isakov-sl@bk.ru --- (In reply to Stefan Dösinger from comment #65)
Because it's a problem in one game only, it is arguably a game bug, and because the hack has the potential to cause a slowdown in all other games.
It would be nicer if we could get a semi-reliable 0.0 return from out of bounds reads without an explicit range check - attachment 50908 [details] is an attempt in that direction, but it has other problems that are difficult to address.
Not one game. It seems bug 32273 is the same. Games Heroes of Might And Magic VI and King's Bounty:* affected same way. And only on Nvidia. The bug appears in MacOSX so it doesn't depend on linux drivers.
As well I encounter a bug with index shader out of range in game Sims 2 Season (bug 8051) that proposed a software rendering. I don't know if it is related just my thoughts.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #67 from legluondunet@free.fr legluondunet@free.fr --- I don't know if it is related to this bug: the "The longest Journey", some character models are sometimes invisible too: https://bugs.winehq.org/show_bug.cgi?id=11819 https://bugs.winehq.org/show_bug.cgi?id=31278
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #68 from Sergey Isakov isakov-sl@bk.ru --- (In reply to legluondunet@free.fr from comment #67)
I don't know if it is related to this bug: the "The longest Journey", some character models are sometimes invisible too: https://bugs.winehq.org/show_bug.cgi?id=11819 https://bugs.winehq.org/show_bug.cgi?id=31278
No, 11819 is a different bug. It is affected by Radeon drivers as well and corrected by those patchset.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #69 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Sergey Isakov from comment #66)
(In reply to Stefan Dösinger from comment #65)
Because it's a problem in one game only, it is arguably a game bug, and because the hack has the potential to cause a slowdown in all other games.
It would be nicer if we could get a semi-reliable 0.0 return from out of bounds reads without an explicit range check - attachment 50908 [details] is an attempt in that direction, but it has other problems that are difficult to address.
Not one game. It seems bug 32273 is the same. Games Heroes of Might And Magic VI and King's Bounty:* affected same way.
Does attachment 51668 make any difference for those games?
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #70 from Sergey Isakov isakov-sl@bk.ru --- (In reply to Matteo Bruni from comment #69)
(In reply to Sergey Isakov from comment #66)
(In reply to Stefan Dösinger from comment #65)
Because it's a problem in one game only, it is arguably a game bug, and because the hack has the potential to cause a slowdown in all other games.
It would be nicer if we could get a semi-reliable 0.0 return from out of bounds reads without an explicit range check - attachment 50908 [details] is an attempt in that direction, but it has other problems that are difficult to address.
Not one game. It seems bug 32273 is the same. Games Heroes of Might And Magic VI and King's Bounty:* affected same way.
Does attachment 51668 [details] make any difference for those games?
Yes, preliminary testing, not final. Attached screens before patching and after the patch. Game Might & Magic.Heroes 6.Gold Edition.v 2.1.1.0 + 4 DLC It is not me who tested ;( , in my case Radeon graphics has no such problem.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #71 from Sergey Isakov isakov-sl@bk.ru --- Created attachment 53516 --> https://bugs.winehq.org/attachment.cgi?id=53516 Missing parts with unpatched wine
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #72 from Sergey Isakov isakov-sl@bk.ru --- Created attachment 53517 --> https://bugs.winehq.org/attachment.cgi?id=53517 Good picture after the patch
The user has a crash but I waiting some more testing. It may be other reason.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #73 from John gandalf_cel_alb@yahoo.com --- So I started playing this game again after quite some time.
Now I have a different laptop, an Asus N550JV, running arch linux. I find that with the lastest wine (1.9.2-1), I get this bug if I activate my nvidia card, but I have no bug running on the Intel card. If there's some more advanced reports I can provide I would be happy to do so, but the game is playable for me on Intel right now.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #74 from Sergey Isakov isakov-sl@bk.ru --- New result. Patch from Matteo did the work. Patch from Stefan - no. Game Might & Magic.Heroes 6.Gold Edition.v 2.1.1.0. Nvidia graphics.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #75 from Matteo Bruni matteo.mystral@gmail.com --- A variant of my patch was just committed as 8e696dee5ff05377c8ccc59b4d204eb42d4cdeca. It's disabled by default, to enable it you can set the HKCU/Software/Wine/Direct3D/CheckFloatConstants registry key to "enabled".
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #76 from Sergey Isakov isakov-sl@bk.ru --- (In reply to Matteo Bruni from comment #75)
A variant of my patch was just committed as 8e696dee5ff05377c8ccc59b4d204eb42d4cdeca. It's disabled by default, to enable it you can set the HKCU/Software/Wine/Direct3D/CheckFloatConstants registry key to "enabled".
I got a message that the bug is fixed by this commit. Tested games: Heroes of Might & Magic VI King's Bounty: Armored Princess - bug 32273 Titan Quest - bug 25325 For my mind these bugs can be closed fixed by this commit.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #77 from Sergey Isakov isakov-sl@bk.ru --- Bug 30550 should be fixed as well if someone with Nvidia test it.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #78 from Fincer fincer89@hotmail.com --- CheckFloatConstants fixes same "invisible characters" issue in Grim Dawn, too.
https://bugs.winehq.org/show_bug.cgi?id=34052
Alessandro Pezzoni alessandro.pezzoni@runbox.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alessandro.pezzoni@runbox.c | |om
--- Comment #79 from Alessandro Pezzoni alessandro.pezzoni@runbox.com --- Enabling CheckFloatConstants doesn't fix bug 30550 (invisible sprites in Rayman Origins).
Tested on ArchLinux, wine version 1.9.5, with an nVidia GeForce 560 Ti, proprietary driver version 361.28.
https://bugs.winehq.org/show_bug.cgi?id=34052
Józef Kucia joseph.kucia@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |joseph.kucia@gmail.com Component|-unknown |directx-d3d
https://bugs.winehq.org/show_bug.cgi?id=34052
Maty Aguiló nckpau@openmailbox.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nckpau@openmailbox.org
--- Comment #80 from Maty Aguiló nckpau@openmailbox.org --- Enabling "CheckFloatConstants" works. I've played several hours without encountering this bug again. Archlinux, Wine 1.9.6 with the Nvidia blob (GTX 780ti)
https://bugs.winehq.org/show_bug.cgi?id=34052
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
https://bugs.winehq.org/show_bug.cgi?id=34052
vartaghan@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vartaghan@hotmail.com
--- Comment #81 from vartaghan@hotmail.com --- Hi all,
Tested today with Debian Jessie, wine 1.9.8 from the winehq repository, Nvidia blob (GTX680 - nouveau would not let me load a game).
Unfortunately, after 4 launches of the game, the bug was still present twice.
Do not hesitate to contact me to give further information, testing and logs if needed.
https://bugs.winehq.org/show_bug.cgi?id=34052
Ahmed W. oneofone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|oneofone@gmail.com |
https://bugs.winehq.org/show_bug.cgi?id=34052
super_man@post.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |super_man@post.com
--- Comment #82 from super_man@post.com --- (In reply to vartaghan from comment #81)
Hi all,
Tested today with Debian Jessie, wine 1.9.8 from the winehq repository, Nvidia blob (GTX680 - nouveau would not let me load a game).
Unfortunately, after 4 launches of the game, the bug was still present twice.
Do not hesitate to contact me to give further information, testing and logs if needed.
"A variant of my patch was just committed as 8e696dee5ff05377c8ccc59b4d204eb42d4cdeca. It's disabled by default, to enable it you can set the HKCU/Software/Wine/Direct3D/CheckFloatConstants registry key to "enabled". "
Did you enable the patch before testing?
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #83 from vartaghan@hotmail.com --- I had to create the HKCU/Software/Wine/Direct3D/CheckFloatConstants registry key as there was no Direct3D under Wine in my registry. I set it to "enabled" (double quote included).
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #84 from super_man@post.com --- I think you shouldnt include "" in registery.
https://bugs.winehq.org/show_bug.cgi?id=34052
Josh winehq@iooioio.orion.uberspace.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|winehq@iooioio.orion.ubersp | |ace.de |
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #85 from vartaghan@hotmail.com --- I removed the quotes and the bug did not reproduce so far on about half a dozen launch. My bad, I think it's good now.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #86 from Bruno Jesus 00cpxxx@gmail.com --- Matteo, the patch was committed (8e696dee5ff05377c8ccc59b4d204eb42d4cdeca) and the game works, so we can consider it as fixed using the registry switch or there are more things to do in order to fix this?
https://bugs.winehq.org/show_bug.cgi?id=34052
Ottopower ottopower8@inbox.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ottopower8@inbox.com
--- Comment #87 from Ottopower ottopower8@inbox.com --- Tested with all the King's Bounty in the Ultimate Edition (more than 10 hours with King's Bounty The Legend) and Fantasy Wars and it works perfectly.
https://bugs.winehq.org/show_bug.cgi?id=34052
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |8e696dee5ff05377c8ccc59b4d2 | |04eb42d4cdeca
--- Comment #88 from Bruno Jesus 00cpxxx@gmail.com --- (In reply to vartaghan from comment #85)
I removed the quotes and the bug did not reproduce so far on about half a dozen launch. My bad, I think it's good now.
(In reply to Ottopower from comment #87)
Tested with all the King's Bounty in the Ultimate Edition (more than 10 hours with King's Bounty The Legend) and Fantasy Wars and it works perfectly.
Assuming as fixed by 2 different people.
https://bugs.winehq.org/show_bug.cgi?id=34052
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #89 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.9.11.
https://bugs.winehq.org/show_bug.cgi?id=34052
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mstefani@redhat.com Target Milestone|--- |1.8.x
https://bugs.winehq.org/show_bug.cgi?id=34052
Michael Stefaniuc mstefani@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.8.x |---
--- Comment #90 from Michael Stefaniuc mstefani@redhat.com --- Removing 1.8.x milestone from bugs included in 1.8.4.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #91 from Nicky nheart@gmail.com --- Could someone please add the option in the "Useful registry keys" wiki ( https://wiki.winehq.org/Useful_Registry_Keys ) so I don't have to browse through the bug report to find the workaround. I would do it myself, but I don't have access.
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #92 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Nicky from comment #91)
Could someone please add the option in the "Useful registry keys" wiki ( https://wiki.winehq.org/Useful_Registry_Keys )
I already did some time ago.
https://bugs.winehq.org/show_bug.cgi?id=34052
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rechapita@hotmail.com
--- Comment #93 from Matteo Bruni matteo.mystral@gmail.com --- *** Bug 25325 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=34052
--- Comment #94 from Józef Kucia joseph.kucia@gmail.com --- *** Bug 32273 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=34052
Bruno Jesus 00cpxxx@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nieknooijens@gmail.com
--- Comment #95 from Bruno Jesus 00cpxxx@gmail.com --- *** Bug 39176 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=34052
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |russianneuromancer@ya.ru
--- Comment #96 from Jeff Zaroyko jeffz@jeffz.name --- *** Bug 28062 has been marked as a duplicate of this bug. ***
https://bugs.winehq.org/show_bug.cgi?id=34052
fungos danny.cabelo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |danny.cabelo@gmail.com
--- Comment #97 from fungos danny.cabelo@gmail.com --- Hello, just to give more (unneeded) feedback! :)
With Manjaro, GTX 770, Drivers 470.94, wine 7.0-rc2 the issue was 100%. After a bit googling I found the NVidia discussion and the link to this issue.
Adding the registry key solved it, thanks Matteo!
-
wine-bugs＠winehq.org -
WineHQ Bugzilla