[Bug 21295] New: Painkiller and Painkiller Black Edition cannot accept CD Key submission preventing installation
http://bugs.winehq.org/show_bug.cgi?id=21295
Summary: Painkiller and Painkiller Black Edition cannot accept CD Key submission preventing installation Product: Wine Version: 1.1.36 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: blocker Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: aka.motub@gmail.com CC: aka.motub@gmail.com
My experience is with the Black Edition and Wine versions 1.1.35 and 1.1.36; this was also "reported" for the regular 1.00 version and Wine 1.1.33 in a comment here: http://appdb.winehq.org/objectManager.php?sClass=version&iId=3824 .
The installer starts fine, and indeed the CD Key validation box appears correctly and allows the input of the key. Even pasting of the key from the Clipboard to the input box works correctly (it didn't in 1.1.35).
However, no "OK" or "Accept" or "Contunue" button appears at the bottom of the dialog (even with window decorations turned off, and while emulating a virtual desktop), once you have input the key, there is no way to continue the installation.
All previous dialogs (meaning the main VISE installer window and the previous EULA and install chooser dialogs) appeared correctly and with whatever buttons were appropriate in proper working order).
The only error reported in a console install attempt is
fixme:win:LockWindowUpdate (0x70036), partial stub! fixme:win:LockWindowUpdate ((nil)), partial stub!
The main installer window can be exited with the Cancel button, however the CD Key Validation window itself must be killed from the System Monitor (I use GNOME), because it does not close when the main installer exits.
OS: Linux Mint 8 (Helena) (based on Ubunto 9.10 Wine 1.1.36 Overrides listed in global: gdiplus, mscrvt
I'm attempting to keep my "native" libraries to a minimal "install as/if needed" basis, so I've only installed (via Winetricks) DOTNet 2.0, vcrun2003, 2005, and 2008, vbrun 6, quicktime, corefonts, tahoma and the fontfix, which are needed for other games/apps I run under Wine. The games/apps that need these subsystems are all working fine, and the other games I have installed that don't use these functions are also working fine, so I don't feel that there has been a general 'disturbance in the Force' due to their installation. If there is a subsystem available via winetricks that would (help) resolve this which I don't have installed, please advise. I'm happy to test.
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #1 from Wylda wylda@volny.cz 2010-01-09 10:09:13 --- Created an attachment (id=25624) --> (http://bugs.winehq.org/attachment.cgi?id=25624) comparison Wine vs WinXP
Hi Hooly, i own several edition of painkiller and for the test i pick up the Black Edition. Maybe i did not understand your report correctly, so please explain what is the problem - also you can (better) attach a screen shot with description.
From my testing i don't see any problem. Attached screen shot is the same for
all the following wine versions:
* 0.9.49, 0.9.60, 1.0.1, 1.1.5, 1.1.10, 1.1.16, 1.1.19, 1.1.24, 1.1.29, 1.1.32, 1.1.36
I also thought it is a problem, but then compared to WinXP behaviour and it is the same like in Wine. So please explain otherwise it could happen that this bug report will be marked as invalid.
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #2 from Holly Bostick aka.motub@gmail.com 2010-01-09 10:53:40 --- Wylda, thank you for the screenshots. I've never installed PK under Windows, so I was not aware that there apparently is no submission button--- but if that's the case, what precisely is supposed to happen when you enter your CD Key?
Because whatever mechanism is supposed to 'read' the input box and then proceed, or even pop up a message saying "this key is invalid" (not that it is, but one could mistype), is not happening.
Basically, I enter the cd key and nothing further occurs. The cd key dialog does not 'go away' (accept the submission), and the installation dialog (underneath the cd key dialog window) shows no sign of proceeding.
I thought this was because I needed to click an 'OK' button (that did not appear), but now I see that this is not the problem (because said button does not exist).
May I request that you attempt to complete the install with Wine and let me know if it's a Wine problem or just my (and that other person's) problem?
If it's my problem, my humble apologies for the noise, and if it is a bug, I apologize for the mislabeling.
http://bugs.winehq.org/show_bug.cgi?id=21295
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal
--- Comment #3 from Austin English austinenglish@gmail.com 2010-01-09 12:02:03 --- Not a blocker. Please retest in a clean WINEPREFIX, with no native overrides and attach terminal output.
Native riched20/30 may help, but test with all builtin first.
http://bugs.winehq.org/show_bug.cgi?id=21295
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |wylda@volny.cz
--- Comment #4 from Wylda wylda@volny.cz 2010-01-09 13:07:10 --- (In reply to comment #2)
... what precisely is supposed to happen when you enter your CD Key?
You enter the key and nothing happens. It is normal behaviour even on WinXP. To continue with the installation you have to put your legaly owned key _and_ press ENTER key.
This is normal behaviour, i.e. not a wine bug, thus INVALID.
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #5 from Holly Bostick aka.motub@gmail.com 2010-01-09 18:30:55 --- I went to a friend's and attempted the install on XP. It works fine.
The problem seems to be that the Enter key is not being recognized under Wine, insofar as when I hit it (which of course I do, if only by reflex, when inputting a text field such as that), there is no further response from the installer, as opposed to XP where the key is accepted, the validation window disappears and the install proceeds in the main installer window.
Hitting Enter is so reflexive to me that I didn't realize that I had to mention, in the first case, or indeed that it was itself the problem (after further testing).
I notice that the only other bugs/issues associated with Painkiller seem to be keyboard related; is it possible that the issue extends to the installer as well?
I also tried setting the installer to Win2000 and 98; no effect.
Is there any native override that might resolve the lack of recognition of the Enter key in this window?
In any case, although I was wrong about the reason, I seem to have labeled the issue correctly. The non-recognition of the Enter key prevents the CD Key from being submitted and accepted, therefore the install does not proceed.
Can someone confirm or suggest a workaround?
http://bugs.winehq.org/show_bug.cgi?id=21295
brebs@sent.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |brebs@sent.com
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #6 from Holly Bostick aka.motub@gmail.com 2010-03-14 09:08:12 --- Issue persists in wine 1.1.40.
A completely clean .wine folder does not resolve.
I have successfully installed PK_BE from the same DVD on a separate Windows computer, so the issue is not with my DVD or DVD key input.
I have also installed successfully from the same DVD on the Windows dual-boot remaining on my Linux PC, so the issue is not my keyboard.
Restatement of the issue: While installing Painkiller Black Edition, I input the DVD key and press 'Enter'. The Enter key (neither the main key nor the numpad key) does not register to the CD-Key Validation application window as pressed. Because the Enter key is never recognized as pressed to confirm and complete submission of the CD-Key, the key is not submitted for validation, and the install can/will not proceed until key validation occurs. The main installer window (PKBE_Setup.exe) can be cancelled normally (the 'Cancel' button is still visible behind the CD-Key Validation window) but the CD-Key validation window (PKBE.exe), having no buttons, can not be exited other than by killing the application in the System Monitor.
Still hoping for a confirmation of the issue (and hopefully a fix thereafter). The install does not have to be completed (once the CD-Key is validated and the files begin to copy, one can cancel)-- I would just like someone to attempt the install and confirm or refute that when the key is input and Enter is pressed, whether pressing the Enter key succeeds in submitting the CD-Key to the validation window, which it does not for me under Wine (though it does under Windows).
http://bugs.winehq.org/show_bug.cgi?id=21295
brebs@sent.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #7 from brebs@sent.com 2010-03-14 11:40:59 --- *** This bug has been confirmed by popular vote. ***
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #8 from Wylda wylda@volny.cz 2010-03-21 01:50:50 ---
This is indeed a regression... Dialog box for serial key doesn't have OK/Submit button and after entering the serial one must press Enter key to begin the installation. This is broken since 1.1.29 (no reaction when Enter is pressed).
1. Confirming, please consider KEYWORDS: +REGRESSION, +INSTALLER
2. I did a regression test between 1.1.28 and 1.1.29:
commit f1f1c5053160777d0db89b1891706b0b960d3d48 Author: Sergey Khodych khodych@gmail.com Date: Tue Aug 25 17:19:24 2009 +0300
user32: Use IDOK as default identifier in a template.
:040000 040000 ec277af366bead5d55f43d7fd8790c90b09a0fef 99d660168abb7fa82689691408113ac39339a863 M dlls
3. No other bug report suffers from this commit.
4. Revert of this patch on top of wine-1.1.38 makes that problem go away. Wine-1.1.38 is the last version, where can i revert the patch.
5. Adding author of this patch to CC.
--private keyword: bisected
I'm a bit disappointed, because the commit comes with tests and even though causes a regression.
PS: Holly, work around is installation in version 1.1.28 or lower (1.0.1 is also OK).
http://bugs.winehq.org/show_bug.cgi?id=21295
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |khodych@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=21295
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer, regression
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #9 from Wylda wylda@volny.cz 2010-04-18 06:09:02 ---
Shouldn't be the component set to user32?
http://bugs.winehq.org/show_bug.cgi?id=21295
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dank@kegel.com Component|-unknown |user32
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #10 from Wylda wylda@volny.cz 2010-04-30 16:52:14 ---
Following patch fixes the issue for wine-1.1.43-408-g3317fc3. Wasn't idResult omitted by mistake during some rewrite?
--- orig/dlls/user32/dialog.c 2010-04-30 23:38:53.000000000 +0200 +++ new/dlls/user32/dialog.c 2010-04-30 23:39:44.000000000 +0200 @@ -672,6 +672,7 @@ dlgInfo->hMenu = hMenu; dlgInfo->xBaseUnit = xBaseUnit; dlgInfo->yBaseUnit = yBaseUnit; + dlgInfo->idResult = 0; dlgInfo->flags = flags;
if (template.helpId) SetWindowContextHelpId( hwnd, template.helpId );
http://bugs.winehq.org/show_bug.cgi?id=21295
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #11 from Dmitry Timoshkov dmitry@codeweavers.com 2010-05-01 02:48:45 --- (In reply to comment #10)
Following patch fixes the issue for wine-1.1.43-408-g3317fc3. Wasn't idResult omitted by mistake during some rewrite?
It's been removed by http://source.winehq.org/git/wine.git/?a=commitdiff;h=a64765f673b01944ebf5da...
http://bugs.winehq.org/show_bug.cgi?id=21295
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |julliard@winehq.org
--- Comment #12 from Wylda wylda@volny.cz 2010-05-01 03:04:00 ---
It's been removed by http://source.winehq.org/git/wine.git/?a=commitdiff;h=a64765f673b01944ebf5da...
Than lets add Alexandre...
BTW: Dimitry how do you find that commit? Could you leave the complete command here for educational purposes? ;)
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #13 from Dan Kegel dank@kegel.com 2010-05-01 09:02:13 --- git bisect run grep?
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #14 from Dmitry Timoshkov dmitry@codeweavers.com 2010-05-01 11:00:25 --- (In reply to comment #12)
BTW: Dimitry how do you find that commit? Could you leave the complete command here for educational purposes? ;)
I tried 'git blame' but didn't find anything useful, so I proceeded with 'git whatchanged' and looked for every recent commit which touched dlls/user32/dialog.c
http://bugs.winehq.org/show_bug.cgi?id=21295
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |juvanham@nerdshack.com
--- Comment #15 from Austin English austinenglish@gmail.com 2010-05-11 10:56:47 --- *** Bug 22544 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=21295
Louis Lenders xerox_xerox2000@yahoo.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |xerox_xerox2000@yahoo.co.uk
--- Comment #16 from Louis Lenders xerox_xerox2000@yahoo.co.uk 2010-05-12 12:33:52 --- added author of patch
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #17 from Wylda wylda@volny.cz 2010-05-15 13:48:39 ---
added author of patch
Hi Louis, you add just yourself. Is that correct? Because these patches were not written by you.
http://bugs.winehq.org/show_bug.cgi?id=21295
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|1.1.36 |1.1.29
--- Comment #18 from Wylda wylda@volny.cz 2010-06-15 16:11:54 ---
This regression (bisected) is still present in wine-1.2-rc3-57-gb3f0425 (relevant part comment #8 ~ #11).
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #19 from Wylda wylda@volny.cz 2010-06-19 09:52:38 ---
I saw something in git which could be related to this one, but unfortunately regression still present in wine-1.2-rc4.
http://bugs.winehq.org/show_bug.cgi?id=21295
Vlastimil Babka caster@gentoo.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |caster@gentoo.org
http://bugs.winehq.org/show_bug.cgi?id=21295
Mike Swanson mikeonthecomputer@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mikeonthecomputer@gmail.com
--- Comment #20 from Mike Swanson mikeonthecomputer@gmail.com 2010-08-12 17:28:27 --- Still present on Wine 1.3.0
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #21 from Wylda wylda@volny.cz 2010-08-22 09:04:51 ---
Still present on Wine 1.3.1.
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #22 from Wylda wylda@volny.cz 2010-09-09 06:39:59 CDT ---
This regression (bisected) is still present in wine-1.3.2-115-gd822555.
http://bugs.winehq.org/show_bug.cgi?id=21295
Vladimir Panteleev thecybershadow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |thecybershadow@gmail.com
--- Comment #23 from Vladimir Panteleev thecybershadow@gmail.com 2010-09-14 21:08:54 CDT --- The patch attached to Bug 23453 seems to fix this. However, it does not fix Bug 22544, which has been (apparently incorrectly) marked as a duplicate of this bug.
Bug 22544 somehow relies on the result of DM_GETDEFID, but the message isn't being sent from IsDialogMessage like here and Bug 23453.
For the record, this bug, Bug 23453 and Bug 23936 seem to be caused by the same problem.
http://bugs.winehq.org/show_bug.cgi?id=21295
--- Comment #24 from Dmitry Timoshkov dmitry@codeweavers.com 2010-09-15 23:06:27 CDT --- Please retest with today's git, the problem might be fixed by http://source.winehq.org/git/wine.git/?a=commit;h=592d994f0077c19dc9fa2db988...
http://bugs.winehq.org/show_bug.cgi?id=21295
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #25 from Wylda wylda@volny.cz 2010-09-18 14:58:39 CDT ---
Confirming, FIXED in wine-1.3.3.
Particular commit (wine-1.3.2-250-g592d994): http://source.winehq.org/git/wine.git/?a=commit;h=592d994f0077c19dc9fa2db988...
Thank you Vladimir.
http://bugs.winehq.org/show_bug.cgi?id=21295
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #26 from Alexandre Julliard julliard@winehq.org 2010-10-01 13:58:03 CDT --- Closing bugs fixed in 1.3.4.
http://bugs.winehq.org/show_bug.cgi?id=21295
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |1.2.x
http://bugs.winehq.org/show_bug.cgi?id=21295
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|1.2.x |---
--- Comment #27 from Alexandre Julliard julliard@winehq.org 2010-10-08 10:41:01 CDT --- Removing 1.2.x milestone from bugs fixed in 1.2.1.
http://bugs.winehq.org/show_bug.cgi?id=21295
Wylda wylda@volny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |592d994f0077c19dc9fa2db988f | |70d5d4c2a9cdb Regression SHA1| |f1f1c5053160777d0db89b18917 | |06b0b960d3d48
-
wine-bugs＠winehq.org