[Bug 52721] New: d3dx9_36:effect, d3dx11_42:d3dx11 and d3dx11_43:d3dx11 broken by use of vkd3d_shader_compile() for D3DCompile2()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52721

Bug ID: 52721
           Summary: d3dx9_36:effect, d3dx11_42:d3dx11 and d3dx11_43:d3dx11
                    broken by use of vkd3d_shader_compile() for
                    D3DCompile2()
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d-util
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

A recent patch to use vkd3d_shader_compile() to implement D3DCompile2() broke
d3dx11_42:d3dx11 and d3dx11_43:d3dx11. In both cases it leads to a crash:

d3dx11.c:580: Test failed: Got unexpected errors.
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code
(0x70bb0990).
[...]
Backtrace:
=>0 0x70bb0990 strrchr+0x10(str=0x000000000, c=0x5c)
[Z:\home\winetest\winetest\src\dlls\msvcrt\string.c:3166] in ucrtbase
(0x0031d9b8)
  1 0x69d8bcc9 d3dcompiler_include_from_file_open+0x49(iface=<internal error>,
include_type=<internal error>, filename=<internal error>, parent_data=<internal
error>, data=<internal error>, bytes=<internal error>)
[Z:\home\winetest\winetest\src\dlls\d3dcompiler_43\compiler.c:521] in
d3dcompiler_47 (0x0031db28)

https://test.winehq.org/data/patterns.html#d3dx11_42:d3dx11
https://test.winehq.org/data/patterns.html#d3dx11_43:d3dx11

d3dx9_36:effect got broken too but at least in this case it's because of
successes in todos so it's probably a trivial fix:

effect.c:8108: Test succeeded inside todo block: Unexpected error, hr
0x80004005.
effect.c:8133: Test succeeded inside todo block: D3DXInclude test failed with
error 0x80004005.

https://test.winehq.org/data/patterns.html#d3dx9_36:effect

The commit that caused these new failures is:

commit 6a062afb75c1e026614403312f2e13207e359634 (HEAD, refs/bisect/bad)
Author: Zebediah Figura 
Date:   Thu Mar 3 20:25:26 2022 -0600

d3dcompiler: Implement D3DCompile2() using vkd3d_shader_compile().

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51713
    Signed-off-by: Zebediah Figura 
    Signed-off-by: Matteo Bruni 
    Signed-off-by: Alexandre Julliard

[Bug 52721] d3dx9_36:effect, d3dx11_42:d3dx11 and d3dx11_43:d3dx11 broken by use of vkd3d_shader_compile() for D3DCompile2()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52721

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |6a062afb75c1e026614403312f2
                   |                            |e13207e359634
           Keywords|                            |regression, source,
                   |                            |testcase

[Bug 52721] d3dx9_36:effect, d3dx11_42:d3dx11 and d3dx11_43:d3dx11 broken by use of vkd3d_shader_compile() for D3DCompile2()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52721

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |f26fa0465626561bc531dfda32a
                   |                            |9e90e9d52c3cd
         Resolution|---                         |FIXED

--- Comment #1 from François Gouget  ---
This is fixed in all three tests. There are at least two commits involved in
the fix:

commit 8956862e0a7fec92a983a455ea902a61f83d28da
Author: Matteo Bruni 
Date:   Mon Mar 28 14:12:17 2022 +0200

d3dx9/tests: Fix tests broken by using the HLSL compiler from vkd3d-shader.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52721
    Signed-off-by: Matteo Bruni 
    Signed-off-by: Alexandre Julliard

commit f26fa0465626561bc531dfda32a9e90e9d52c3cd
Author: Matteo Bruni 
Date:   Mon Mar 28 14:12:16 2022 +0200

d3dx11/tests: Fix tests broken by using the HLSL compiler from
vkd3d-shader.

Signed-off-by: Matteo Bruni 
    Signed-off-by: Alexandre Julliard

[Bug 52721] d3dx9_36:effect, d3dx11_42:d3dx11 and d3dx11_43:d3dx11 broken by use of vkd3d_shader_compile() for D3DCompile2()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52721

--- Comment #2 from Matteo Bruni  ---
Correct, also this one for the d3dx11 test crashes:

commit 8a7651fd36ebf9850cc63327f465859b70cc40b8
Author: Matteo Bruni 
Date:   Mon Mar 28 14:12:15 2022 +0200

d3dcompiler: Set initial_filename in D3DCompile2().

Signed-off-by: Matteo Bruni 
    Signed-off-by: Alexandre Julliard

Thanks for reporting the bug!

[Bug 52721] d3dx9_36:effect, d3dx11_42:d3dx11 and d3dx11_43:d3dx11 broken by use of vkd3d_shader_compile() for D3DCompile2()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52721

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 7.6.