[Bug 23143] New: SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

Summary: SlingPlayer 2 unable to remember password
           Product: Wine
           Version: 1.1.39
          Platform: x86
               URL: http://download.slingmedia.com/player/pc/SlingPlayer-2
                    .0.4-Setup.exe
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: trivial
          Priority: P3
         Component: msxml3
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
        Depends on: 23082

Created an attachment (id=28779)
 --> (http://bugs.winehq.org/attachment.cgi?id=28779)
Wine ~1.1.38 +msxml (working)

SlingPlayer 2 can read a password that has been saved using a previous version
of Wine, but is unable to save a new password.

Result of bisect:

f414d3cf60081d47edc88783fc71ddd933c31cf7 is the first bad commit
commit f414d3cf60081d47edc88783fc71ddd933c31cf7
Author: Nikolay Sivov 
Date:   Fri Feb 12 22:34:50 2010 +0300

msxml3: Reimplement IXMLDOMDocument::createAttribute() on top of
::createNode().

:040000 040000 2e1929ed92ed14c98175f7567bc78f5afdaddb2c
80e7d1759d6fb08f66920f858e4dfd2cb0ba85f7 M    dlls

http://source.winehq.org/git/wine.git/?a=commitdiff;h=f414d3cf60081d47edc887...

Native msxml3 works.

I have attached two +msxml traces: one from before the commit and one from
after the commit.

[Bug 23143] SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #28779|Wine ~1.1.38 +msxml         |Wine 1.1.39 +msxml (not
        description|(working)                   |working)

[Bug 23143] SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

--- Comment #1 from Ken Sharp   2010-06-12 15:48:35 ---
Created an attachment (id=28780)
 --> (http://bugs.winehq.org/attachment.cgi?id=28780)
Wine ~1.1.38 +msxml (working)

[Bug 23143] SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

--- Comment #2 from Nikolay Sivov   2010-06-12 16:51:33 ---
Created an attachment (id=28783)
 --> (http://bugs.winehq.org/attachment.cgi?id=28783)
patch

Try this one.

[Bug 23143] SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Ken Sharp   2010-06-12 18:31:16 ---
Yup.  That works.

[Bug 23143] SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

--- Comment #4 from Nikolay Sivov   2010-06-12 18:43:52 ---
(In reply to comment #3)
> Yup.  That works.

Ok, will send it next week. It's another case when app developer doesn't expect
a Spanish Inquisition with fear and surprise as weapons - passed string isn't a
valid BSTR it seems. We still have some similar cases after this patch that
need tests and most likely a fix too.

[Bug 23143] SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Nikolay Sivov   2010-06-14 13:11:33 ---
Fixed by 36117911171dc30fd1c64ce972ecf7cc479bb63f.

[Bug 23143] SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard   2010-06-18 12:47:50 ---
Closing bugs fixed in 1.2-rc4.

[Bug 23143] SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |36117911171dc30fd1c64ce972e
                   |                            |cf7cc479bb63f
    Regression SHA1|                            |f414d3cf60081d47edc88783fc7
                   |                            |1ddd933c31cf7

[Bug 23143] SlingPlayer 2 unable to remember password

http://bugs.winehq.org/show_bug.cgi?id=23143

Bug 23143 depends on bug 23082, which changed state.

Bug 23082 Summary: SlingPlayer 2.x fails when connecting
http://bugs.winehq.org/show_bug.cgi?id=23082

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED