[Bug 29285] New: Arcanum: screen resolution stays at 800x600 after exiting the game

http://bugs.winehq.org/show_bug.cgi?id=29285

Bug #: 29285
           Summary: Arcanum: screen resolution stays at 800x600 after
                    exiting the game
           Product: Wine
           Version: 1.3.34
          Platform: x86
               URL: http://www.fileplanet.com/59649/50000/fileinfo/Arcanum
                    :-Of-Steamworks-&-Magick-Obscura-Demo
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: minor
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: ecb2859d3c3beedb0af7de26e4f21d664513cca2

Now that bug #27730 has been fixed the game exits normally, but I noticed that
Wine doesn't restore the original desktop resolution after exiting the game.
The screen stays at 800x600 resolution after quitting the game. This is
reproducible with both the demo and the latest officially patched game version,
also sold by GOG.com (v1.0.7.4). The problem also occurs with the unofficial
high resolution (widescreen) mods.

Terminal output doesn't reveal anything interesting.

This is due to the following commit:

ecb2859d3c3beedb0af7de26e4f21d664513cca2 is the first bad commit
commit ecb2859d3c3beedb0af7de26e4f21d664513cca2
Author: Henri Verbeet 
Date:   Tue Dec 6 22:57:45 2011 +0100

ddraw: Destroy the swapchain in the DllMain() cleanup handler.

This is mostly to make sure there aren't any resources still being
referenced
    by wined3d.

:040000 040000 f870ca5647965563b890c460877daa08b978e754
b92e709b107dbb760d37fd4a3534b42d4d269cb9 M    dlls

Reverting the patch on the current git version (wine-1.3.34-166-g71199ea) fixed
the problem.

Fedora 16 x86
X.Org X Server 1.11.2
Nvidia 250 / driver 290.10
Gnome 3 + Mutter (compositing) / Gnome 2 + Metacity (non-compositing)

[Bug 29285] Arcanum: screen resolution stays at 800x600 after exiting the game

http://bugs.winehq.org/show_bug.cgi?id=29285

--- Comment #1 from Henri Verbeet  2011-12-09 08:10:10 CST ---
Created attachment 37880
  --> http://bugs.winehq.org/attachment.cgi?id=37880
patch

Oops, this patch should help.

[Bug 29285] Arcanum: screen resolution stays at 800x600 after exiting the game

http://bugs.winehq.org/show_bug.cgi?id=29285

--- Comment #2 from GyB  2011-12-09 08:32:11 CST ---
(In reply to comment #1)
> Created attachment 37880 [details]
> patch
>
> Oops, this patch should help.

The patch fixed the problem here as well.

[Bug 29285] Arcanum: screen resolution stays at 800x600 after exiting the game

http://bugs.winehq.org/show_bug.cgi?id=29285

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9d55388156e5b95104d4c856673
                   |                            |9ce6e9b81ba24
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from GyB  2011-12-12 12:50:56 CST ---
Fixed in wine-1.3.34-252-g3046768. Thank you.

http://source.winehq.org/git/wine.git/commit/9d55388156e5b95104d4c8566739ce6...

[Bug 29285] Arcanum: screen resolution stays at 800x600 after exiting the game

http://bugs.winehq.org/show_bug.cgi?id=29285

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2011-12-16 13:30:56 CST ---
Closing bugs fixed in 1.3.35.