[Bug 46593] New: LXR: Incorrect display width of author names containing utf-8 characters

https://bugs.winehq.org/show_bug.cgi?id=46593

Bug ID: 46593
           Summary: LXR: Incorrect display width of author names
                    containing utf-8 characters
           Product: WineHQ.org
           Version: unspecified
          Hardware: Other
                OS: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: www-unknown
          Assignee: [e-mail]
          Reporter: [e-mail]

Follow up from bug 25453:
> > Is there something else to fix?
>
> Well, at least in my browser, there's an indentation or rather an I18N
> issue: Every line whose author's name contains umlauts is misindented:
> > 4aa5f5bc Jörg *0023 #include "windows.h"
> > 6698e9e0 Jan Ze*0024 #include "mmsystem.h"
>
> Perhaps the string length function that LXR uses to calculate the display
> width produces incorrect values for "Jörg", e.g. 5 instead of 4. That would
> explain what I see. But that would warrant another bug entry.

[Bug 46593] LXR: Incorrect display width of author names containing utf-8 characters

https://bugs.winehq.org/show_bug.cgi?id=46593

--- Comment #1 from Olivier F. R. Dierick  ---
Created attachment 63488
  --> https://bugs.winehq.org/attachment.cgi?id=63488
Assume GIT command output is utf-8.

LXR uses GIT to fetch the author names from the commits.
The issue is that utf-8 bit is not set on the strings from the output of GIT
commands.
The length calculation is then done on internal bytes rather than utf-8
characters.

WineHQ.org uses LXR version 2.0.2.
LXR version 2.1.0 includes a fix for utf-8 support for GIT commands.
The attached patch is based on that fix.

[Bug 46593] LXR: Incorrect display width of author names containing utf-8 characters

https://bugs.winehq.org/show_bug.cgi?id=46593

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]
                   |                            |t, [e-mail]

--- Comment #2 from Olivier F. R. Dierick  ---
CCing Jörg Höhle and Alexandre Julliard.

[Bug 46593] LXR: Incorrect display width of author names containing utf-8 characters

https://bugs.winehq.org/show_bug.cgi?id=46593

--- Comment #3 from Olivier F. R. Dierick  ---
Fix in LXR 2.1.0 source code:
https://sourceforge.net/p/lxr/git_repo/ci/640373086f5a451fcb54ec22caf956ac18...

[Bug 46593] LXR: Incorrect display width of author names containing utf-8 characters

https://bugs.winehq.org/show_bug.cgi?id=46593

Olivier F. R. Dierick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

[Bug 46593] LXR: Incorrect display width of author names containing utf-8 characters

https://bugs.winehq.org/show_bug.cgi?id=46593

--- Comment #4 from Alexandre Julliard  ---
I upgraded LXR, but it seems the index needs to be rebuilt, that may take a
while...

[Bug 46593] LXR: Incorrect display width of author names containing utf-8 characters

https://bugs.winehq.org/show_bug.cgi?id=46593

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Alexandre Julliard  ---
It seems OK now.

[Bug 46593] LXR: Incorrect display width of author names containing utf-8 characters

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=46593

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Ken Sharp  ---
Closing