[Bug 39355] New: The Guild 2 Demo installer crashes when starting copying files

https://bugs.winehq.org/show_bug.cgi?id=39355

Bug ID: 39355
           Summary: The Guild 2 Demo installer crashes when starting
                    copying files
           Product: Wine
           Version: 1.7.43
          Hardware: x86
               URL: http://www.fileplanet.com/169779/160000/fileinfo/The-G
                    uild-2-Demo
                OS: Linux
            Status: UNCONFIRMED
          Keywords: download, Installer, regression
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: f920dfd6984ca9227900d0f0406afb3ceb892cc5
      Distribution: ---

Created attachment 52447
  --> https://bugs.winehq.org/attachment.cgi?id=52447
terminal output/backtraces

To reproduce the problem start the installer with Setup.exe, follow the steps
by clicking <Next>. When the installer is about to start copying the files, it
crashes with a backtrace which looks like some kind of heap corruption.
The attachment contains 2 different backtraces, the first one was produced in
Wine that was compiled with -O2 opt. level, the second one with -O0.

According to my testing the crash was introduced by

commit f920dfd6984ca9227900d0f0406afb3ceb892cc5
Author: Alex Henrie 
Date:   Wed May 13 00:33:13 2015 -0600

user32: Load hIconSmIntern from the best-matching resource.

The installer works properly with the previous commit (it just takes a very
long time to finish installation, but that was the same with previous versions
too).

wine-1.7.51-225-g3966aff
Fedora 22 32-bit

Guild_2_Demo.zip (634M)
sha1: 955f4ff07348f5d9d70a40f37d9db5c65e3acaa7

[Bug 39355] The Guild 2 Demo installer crashes when starting copying files

https://bugs.winehq.org/show_bug.cgi?id=39355

--- Comment #1 from Alex Henrie  ---
There have been a lot of improvements to user32 over the past month, and I can
no longer reproduce this bug. Can you retest with Wine 1.7.54 or later?

[Bug 39355] The Guild 2 Demo installer crashes when starting copying files

https://bugs.winehq.org/show_bug.cgi?id=39355

--- Comment #2 from Béla Gyebrószki  ---
(In reply to Alex Henrie from comment #1)
> There have been a lot of improvements to user32 over the past month, and I
> can no longer reproduce this bug. Can you retest with Wine 1.7.54 or later?

The installer still crashes for me in wine-1.7.54-59-g8f44307 (with the same
backtrace as before).

Fedora 23 32-bit
gcc version 5.1.1 20150618 (Red Hat 5.1.1-4) (GCC)

[Bug 39355] The Guild 2 Demo installer crashes when starting copying files

https://bugs.winehq.org/show_bug.cgi?id=39355

--- Comment #3 from Béla Gyebrószki  ---
The crash still occurs in Wine 1.9.8.

[Bug 39355] The Guild 2 Demo installer crashes when starting copying files

https://bugs.winehq.org/show_bug.cgi?id=39355

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |erich.e.hoover@wine-staging
                   |                            |.com, [e-mail],
                   |                            |[e-mail]
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |STAGED
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/kernel32-GetSh
                   |                            |ortPathName

[Bug 39355] The Guild 2 Demo installer crashes when starting copying files

https://bugs.winehq.org/show_bug.cgi?id=39355

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|f920dfd6984ca9227900d0f0406 |
                   |afb3ceb892cc5               |
          Component|user32                      |kernel32
           Keywords|regression                  |

--- Comment #4 from Dmitry Timoshkov  ---
This is not really a regression.

[Bug 39355] The Guild 2 Demo installer crashes when starting copying files

https://bugs.winehq.org/show_bug.cgi?id=39355

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Staged patchset|https://github.com/wine-com |https://github.com/wine-sta
                   |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast
                   |ster/patches/kernel32-GetSh |er/patches/kernel32-GetShor
                   |ortPathName                 |tPathName

[Bug 39355] The Guild 2 Demo installer crashes when starting copying files

https://bugs.winehq.org/show_bug.cgi?id=39355

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STAGED                      |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |3a78ec672a4c1635d848e0253f4
                   |                            |5127cb8690f26

--- Comment #5 from Dmitry Timoshkov  ---
Committed as 3a78ec672a4c1635d848e0253f45127cb8690f26.

[Bug 39355] The Guild 2 Demo installer crashes when starting copying files

https://bugs.winehq.org/show_bug.cgi?id=39355

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 3.19.