[Bug 39485] New: Logically dead code in elf_hash_symtab (Coverity #731748)

https://bugs.winehq.org/show_bug.cgi?id=39485

Bug ID: 39485
           Summary: Logically dead code in elf_hash_symtab (Coverity
                    #731748)
           Product: Wine
           Version: 1.7.53
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: dbghelp
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

assignment: Assigning: symname = strp + symp->st_name.

notnull: At condition symname, the value of symname cannot be NULL.
dead_error_condition: The condition symname must be true.

CID 731748 (#1 of 1): Logically dead code (DEADCODE)dead_error_line:
Execution cannot reach this statement: compiland = NULL;

[Bug 39485] Logically dead code in elf_hash_symtab (Coverity #731748)

https://bugs.winehq.org/show_bug.cgi?id=39485

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 39485] Logically dead code in elf_hash_symtab (Coverity #731748)

https://bugs.winehq.org/show_bug.cgi?id=39485

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Alex Henrie  ---
Upon closer look, I think this is actually a false positive. Coverity thinks
that if (symname) can never be null because it thinks that strp can never be
null and symname = strp + symp->st_name, but strp can be null if there is
something wrong with the image map. See:
https://source.winehq.org/git/wine.git/blob/65d699eb5f7fc151197f3dc9f36499ee...
https://source.winehq.org/git/wine.git/blob/65d699eb5f7fc151197f3dc9f36499ee...

Sorry for trusting Coverity a bit too much here...

[Bug 39485] Logically dead code in elf_hash_symtab (Coverity #731748)

https://bugs.winehq.org/show_bug.cgi?id=39485

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Austin English  ---
Closing.