[Bug 21287] New: [1.1.36 regression] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Summary: [1.1.36 regression] Miranda appearance is broken in
                    many ways
           Product: Wine
           Version: 1.1.36
          Platform: x86
               URL: http://miranda.googlecode.com/files/miranda-im-v0.8.12
                    -unicode.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=25613)
 --> (http://bugs.winehq.org/attachment.cgi?id=25613)
Miranda's broken appearance in Wine 1.1.36

outlined areas on the screenshot are painted incorrectly.

Groups should not have smilyes on them.

Miranda logo on the top has a kind of inking which shouldn't be there.

[Bug 21287] [1.1.36 regression] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression,
                   |                            |source

[Bug 21287] [1.1.36 regression] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #1 from Artem S. Tashkinov   2010-01-08 16:03:05 ---
Created an attachment (id=25614)
 --> (http://bugs.winehq.org/attachment.cgi?id=25614)
Proper appearance as for Wine 1.1.35

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[1.1.36 regression] Miranda |Miranda appearance is
                   |appearance is broken in     |broken in many ways
                   |many ways                   |

--- Comment #2 from Nikolay Sivov   2010-01-08 16:03:56 ---
(In reply to comment #0)
> outlined areas on the screenshot are painted incorrectly.

You mean black background I suppose?
> Groups should not have smilyes on them.

What?
> appearance is broken in many ways

What ways along with black backgrounds?

If it's a regression perform a regression test.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #3 from Artem S. Tashkinov   2010-01-08 16:06:17 ---
Nikolay, I've attached a screenshot from 1.1.35 with a proper Miranda
appearance. The difference is very easy to spot.

I'm sorry, I currently have no possibility of carrying out regression tests.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Wylda   2010-01-08 17:24:25 ---

1. Confirming, please consider UNCONFIRMED->NEW

2. I did a regression test between 1.1.35 and 1.1.36:

95ac10e526f9949802c8b76a969a942a9a4c2727 is first bad commit
commit 95ac10e526f9949802c8b76a969a942a9a4c2727
Author: Joel Holdsworth 
Date:   Wed Dec 30 20:00:08 2009 +0000

user32: Fixed icons to select correct image in high colour depth.

:040000 040000 47638ca8d78615b841c81f40465d054d07c44656
900ff753acf9fbf634e474a96be5459afbe25575 M      dlls

3. No other bug report suffers from this commit.

4. Revert of this patch on top of wine-1.1.36 makes that problem go away.

5. Adding author of this patch to CC.

--private keyword: bisected

PS: If i look to http://www.miranda-im.org/screenshots/ especially
"screenshot2" it looks like in 1.1.35. But the "screenshot 11" has a weak
shadow around +/- which is probably in 1.1.36 shown as totally black.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|-unknown                    |user32
     Ever Confirmed|0                           |1

--- Comment #5 from Nikolay Sivov   2010-01-08 17:34:57 ---
(In reply to comment #4)

Thanks for test, Wylda.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |trivial

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #6 from Artem S. Tashkinov   2010-01-09 04:00:16 ---
(In reply to comment #4)
> PS: If i look to http://www.miranda-im.org/screenshots/ especially
> "screenshot2" it looks like in 1.1.35. But the "screenshot 11" has a weak
> shadow around +/- which is probably in 1.1.36 shown as totally black.

Indeed! I've never seen that faint shadow in Miranda - probably this glitch has
to have its own bug report.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #7 from Joel Holdsworth   2010-01-09 08:24:27 ---
I'm not sure what to suggest. My patch fixes a real problem with wine, whereby
it would fail to choose the correct colour depth of icon to load on 16, 24, and
32-bit screens. The image that wine would load would effectively be a random
guess. This is why Miranda may have worked before.

It might be worth doing some investigation around the problem. I suspect that
Miranda's icons are formatted in a way that causes wine to misinterpret their
colour depth, but because colour depth choosing was broken 1.1.35, Wine just
happened to get lucky with some icons. Notice that even in 1.1.35 not all the
icons work. Now that this problem is fixed, it exposes the underlying problem
consistently across the board.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #8 from Nikolay Sivov   2010-01-09 08:32:16 ---
(In reply to comment #7)
> I'm not sure what to suggest. My patch fixes a real problem with wine, whereby
> it would fail to choose the correct colour depth of icon to load on 16, 24, and
> 32-bit screens. The image that wine would load would effectively be a random
> guess. This is why Miranda may have worked before.

Yes, this happens sometimes.
> It might be worth doing some investigation around the problem. I suspect that
> Miranda's icons are formatted in a way that causes wine to misinterpret their
> colour depth, but because colour depth choosing was broken 1.1.35, Wine just
> happened to get lucky with some icons. Notice that even in 1.1.35 not all the
> icons work. Now that this problem is fixed, it exposes the underlying problem
> consistently across the board.

Well, Miranda is OSS so the way it uses icons and icons themselves are
available.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Sergiy Zuban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Sergiy Zuban   2010-01-12 15:15:51 ---
I also confirm the issue.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #10 from Artem S. Tashkinov   2010-01-12 15:48:32 ---
(In reply to comment #7)
> I'm not sure what to suggest. My patch fixes a real problem with wine, whereby
> it would fail to choose the correct colour depth of icon to load on 16, 24, and
> 32-bit screens. The image that wine would load would effectively be a random
> guess. This is why Miranda may have worked before.

Joel, the appearance of the icon on the top of Miranda doesn't really bother me
even though it looks broken, what really bothers me is that your patch does
break how group headings are rendered.

On my screenshot of wine 1.1.36 you can see that group headings have "smily"s
_under_ them (right beneath graphical plus and minus signs/icons) - I cannot
believe icons color depth has anything to do with this issue.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #11 from Artem S. Tashkinov   2010-01-22 14:58:21 ---
Wine 1.1.37 has been released with no changes concerning this bug.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #12 from Artem S. Tashkinov   2010-01-29 14:33:51 ---
Created an attachment (id=25946)
 --> (http://bugs.winehq.org/attachment.cgi?id=25946)
Miranda's chat window

I've found yet another glitch of the same nature.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #13 from Wylda   2010-02-28 05:03:10 ---

Still not fixed in wine-1.1.39-163-g583f0f0.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

--- Comment #14 from Artem S. Tashkinov   2010-05-09 03:39:59 ---
I'd be glad if this bug was nominated for 1.2 release.

After all sources of Miranda are available, so this bug seems to be really
important.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Artem S. Tashkinov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from Artem S. Tashkinov   2010-05-19 01:45:13 ---
Wine 1.1.45/1.2 is going to be a beautiful release! :)

Fixed in git, Miranda now looks wonderful.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard   2010-05-21 14:39:35 ---
Closing bugs fixed in 1.2-rc1.

[Bug 21287] Miranda appearance is broken in many ways

http://bugs.winehq.org/show_bug.cgi?id=21287

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |95ac10e526f9949802c8b76a969
                   |                            |a942a9a4c2727