[Bug 40253] New: regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

Bug ID: 40253
           Summary: regression: Can't remove fonts: is a directory
                    (--with-wine64, shared wow64)
           Product: Wine
           Version: 1.9.5
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: build-env
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

I've updated my git tree with 1.9.5 and now I have this error while
compiling 32bit Wine with the --with-wine64 option (in a shared wow64
setup):

---begin make output---
...
rm -f fonts && ln -s ../1.9.5_wow_64/fonts fonts
rm: impossible de supprimer « fonts »: est un dossier
make: *** [fonts] Erreur 1
...
---end make output---

It says fonts is a directory and can't be removed.

I do out-of-tree builds. The 32bit directory doesn't exists when I run
configure. After running configure, the 32bit build tree is there and
contains a fonts directory with a single Makefile in it.

I had no such error with Wine 1.9.4 and I don't have it when compiling
stand-alone 32bit Wine or the 64bit shared wow part.

I did a regression test and found this commit to be the culprit:

---begin git bisect output---
dcc16c7cac1cbf93096b072fe2f7b32ad08d1fa5 is the first bad commit
commit dcc16c7cac1cbf93096b072fe2f7b32ad08d1fa5
Author: Alexandre Julliard <julliard at winehq.org>
Date:   Mon Feb 29 15:06:42 2016 +0900

makefiles: Don't generate global rules in disabled directories.

Signed-off-by: Alexandre Julliard <julliard at winehq.org>
...
---end git bisect output---

[Bug 40253] regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail],
                   |                            |[e-mail]
    Regression SHA1|                            |dcc16c7cac1cbf93096b072fe2f
                   |                            |7b32ad08d1fa5

[Bug 40253] Build regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|regression: Can't remove    |Build regression: Can't
                   |fonts: is a directory       |remove fonts: is a
                   |(--with-wine64, shared      |directory (--with-wine64,
                   |wow64)                      |shared wow64)
           Severity|normal                      |major

--- Comment #1 from Sebastian Lackner  ---
Bumping importance to major since this potentially affects a lot of users and
distributions. Based on the bisected commit I would guess that a patch like
this one is sufficient to workaround the issue: http://ix.io/pdw

[Bug 40253] Build regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

--- Comment #2 from Olivier F. R. Dierick  ---
(In reply to Sebastian Lackner from comment #1)
> Bumping importance to major since this potentially affects a lot of users
> and distributions. Based on the bisected commit I would guess that a patch
> like this one is sufficient to workaround the issue: http://ix.io/pdw

Yes, it does workaround the issue.

Thanks.

[Bug 40253] Build regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

Adam Bolte  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Adam Bolte  ---
Confirming I too hit the bug, and the linked patch worked.

[Bug 40253] Build regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

--- Comment #4 from Sebastian Lackner  ---
(In reply to Adam Bolte from comment #3)
> Confirming I too hit the bug, and the linked patch worked.

This bug should be fixed with
http://source.winehq.org/git/wine.git/commit/c6d6dcee47eb97fd75e389434d4136d...,
could you please retest?

[Bug 40253] Build regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

Felix Yan  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Felix Yan  ---
Backporting c6d6dcee47eb97fd75e389434d4136de2f31414c fixes this for me. Thanks!

[Bug 40253] Build regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

--- Comment #6 from Adam Bolte  ---
Confirming with current HEAD (which includes
c6d6dcee47eb97fd75e389434d4136de2f31414c), I can now build fine once again.

[Bug 40253] Build regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c6d6dcee47eb97fd75e389434d4
                   |                            |136de2f31414c
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Nikolay Sivov  ---
Marking fixed.

[Bug 40253] Build regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

--- Comment #8 from Olivier F. R. Dierick  ---
Fixed for me too.

[Bug 40253] Build regression: Can't remove fonts: is a directory (--with-wine64, shared wow64)

https://bugs.winehq.org/show_bug.cgi?id=40253

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.6.