https://bugs.winehq.org/show_bug.cgi?id=56613
Bug ID: 56613 Summary: Errors when building wine-9.4 with -Werror on Fedora 40 Product: Wine Version: 9.4 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: patrick+winehq.org@laimbock.com Distribution: ---
Created attachment 76370 --> https://bugs.winehq.org/attachment.cgi?id=76370 Errors when building wine-9.4 with -Werror on Fedora 40
Building wine-9.4 (no staging) with -Werror on Fedora 40 with gcc (GCC) 14.0.1 20240411 (Red Hat 14.0.1-0) results in some failures. See attachment. Please let me know if you need more information. Thanks.
https://bugs.winehq.org/show_bug.cgi?id=56613
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Errors when building |Warnings when building with |wine-9.4 with -Werror on |-Werror on Fedora 40 |Fedora 40 | Keywords| |download, source Distribution|--- |Fedora
--- Comment #1 from Ken Sharp imwellcushtymelike@gmail.com --- I just compiled current git (Wine ~9.7) on Fedora 40 and it compiled without issue, with and without -Werror.
Building wine-9.4 with -Werror results in some failures
That's what you're asking for with -Werror.
cc1: all warnings being treated as errors
What, specifically is the issue? What flags are you passing to configure?
https://bugs.winehq.org/show_bug.cgi?id=56613
Zeb Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
--- Comment #2 from Zeb Figura z.figura12@gmail.com --- (In reply to Ken Sharp from comment #1)
I just compiled current git (Wine ~9.7) on Fedora 40 and it compiled without issue, with and without -Werror.
Building wine-9.4 with -Werror results in some failures
That's what you're asking for with -Werror.
No, we do generally want Wine to build without warnings; this is a valid bug.
It's just Wine-Staging for which it's not worth our time.
https://bugs.winehq.org/show_bug.cgi?id=56613
--- Comment #3 from Ken Sharp imwellcushtymelike@gmail.com --- So... Wine doesn't fail to compile, it's just warnings? Is that what we're looking at here?
Patrick's logs show a compilation failure. If it's caused by -Werror then I can't recreate this in Wine git on Fedora 40 so it must be related to some other FLAGS/options/magic/evil.
Patrick, does this occur in the Wine git, and if so, what is the exact command you are running?
Other than that I can hunt for warnings ;)
https://bugs.winehq.org/show_bug.cgi?id=56613
Patrick patrick+winehq.org@laimbock.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|9.4 |9.8
--- Comment #4 from Patrick patrick+winehq.org@laimbock.com --- Hi Ken. It does not occur in wine git. But I just rebuild wine-9.8 (just wine, no staging) on Fedora 40 with -Werror and have attached the build failure. Since you are using Fedora: I took the distro provided wine-9.5-1.src.rpm, changed the version to 9.8 and added -Werror to CFLAGS. Then I rebuild the wine-9.8-1.src.rpm in mock with make -j1. I'll also attach the wine-9.8 spec file.
The CFLAGS used during the build are:
LATEST CFLAGS=-fexceptions -g -grecord-gcc-switches -pipe -Wall -Wno-complain-wrong-lang -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -O2 -Werror
Please let me know if you need more information. Thanks!
https://bugs.winehq.org/show_bug.cgi?id=56613
--- Comment #5 from Patrick patrick+winehq.org@laimbock.com --- Created attachment 76426 --> https://bugs.winehq.org/attachment.cgi?id=76426 Error when building Wine-9.8 with -Werror on Fedora 40
Error when building Wine-9.8 with -Werror on Fedora 40
https://bugs.winehq.org/show_bug.cgi?id=56613
--- Comment #6 from Patrick patrick+winehq.org@laimbock.com --- Created attachment 76427 --> https://bugs.winehq.org/attachment.cgi?id=76427 wine.spec file for building Wine-9.8 with -Werror in mock
https://bugs.winehq.org/show_bug.cgi?id=56613
Ken Sharp imwellcushtymelike@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|9.8 |9.4
--- Comment #7 from Ken Sharp imwellcushtymelike@gmail.com --- Don't change the reported Wine version.
https://bugs.winehq.org/show_bug.cgi?id=56613
--- Comment #8 from Patrick patrick+winehq.org@laimbock.com --- (In reply to Patrick from comment #4)
Hi Ken. It does not occur in wine git.
To clarify, I did not build wine git, just wine 9.8.