[Bug 9986] New: serial/COM code misinterprets XON/XOFF direction

http://bugs.winehq.org/show_bug.cgi?id=9986

Summary: serial/COM code misinterprets XON/XOFF direction
           Product: Wine
           Version: 0.9.46.
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wine-misc
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The code in dlls/ntdll/serial.c interprets SERIAL_AUTO_RECEIVE to IXON
and SERIAL_AUTO_TRANSMIT to IXOFF (and visa versa). This is wrong way around,
SERIAL_AUTO_RECEIVE corresponds to IXOFF and SERIAL_AUTO_TRANSMIT to IXON.

[Bug 9986] serial/COM code misinterprets XON/XOFF direction

http://bugs.winehq.org/show_bug.cgi?id=9986

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Louis Lenders   2007-10-11 07:06:39 ---
Hi , could you attach your patch that fixes this, for review by developers?
Thanks

[Bug 9986] serial/COM code misinterprets XON/XOFF direction

http://bugs.winehq.org/show_bug.cgi?id=9986

--- Comment #2 from Tom Brus   2007-10-11 07:09:58 ---
Some further explanation:

Many Linux sources mention:
    IXON        = Enable start/stop output control.
    IXOFF       = Enable start/stop input control.

I found some doc at http://www.ekf.de/c/ccom/drv_i960/ekf960mle.pdf that
explains:
    SERIAL_AUTO_TRANSMIT: Use the XON/XOFF protocol based flow control for
output.
    SERIAL_AUTO_RECEIVE : Use the XON/XOFF protocol based flow control for
input.
> From this we can conclude that:

IXON  <=> SERIAL_AUTO_TRANSMIT
    IXOFF <=> SERIAL_AUTO_RECEIVE

Unfortunately I do not have example code at hand.

I will attach a patch shortly.

[Bug 9986] serial/COM code misinterprets XON/XOFF direction

http://bugs.winehq.org/show_bug.cgi?id=9986

--- Comment #3 from Tom Brus   2007-10-11 07:26:39 ---
Created an attachment (id=8508)
 --> (http://bugs.winehq.org/attachment.cgi?id=8508)
patch for serial.c

The patch to fix this bug.

[Bug 9986] serial/COM code misinterprets XON/XOFF direction

http://bugs.winehq.org/show_bug.cgi?id=9986

--- Comment #4 from Juan Lang   2007-10-11 11:43:59 ---
Patch and explanation look good, please forward to wine-patches

[Bug 9986] serial/COM code misinterprets XON/XOFF direction

http://bugs.winehq.org/show_bug.cgi?id=9986

--- Comment #5 from Dmitry Timoshkov   2007-10-29 09:26:04 ---
The patch has been committed. Please retest and close the bug if appropriate.

[Bug 9986] serial/COM code misinterprets XON/XOFF direction

http://bugs.winehq.org/show_bug.cgi?id=9986

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Juan Lang   2007-10-29 18:22:44 ---
Marking fixed, please close if you verify it.

[Bug 9986] serial/COM code misinterprets XON/XOFF direction

http://bugs.winehq.org/show_bug.cgi?id=9986

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
          Component|-unknown                    |ntdll

--- Comment #7 from Vitaliy Margolen   2008-01-06 23:22:04 ---
Closing