https://bugs.winehq.org/show_bug.cgi?id=56487
Bug ID: 56487 Summary: wshom tests timeout on Wine Product: Wine Version: 8.16 Hardware: x86-64 OS: Linux Status: NEW Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: bunglehead@gmail.com Distribution: ---
This is a regression:
85d029e3b01f6dd35a86cc07796af982d66e4a03 is the first bad commit commit 85d029e3b01f6dd35a86cc07796af982d66e4a03 Author: Yuxuan Shui yshui@codeweavers.com Date: Mon Mar 18 18:32:00 2024 +0000
shell32: Rely solely on SHELL_FindExecutable for ShellExecute.
This does two things:
1. ShellExecute no longer searches in the directory where the current executable is in. 2. We always CreateProcess with a fully qualified path, so we CreateProcess won't do its own path resolution.
Serendipitously this also fixes some existing todos in tests.
dlls/shell32/shlexec.c | 24 +----------------------- dlls/shell32/tests/shlexec.c | 8 +++----- 2 files changed, 4 insertions(+), 28 deletions(-)
It's not clear if it's a bug in shell32 or in wshom. Best way would be to run our wshom.ocx on Windows to confirm.
https://bugs.winehq.org/show_bug.cgi?id=56487
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
https://bugs.winehq.org/show_bug.cgi?id=56487
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |85d029e3b01f6dd35a86cc07796 | |af982d66e4a03
https://bugs.winehq.org/show_bug.cgi?id=56487
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com --- Tests timeout because of the unexpected "File not found" message box.
https://bugs.winehq.org/show_bug.cgi?id=56487
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Component|-unknown |wshom.ocx Fixed by SHA1| |47e4907c0d3b53e482cea79df90 | |ec72eafad8c37 Resolution|--- |FIXED
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com --- Marking fixed, https://source.winehq.org/git/wine.git/commit/47e4907c0d3b53e482cea79df90ec7....
https://bugs.winehq.org/show_bug.cgi?id=56487
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #3 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.6.