[Bug 15378] New: mshtml/tests: dom.c fails in gcc 3.3/CFLAGS="-Werror"

http://bugs.winehq.org/show_bug.cgi?id=15378

Summary: mshtml/tests: dom.c fails in gcc 3.3/CFLAGS="-Werror"
           Product: Wine
           Version: 1.1.5
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

austin@austin-desktop:~/wine-git/dlls/mshtml/tests$ make
ccache /usr/bin/gcc-3.3 -c -I. -I. -I../../../include -I../../../include  
-D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wwrite-strings
-Wpointer-arith  -Werror  -o dom.o dom.c
dom.c:90: warning: duplicate `const'
dom.c:95: warning: duplicate `const'
dom.c:105: warning: duplicate `const'
dom.c:117: warning: duplicate `const'
dom.c:128: warning: duplicate `const'
dom.c:140: warning: duplicate `const'
dom.c:151: warning: duplicate `const'
dom.c:162: warning: duplicate `const'
dom.c:173: warning: duplicate `const'
dom.c:184: warning: duplicate `const'
dom.c:195: warning: duplicate `const'
dom.c:202: warning: duplicate `const'
dom.c:208: warning: duplicate `const'
dom.c:216: warning: duplicate `const'
dom.c:227: warning: duplicate `const'
dom.c:238: warning: duplicate `const'
make: *** [dom.o] Error 1

[Bug 15378] mshtml/tests: dom.c fails in gcc 3.3/CFLAGS="-Werror"

http://bugs.winehq.org/show_bug.cgi?id=15378

--- Comment #1 from Dmitry Timoshkov   2008-09-23 02:06:53 ---
Does it help if you replace

static REFIID const none_iids[] = {

by

static const IID * const none_iids[] = {

?

[Bug 15378] mshtml/tests: dom.c fails in gcc 3.3/CFLAGS="-Werror"

http://bugs.winehq.org/show_bug.cgi?id=15378

--- Comment #2 from Austin English   2008-09-23 03:27:57 ---
(In reply to comment #1)
> Does it help if you replace
>
> static REFIID const none_iids[] = {
>
> by
>
> static const IID * const none_iids[] = {
>
> ?

Yep, compiles fine.

[Bug 15378] mshtml/tests: dom.c fails in gcc 3.3/CFLAGS="-Werror"

http://bugs.winehq.org/show_bug.cgi?id=15378

--- Comment #3 from Austin English   2008-09-23 03:29:38 ---
Created an attachment (id=16231)
 --> (http://bugs.winehq.org/attachment.cgi?id=16231)
patch for dom.c

git diff for dom.c with those changes made.

I wanted to test it on a few other gcc versions before submitting, but putting
it up here so it doesn't slip through cracks.

[Bug 15378] mshtml/tests: dom.c fails in gcc 3.3/CFLAGS="-Werror"

http://bugs.winehq.org/show_bug.cgi?id=15378

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Austin English   2008-09-23 10:24:39 ---
Patch committed.

[Bug 15378] mshtml/tests: dom.c fails in gcc 3.3/CFLAGS="-Werror"

http://bugs.winehq.org/show_bug.cgi?id=15378

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard   2008-10-10 10:11:06 ---
Closing bugs fixed in 1.1.6.