[Bug 12523] New: Diablo 2 - Window Management Issues

http://bugs.winehq.org/show_bug.cgi?id=12523

Summary: Diablo 2 - Window Management Issues
           Product: Wine
           Version: unspecified
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

While playing Diablo 2 when you want to pick multiple items from floor you have
to press ALT and they are displayed in a list on your screen and by selecting
one item from that list you pick it.

I was playing Diablo 2 with Wine version Wine 0.9.58 and it worked perfectly
but after switching to Wine 0.9.59 this problem occurred. I assume it has to be
related by changes in Wine 0.9.59 regarding window management.

System: Ubuntu 7.10 x64, wine from winehq (unmodified), Nvidia Driver.

[Bug 12523] Diablo 2 - Window Management Issues

http://bugs.winehq.org/show_bug.cgi?id=12523

--- Comment #1 from Dmitry Timoshkov   2008-04-12 01:51:17 ---
This one may be fixed in git, can you please re-test?

[Bug 12523] Diablo 2 - Window Management Issues

http://bugs.winehq.org/show_bug.cgi?id=12523

--- Comment #2 from Andrez   2008-04-12 04:27:02 ---
Created an attachment (id=12087)
 --> (http://bugs.winehq.org/attachment.cgi?id=12087)
Diablo 2 Plick-up bug wine 59

Screenshot on how to reproduce the bug in Diablo 2

[Bug 12523] Diablo 2 - Window Management Issues

http://bugs.winehq.org/show_bug.cgi?id=12523

--- Comment #3 from Andrez   2008-04-12 04:28:56 ---
(In reply to comment #1)
> This one may be fixed in git, can you please re-test?

apr 12, 2008: taken sources with gid and compiled wine (using default
configuration /usr/local/bin wine)..

the problem still appears. when clicking on an object from that list the
character moves toward the pointed area on screen instead of selecting the item
from list

i have attached a screen shot on how this might be reproducible

[Bug 12523] Diablo 2 - Window Management Issues

http://bugs.winehq.org/show_bug.cgi?id=12523

--- Comment #4 from Dmitry Timoshkov   2008-04-12 05:55:46 ---
Please perform the regression testing then:

http://wiki.winehq.org/RegressionTesting

[Bug 12523] Diablo 2 - Window Management Issues

http://bugs.winehq.org/show_bug.cgi?id=12523

--- Comment #5 from Andrez   2008-04-12 10:00:46 ---
(In reply to comment #4)
> Please perform the regression testing then:
>
> http://wiki.winehq.org/RegressionTesting

The problem is in the following patch:

andrez@andrez-desktop:~/wine-git$ git bisect good 
Bisecting: 0 revisions left to test after this
[9faf7e358630cb8e8d63e4a534a9b5b9a56b7e00] winex11drv: Distinguish left and
right keys for shift, ctrl and alt.

[Bug 12523] Diablo 2 - Window Management Issues

http://bugs.winehq.org/show_bug.cgi?id=12523

--- Comment #6 from Lei Zhang   2008-04-12 18:20:27 ---
You need to do one more round of testing, until git tells your "the first bad
commit is..."

[Bug 12523] Diablo 2 - Window Management Issues

http://bugs.winehq.org/show_bug.cgi?id=12523

Andrez  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winex11.drv
            Version|unspecified                 |0.9.59.

--- Comment #7 from Andrez   2008-04-13 00:46:19 ---
(In reply to comment #6)
> You need to do one more round of testing, until git tells your "the first bad
> commit is..."

andrez@andrez-desktop:~/wine-git$ git bisect bad 
9faf7e358630cb8e8d63e4a534a9b5b9a56b7e00 is first bad commit
commit 9faf7e358630cb8e8d63e4a534a9b5b9a56b7e00
Author: Vitaliy Margolen 
Date:   Tue Apr 1 23:13:45 2008 -0600

winex11drv: Distinguish left and right keys for shift, ctrl and alt.

:040000 040000 f3dfc96ffb6c506e2341239f2bf7d99e92adb5b0
d4bed7c01fecedae19e1f2fc2237a713c0596ee0 M      dlls
:040000 040000 26d2bf88d3a1cf5abab4c8f5f65a9431e1cdf69e
e917d748e76aff81c65de137b39177838f58a86e M      server

[Bug 12523] Diablo 2 - winex11.drv bug

http://bugs.winehq.org/show_bug.cgi?id=12523

Andrez  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Diablo 2 - Window Management|Diablo 2 - winex11.drv bug
                   |Issues                      |

--- Comment #8 from Andrez   2008-04-13 12:35:25 ---
Just to be more specific:
When I press Left ALT and Right ALT it works. The right menu appears. But the
problem appear while ALT remain pressed and i click left mouse button. Instead
of selecting the item from the menu it doesn't do anything. It takes only click
action.

I assume the change might be in keyboard.c. please help.

[Bug 12523] Diablo 2 - winex11.drv bug

http://bugs.winehq.org/show_bug.cgi?id=12523

--- Comment #9 from James Hawkins   2008-04-13 12:40:44 ---
Please fix the summary so that it describes the problem, not where the problem
might be.

[Bug 12523] Diablo 2 - winex11.drv bug

http://bugs.winehq.org/show_bug.cgi?id=12523

--- Comment #10 from Andrez   2008-04-13 14:11:55 ---
Problem summary:

1. Normal behavior:

- press Left or Right ALT a menu appears on screen with items which can be
selected
- if you stop pressing ALT the above menu disappears
- if while Left or Right ALT is pressed and left click on an item from that
menu it should disappear from the menu and should be in character inventory and
the character should stay

2. Problematic behavior:
- press Left or Right ALT a menu appears on screen with items which can be
selected [!normal behavior!]
- if you stop pressing ALT the above menu disappears [!normal behavior!]
- if while Left or Right ALT is pressed and left click on an item from that
menu is pressed the character goes in that direction without selecting the item
from the menu as the menu was not on the screen at all and the whole menu
disappears. It normally should have stayed on screen. (bug)

[Bug 12523] Diablo 2 - winex11.drv bug

http://bugs.winehq.org/show_bug.cgi?id=12523

--- Comment #11 from Andrez   2008-04-13 14:19:33 ---
For example if i keep either Left or Right SHIFT pressed and Left Click the
character behaves normally.

My opinion is that this specific combination between Left Click while ALT is
pressed doesn't work.

[Bug 12523] Diablo 2 - problem with keyboard menu

http://bugs.winehq.org/show_bug.cgi?id=12523

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Diablo 2 - winex11.drv bug  |Diablo 2 - problem with
                   |                            |keyboard menu

[Bug 12523] Diablo 2 - problem with keyboard menu

http://bugs.winehq.org/show_bug.cgi?id=12523

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #12 from Lei Zhang   2008-04-14 15:05:03 ---
dupe of bug 12343?

[Bug 12523] Diablo 2 - problem with keyboard menu

http://bugs.winehq.org/show_bug.cgi?id=12523

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #13 from Austin English   2008-04-14 16:31:06 ---
Sounds like it.

*** This bug has been marked as a duplicate of bug 12343 ***

[Bug 12523] Diablo 2 - problem with keyboard menu

http://bugs.winehq.org/show_bug.cgi?id=12523

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Austin English   2008-04-14 16:31:11 ---
Closing.