[Bug 32381] New: QQ2012 crashes at start

http://bugs.winehq.org/show_bug.cgi?id=32381

Bug #: 32381
           Summary: QQ2012 crashes at start
           Product: Wine
           Version: 1.5.18
          Platform: x86
               URL: http://dl_dir.qq.com/qqfile/qq/QQ2012/QQ2012.exe
        OS/Version: Linux
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 42729
  --> http://bugs.winehq.org/attachment.cgi?id=42729
Log: QQ2012 crashes

$ sha1sum QQ2012.exe 
2fd79ccf1d60769a6e68987c9518294bec255517  QQ2012.exe

1. install QQ2012 with Wine

2. set atl80 to native, workaround Bug 30512

3. start QQ.exe with winedbg, or it will not print backtrace but create a
minidump instead

$ cd ~/.wine/drive_c/Program\ Files/Tencent/QQ/Bin
$ winedbg QQ.exe

4. type any account and password, then click the login button (登录)

QQ.exe crashes after clicking:
Backtrace:
=>0 0x7e7ce676 OleDraw+0x15(pUnk=(nil), dwAspect=0x10, hdcDraw=0x10153,
rect=0x22ee58c) [/home/fracting/wine-git/dlls/ole32/ole2.c:2549] in ole32
(0x022ee554)
  1 0x6512e77c in loginpanel (+0x2e77b) (0x022ee570)
...
0x7e7ce676 OleDraw+0x15 [/home/fracting/wine-git/dlls/ole32/ole2.c:2549] in
ole32: movl 0x0(%eax),%eax
2549      hres = IUnknown_QueryInterface(pUnk,

[Bug 32381] QQ2012 crashes at start

http://bugs.winehq.org/show_bug.cgi?id=32381

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Bruno Jesus  2012-12-06 10:31:48 CST ---
Reminds me of bug 32292 although there the invalid parameters were different,
in this one the first parameter is NULL, maybe that is the problem.

[Bug 32381] QQ2012 crashes at start

http://bugs.winehq.org/show_bug.cgi?id=32381

--- Comment #2 from Nikolay Sivov  2012-12-06 11:20:49 CST ---
Yeah, I'll take a look.

[Bug 32381] QQ2012 crashes at start

http://bugs.winehq.org/show_bug.cgi?id=32381

--- Comment #3 from Qian Hong  2012-12-06 11:27:40 CST ---
Created attachment 42731
  --> http://bugs.winehq.org/attachment.cgi?id=42731
Patch: Fixed OleDraw with Null pUnk

Hi Bruno, thanks, I think you are right :)
https://testbot.winehq.org/JobDetails.pl?Key=23256

Nikolay, could you review this patch? Or if there is anything wrong please just
take it :)

[Bug 32381] QQ2012 crashes at start

http://bugs.winehq.org/show_bug.cgi?id=32381

--- Comment #4 from Qian Hong  2012-12-06 11:51:47 CST ---
Patch sent, thanks Bruno and Nikolay :)
http://source.winehq.org/patches/data/92604

[Bug 32381] QQ2012 crashes at start

http://bugs.winehq.org/show_bug.cgi?id=32381

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |ole

[Bug 32381] QQ2012 crashes at start

http://bugs.winehq.org/show_bug.cgi?id=32381

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ole                         |ole32

[Bug 32381] QQ2012 crashes at start

http://bugs.winehq.org/show_bug.cgi?id=32381

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9b90ea557b12b7a0a25ce945ac4
                   |                            |374f1aa702ae5
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Bruno Jesus  2012-12-06 17:16:52 CST ---
Commited:
http://source.winehq.org/git/wine.git/?a=commit;h=9b90ea557b12b7a0a25ce945ac...

[Bug 32381] QQ2012 crashes at start

http://bugs.winehq.org/show_bug.cgi?id=32381

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  2012-12-07 13:36:26 CST ---
Closing bugs fixed in 1.5.19.