http://bugs.winehq.com/show_bug.cgi?id=1152
------- Additional Comments From winebug@flonet.net 2003-28-06 09:48 ------- Bug comments restored from Gmane.org:
Current version management code doesn't seem to work properly in a lot of cases. GetFileVersionInfoA is said to only work with Win32 file images on MSDN, yet our code happily parses any kind of file information, both Win16 and Win32, and, worse yet, it even sometimes returns the *wrong* kind of format (as can be witnessed by running UltimateZip 2.7 - well, trying to run, that is...).
I'm about to submit some test cases for version information code, and I'm also thinking of deliberately changing the code quite a lot in order to fix the worst issues, but of course this will then break a lot of other things, thus forcing someone to properly redesign this code (I currently really don't have time to do that).
IMHO having a properly working version information code is pretty important, and the code seems to also be quite broken, thus leading to problems with lots of programs, so I assigned it a severity of "major". (another example of version problems seems to be the thread "Ulead Mediastudio 2.5 on Wine" on c.e.m.w.)
What needs to be done IMHO is to first design very thorough (all-encompassing) test cases on Windows to be used on Wine (check Win16/Win32 file images, check for proper ASCII/Unicode handling, ..., so in total we might end up having some maybe 6 up to 10 different test cases), and then one would have to correct the current code (and still keeping in mind that we need to handle our own version information in our .so libraries properly !).