[Bug 44654] New: EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

Bug ID: 44654
           Summary: EDIdEv Framework EDI Runtime installer fails due to
                    'sfc.SfcGetNextProtectedFile' not setting last-error
                    code
           Product: Wine
           Version: 3.3
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello folks,

I've tried to find a bug report for
https://github.com/wine-staging/wine-staging/tree/master/patches/sfc-SfcGetN...

It seems after introducing the 'sfc.dll.SfcGetNextProtectedFile' stub in bug
38097 no one except Michael checked *all* the apps the bug was reported
against.

* FreshDiagnose -> fine with the current stub
* EDIdEv Framework EDI Runtime -> still fails with the stub

He created a patch but no continuation/follow-up ticket.
Creating a ticket here to add traceability to this Wine-Staging patch.

--- snip ---
$ WINEDEBUG=+seh,+relay,+msi,+sfc wine ./Edidev_FREDI_Runtime.exe >>log.txt
2>&1
...
0009:Call KERNEL32.LoadLibraryA(0048b138 "SFC.DLL") ret=004603f8
0009:Ret  KERNEL32.LoadLibraryA() retval=7d1b0000 ret=004603f8
...
0009:Call KERNEL32.GetProcAddress(7d1b0000,0048ee6c "SfcGetNextProtectedFile")
ret=00460595
0009:Ret  KERNEL32.GetProcAddress() retval=7d047b88 ret=00460595
0009:Call sfc_os.SfcGetNextProtectedFile(00000000,0033ec28) ret=004605d6
0009:fixme:sfc:SfcGetNextProtectedFile (nil) 0x33ec28
0009:Ret  sfc_os.SfcGetNextProtectedFile() retval=00000000 ret=004605d6
0009:Call KERNEL32.GetLastError() ret=004606dc
0009:Ret  KERNEL32.GetLastError() retval=00000000 ret=004606dc 
...
0009:Call user32.MessageBoxA(00000000,00168b98 "Failed to get next protected
file..  SfcGetNextProtectedFile API Failure. Description: Success.; ,
GetLastError() = 0",0048ef34 "Installer Failure",00000000) ret=00461cf9 
...
0009:Ret  user32.MessageBoxA() retval=00000001 ret=00461cf9 
...
0009:Call KERNEL32.ExitProcess(00000000) ret=7dffe1c9
--- snip ---

$ sha1sum Edidev_FREDI_Runtime.zip 
96207a7601c730895ff7293c039e9fda1fff00d2  Edidev_FREDI_Runtime.zip

$ du -sh Edidev_FREDI_Runtime.zip 
25M    Edidev_FREDI_Runtime.zip

$ wine --version
wine-3.3

Regards

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Staged patchset|                            |https://github.com/wine-sta
                   |                            |ging/wine-staging/tree/mast
                   |                            |er/patches/sfc-SfcGetNextPr
                   |                            |otectedFile
                URL|                            |http://www.edidev.com/p___L
                   |                            |________/Edidev_FREDI_Runti
                   |                            |me.zip
             Status|NEW                         |STAGED
           Keywords|                            |download, Installer

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Zebediah Figura  ---
Hi, just stopping by to say thanks for the help :-)

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STAGED                      |RESOLVED
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |7dd74d5b5084f352b46c0e52e42
                   |                            |1bf28f34cade1

--- Comment #2 from Alistair Leslie-Hughes  ---
Fixed by
https://source.winehq.org/git/wine.git/?a=commit;h=7dd74d5b5084f352b46c0e52e...

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

--- Comment #3 from Anastasius Focht  ---
Hello folks,

confirming fixed, installer shows UI and runs to completion.
Thanks Michael and Alistair

--- snip ---
$ WINEDEBUG=+seh,+relay,+msi,+sfc wine ./Edidev_FREDI_Runtime.exe >>log.txt
2>&1

...
004a:Call KERNEL32.LoadLibraryA(0048b138 "SFC.DLL") ret=0043e461
...
004a:Ret  KERNEL32.LoadLibraryA() retval=7d1d0000 ret=0043e461
...
004a:Ret  KERNEL32.GetProcAddress() retval=7d05ab88 ret=00460423
004a:Call KERNEL32.GetProcAddress(7d1d0000,0048ee6c "SfcGetNextProtectedFile")
ret=00460595
004a:Ret  KERNEL32.GetProcAddress() retval=7d05ab88 ret=00460595
004a:Call sfc_os.SfcGetNextProtectedFile(00000000,0033ec28) ret=004605d6
004a:fixme:sfc:SfcGetNextProtectedFile (nil) 0x33ec28
004a:Ret  sfc_os.SfcGetNextProtectedFile() retval=00000000 ret=004605d6
004a:Call KERNEL32.GetLastError() ret=004606dc
004a:Ret  KERNEL32.GetLastError() retval=00000012 ret=004606dc 
...
<same sequence repeats in different installer stages>
--- snip ---

$ wine --version
wine-3.3-34-gacd2f1e59b

Regards

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

--- Comment #4 from Alistair Leslie-Hughes  ---
(In reply to Anastasius Focht from comment #3)
> Hello folks,
>
> confirming fixed, installer shows UI and runs to completion.
> Thanks Michael and Alistair

Thanks Zebediah for this one.

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 3.4.

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.0.x

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.0.x                       |---

--- Comment #6 from Michael Stefaniuc  ---
Removing the 3.0.x milestone from bugs included in 3.0.1.

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to ' sfc.SfcGetNextProtectedFile' not setting last-error code

https://bugs.winehq.org/show_bug.cgi?id=44654

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |srclient

[Bug 44654] EDIdEv Framework EDI Runtime installer fails due to 'sfc.SfcGetNextProtectedFile' not setting last-error code

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=44654

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.edidev.com/p___L |https://web.archive.org/web
                   |________/Edidev_FREDI_Runti |/20171019061353/http://www.
                   |me.zip                      |edidev.com/p___L________/Ed
                   |                            |idev_FREDI_Professional.zip

--- Comment #7 from Anastasius Focht  ---
Hello folks,

adding stable download via Internet Archive for documentation:

https://web.archive.org/web/20171019061353/http://www.edidev.com/p___L______...

There were no archive.org snapshots of Framework EDI Runtime Files:

https://web.archive.org/web/20180329215500/http://www.edidev.com/eval_Runtim...

I found Framework EDI Professional evaluation 32-bit installer can be used as
well for reproduce.

$ sha1sum Edidev_FREDI_Professional.zip 
3666ff22a6d3e922c63f684809852d9993d077f1  Edidev_FREDI_Professional.zip

$ du -sh Edidev_FREDI_Professional.zip 
49M    Edidev_FREDI_Professional.zip

Regards