[Bug 52465] New: Toolbar: Wrong TB_GETBUTTON message processing, returns (-1) instead of separator width in TBBUTTON structure

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52465

Bug ID: 52465
           Summary: Toolbar:  Wrong TB_GETBUTTON message processing,
                    returns (-1) instead of separator width in TBBUTTON
                    structure
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---
> From MSDN documents about TB_GETBUTTON : If the button is a separator, that is,

if fsStyle is set to BTNS_SEP, iBitmap determines the width of the separator,
in pixels.

So, this code needs to change:
/wine/dlls/comctl32/toolbar.c:3373

static LRESULT
TOOLBAR_GetButton (const TOOLBAR_INFO *infoPtr, INT nIndex, TBBUTTON *lpTbb)
{
---------------------------<cut>------------------------
    /*From MSDN documents: If the button is a separator, that is, if fsStyle is
set to BTNS_SEP, 
    iBitmap determines the width of the separator, in pixels*/
    lpTbb->iBitmap   = (btnPtr->fsStyle & BTNS_SEP) ? SEPARATOR_WIDTH :
btnPtr->iBitmap;

---------------------------<cut>------------------------

[Bug 52465] Toolbar: Wrong TB_GETBUTTON message processing, returns (-1) instead of separator width in TBBUTTON structure

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52465

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Nikolay Sivov  ---
Thanks, I just sent some tests for this [1]. We'll need more things tested
before fixing this, but submitted test already shows that we'll need to
maintain correct value, rather than conditionally return a constant.

[1] https://www.winehq.org/pipermail/wine-devel/2022-January/205810.html

[Bug 52465] Toolbar: Wrong TB_GETBUTTON message processing, returns (-1) instead of separator width in TBBUTTON structure

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52465

--- Comment #2 from YAL  ---
I've tested Win10/11 with different monitor/font scaling - it always return
constant 8.

[Bug 52465] Toolbar: Wrong TB_GETBUTTON message processing, returns (-1) instead of separator width in TBBUTTON structure

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52465

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |7.0
                 CC|                            |[e-mail]