[Bug 39900] New: Flash Player 20 control panel applet does not load

https://bugs.winehq.org/show_bug.cgi?id=39900

Bug ID: 39900
           Summary: Flash Player 20 control panel applet does not load
           Product: Wine
           Version: 1.8
          Hardware: x86
               URL: https://get.adobe.com/flashplayer/otherversions/
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Ubuntu

Xubuntu 14.04 x86_64
Adobe Flash (NPAPI) 20.0.0.235
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:43.0) Gecko/20100101 Firefox/43.0

Steps to reproduce:
1. Install Adobe Flash Player 20 NPAPI
(https://get.adobe.com/flashplayer/otherversions/)
2. Attempt to load the control panel applet via "wine control" or directly
with:
wine rundll32 shell32.dll,Control_RunDLL
…/drive_c/windows/system32/FlashPlayerCPLApp.cpl
3. Result: Exits silently.  No Wine messages.

There is a "Settings Manager" (…/drive_c/windows/system32/FlashPlayerApp.exe)
that works normally.  I don't know how its feature set compares to the applet.

[Bug 39900] Flash Player 20 control panel applet does not load

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=39900

Guillermo Reisch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Guillermo Reisch  ---
https://archive.org/download/Adobe_Flash_Player_Complete_Collection/fpdownlo...

confirmed in wine 3.0 up to wine 8.0
(wine > 8.0 change default version to windows 10)
(Installer needs Compatibility set to Windows 7 to install CPL)
confirmed in wine-8.1 up to wine-9.14 up to git:wine/master

[Bug 39900] Flash Player 20 control panel applet does not load

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=39900

--- Comment #2 from Guillermo Reisch  ---
Breakpoint 1, Control_DoLaunch (panel=0x86fb34, hWnd=0x30054, wszCmd=0x242b62)
at dlls/shell32/control.c:821
821             if (!applet->proc(applet->hWnd, CPL_STARTWPARMSW, sp,
(LPARAM)extraPmts))
Wine-gdb> next
824             Control_UnloadApplet(applet);

FlashPlayerCPLApp.cpl respond to signal CPL_STARTWPARMSW returning TRUE (if it
handle the signal correctly), but not show a dialog box at all!
if line 821 is comment and force the signal CPL_STARTWPARMSW (line 822) then
dialog box is show and work. FlashPlayerCPLApp is not handle CPL_STARTWPARMSW
correctly...

[Bug 39900] Flash Player 20 control panel applet does not load

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=39900

--- Comment #3 from Guillermo Reisch  ---
Created attachment 76940
  --> https://bugs.winehq.org/attachment.cgi?id=76940
debug using gdb (w64devkit) in Windows 7 32bits

Tested in windows 7

FlashPlayerCPLApp!CPlApplet (0, CPL_INIT,0,0) = 1
FlashPlayerCPLApp!CPlApplet (0, CPL_GETCOUNT,0,0) = 1
FlashPlayerCPLApp!CPlApplet (0, CPL_INQUIRE,0,&cplinfo) = 0 
 (return value is ignored)
FlashPlayerCPLApp!CPlApplet (0, CPL_NEWINQUIRE,&newcplinfo) = 0
 (return value ignored) [¿why send CPL_INQUIRE if return valid cplinfo?]...
FlashPlayerCPLApp!CPlApplet (0, CPL_DBLCLK,0,0) = 0
FlashPlayerCPLApp!CPlApplet (0, CPL_STOP,0,0) = 0
FlashPlayerCPLApp!CPlApplet (0, CPL_EXIT,0,0) = 0

In Windows 7 (also tested in XP) it never send signal CPL_STARTWPARMS
using rundll32 shell32.dll Control_RunDLL FlashPlayerCPLApp.cpl

[Bug 39900] Flash Player 20 control panel applet does not load

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=39900

--- Comment #4 from Guillermo Reisch  ---
Created attachment 76941
  --> https://bugs.winehq.org/attachment.cgi?id=76941
Patch

shlctrl: Control_DoLaunch send CPL_DBLCLK signal by default if no extraPmts