[Bug 34856] New: No sound in Mass Effect 2/3 [bisected, regression in programs/explorer/desktop.c]

http://bugs.winehq.org/show_bug.cgi?id=34856

Bug #: 34856
           Summary: No sound in Mass Effect 2/3 [bisected, regression in
                    programs/explorer/desktop.c]
           Product: Wine
           Version: unspecified
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: 1f9c541b58360559f2f8a6db9d876ada4dcc2b48

Created attachment 46455
  --> http://bugs.winehq.org/attachment.cgi?id=46455
Minimum patch reversal for current head

Mass Effect 2/3 has no sound in menus/game since commit
[1f9c541b58360559f2f8a6db9d876ada4dcc2b48] explorer: Set the final size of the
desktop window only after it has been created.

Intro videos play correctly, including sound, but as soon as the main menu is
loaded, no sound plays. I bisected it to the specified commit, and further down
to the specific statement. I attach a minimum patch that fixes this in current
git, although it may break something else.

[Bug 34856] No sound in Mass Effect 2/3 [bisected, regression in programs/explorer/desktop.c]

http://bugs.winehq.org/show_bug.cgi?id=34856

--- Comment #1 from Alexandre Julliard  2013-11-04 12:08:12 CST ---
Maybe it wants the window to be activated?  You could try to remove the
SWP_NOACTIVATE to see if it makes a difference.

[Bug 34856] No sound in Mass Effect 2/3 [bisected, regression in programs/explorer/desktop.c]

http://bugs.winehq.org/show_bug.cgi?id=34856

--- Comment #2 from [e-mail] 2013-11-04 12:17:03 CST ---
It seems like you are right, removing SWP_NOACTIVATE makes it work.

[Bug 34856] No sound in Mass Effect 2/3 [bisected, regression in programs/explorer/desktop.c]

http://bugs.winehq.org/show_bug.cgi?id=34856

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |1483bfa21d4945a1f62d957edaf
                   |                            |bd179cd518865
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Alexandre Julliard  2013-11-04 14:22:20 CST ---
Should be fixed by 1483bfa21d4945a1f62d957edafbd179cd518865 then.

[Bug 34856] No sound in Mass Effect 2/3 [bisected, regression in programs/explorer/desktop.c]

http://bugs.winehq.org/show_bug.cgi?id=34856

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |
            Version|unspecified                 |1.7.5

[Bug 34856] No sound in Mass Effect 2/3

http://bugs.winehq.org/show_bug.cgi?id=34856

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|No sound in Mass Effect 2/3 |No sound in Mass Effect 2/3
                   |[bisected, regression in    |
                   |programs/explorer/desktop.c |
                   |]                           |

[Bug 34856] No sound in Mass Effect 2/3

http://bugs.winehq.org/show_bug.cgi?id=34856

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2013-11-08 12:33:27 CST ---
Closing bugs fixed in 1.7.6.