[Bug 41726] New: Wine-Staging: patch failed: dlls/wined3d/texture.c: 1439 against latest Wine-git

https://bugs.winehq.org/show_bug.cgi?id=41726

Bug ID: 41726
           Summary: Wine-Staging: patch failed:
                    dlls/wined3d/texture.c:1439 against latest Wine-git
           Product: Wine-staging
           Version: 1.9.23
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail]
      Distribution: ---

Created attachment 56161
  --> https://bugs.winehq.org/attachment.cgi?id=56161
Terminal output from when I attempt to patch a clean Wine-Devel tree with
Wine-1.9.23-Staging patches

Hi folks,

I have a clean (no custom patches or anything of the sort) Wine-Devel source
tree and I have a clean Wine-Staging source tree and I am attempting to apply
the Wine-Staging patches to Wine-1.9.23-56-gbfa0e4b and I am getting an error
with one of the patches:

error: patch failed: dlls/wined3d/texture.c:1439
error: dlls/wined3d/texture.c: patch does not apply
ERROR: Failed to apply patch, aborting!

Steps to reproduce:

1. Clone the Wine-devel source into one directory. 
2. Clone the Wine-Staging source into another
3. Run the ./patchinstall.sh DESTDIR="path/to/wine" --all command
4. See one patch fail

I have attached the full terminal output as well in case it helps.

[Bug 41726] Wine-Staging: patch failed: dlls/wined3d/texture.c: 1439 against latest Wine-git (1.9.23-56-gbfa0e4b)

https://bugs.winehq.org/show_bug.cgi?id=41726

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Wine-Staging: patch failed: |Wine-Staging: patch failed:
                   |dlls/wined3d/texture.c:1439 |dlls/wined3d/texture.c:1439
                   |against latest Wine-git     |against latest Wine-git
                   |                            |(1.9.23-56-gbfa0e4b)

[Bug 41726] Wine-Staging: patch failed: dlls/wined3d/texture.c: 1439 against latest Wine-git (1.9.23-56-gbfa0e4b)

https://bugs.winehq.org/show_bug.cgi?id=41726

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Dmitry Timoshkov  ---
Staging patches should be applied against the specific Wine commit,
see 'patchinstall.sh --upsteam-commit' for an exact snapshot id.

[Bug 41726] Wine-Staging: patch failed: dlls/wined3d/texture.c: 1439 against latest Wine-git (1.9.23-56-gbfa0e4b)

https://bugs.winehq.org/show_bug.cgi?id=41726

--- Comment #2 from [e-mail] ---
(In reply to Dmitry Timoshkov from comment #1)
> Staging patches should be applied against the specific Wine commit,
> see 'patchinstall.sh --upsteam-commit' for an exact snapshot id.

Thanks for the info and sorry for wasting your time :)

[Bug 41726] Wine-Staging: patch failed: dlls/wined3d/texture.c: 1439 against latest Wine-git (1.9.23-56-gbfa0e4b)

https://bugs.winehq.org/show_bug.cgi?id=41726

--- Comment #3 from Erich E. Hoover  ---
(In reply to fjfrackiewicz from comment #2)
> ...
> Thanks for the info and sorry for wasting your time :)

It's not a waste of time, clearly we need to communicate the process better. 
Is there something we can do to make this more obvious?  Would a wiki page
help?

[Bug 41726] Wine-Staging: patch failed: dlls/wined3d/texture.c: 1439 against latest Wine-git (1.9.23-56-gbfa0e4b)

https://bugs.winehq.org/show_bug.cgi?id=41726

--- Comment #4 from [e-mail] ---
(In reply to Erich E. Hoover from comment #3)
> (In reply to fjfrackiewicz from comment #2)
> > ...
> > Thanks for the info and sorry for wasting your time :)
>
> It's not a waste of time, clearly we need to communicate the process better.
> Is there something we can do to make this more obvious?  Would a wiki page
> help?

Hi Erich,

Well, this page https://github.com/wine-compholio/wine-staging/wiki/Packaging 
seems to cover it rather well and it mentions the exact instructions that I, as
a user, should have read since I've only compiled Wine-Staging maybe once in my
life so far...

So I think in this case it was definitely PEBKAC :)

[Bug 41726] Wine-Staging: patch failed: dlls/wined3d/texture.c: 1439 against latest Wine-git (1.9.23-56-gbfa0e4b)

https://bugs.winehq.org/show_bug.cgi?id=41726

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Bruno Jesus  ---
Closing invalid bugs.