[Bug 16622] New: possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

Summary: possible bashism in config.guess
           Product: Wine
           Version: 1.1.11
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Keywords: download, source
          Severity: trivial
          Priority: P2
         Component: tools
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

austin@ubuntu:~/wine-git/tools$ checkbashisms config.guess
possible bashism in config.guess line 94 (trap with signal numbers):
trap 'exit 1' 1 2 15

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

Luke Benstead  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #1 from Luke Benstead   2009-08-16 03:41:21 ---
Still present in 1.1.27.

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

Wolfram Sang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Wolfram Sang   2010-03-20 01:50:25 ---
Still present in 1.1.41.

Yet, I think this should be dealt upstream and then flow back to wine. So, I
just sent a patch to the config.guess-maintainer. For the curious, I will
attach a suitable patch for current wine.

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

--- Comment #3 from Wolfram Sang   2010-03-20 01:56:54 ---
Created an attachment (id=26902)
 --> (http://bugs.winehq.org/attachment.cgi?id=26902)
Replace signal numbers with names in config.guess

Also sent upstream, should flow back to wine.

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

--- Comment #4 from Austin English   2010-03-20 01:57:33 ---
Patches should be submitted to [e-mail].

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

--- Comment #5 from Wolfram Sang   2010-03-20 02:46:42 ---
? Is this a generated message or why do you prefer to carry local changes to
config.guess? :)

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

--- Comment #6 from Austin English   2010-03-20 02:53:31 ---
Sure, it should be fixed upstream as well, but it may take a while for that to
trickle down to wine...

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

--- Comment #7 from Wolfram Sang   2010-03-20 03:07:17 ---
Okay then, what about this proposal?

I wait a few days for a response from upstream (maybe they have a reason to use
numbers? Not that I could see one, though). Then, this bug could be closed as
INVALID. If upstream picks it up, then I'll send a patch, also stating this is
fixed in the newest upstream-version, too (config doesn't have versions, just
timestamps), so AJ can decide what he will pick up. If upstream does not react,
I will just send the patch.

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

--- Comment #8 from Austin English   2010-03-20 03:07:45 ---
Sure.

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

--- Comment #9 from Austin English   2010-04-05 11:35:22 ---
Fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=f00b8b9c135ffc6ec7c62b....

Thanks Wolfram!

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Austin English   2010-04-05 11:35:31 ---
.

[Bug 16622] possible bashism in config.guess

http://bugs.winehq.org/show_bug.cgi?id=16622

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard   2010-04-16 13:02:30 ---
Closing bugs fixed in 1.1.43.