[Bug 19393] New: Word & Excel 2007 scrollbar background/arrow buttons are wrong color, changes based on size
http://bugs.winehq.org/show_bug.cgi?id=19393
Summary: Word & Excel 2007 scrollbar background/arrow buttons are wrong color, changes based on size Product: Wine Version: 1.1.26 Platform: PC OS/Version: Linux Status: UNCONFIRMED Severity: trivial Priority: P2 Component: winex11.drv AssignedTo: wine-bugs@winehq.org ReportedBy: dimesio@earthlink.net CC: thunderbird2k@gmail.com
Created an attachment (id=22475) --> (http://bugs.winehq.org/attachment.cgi?id=22475) screenshot showing incorrect colors
In Word & Excel 2007, the color of the scrollbar background is not only wrong, but it changes based on the size of the window. I'm attaching a screenshot showing both colors; enlarging the window changes the green area to black.
A regression test identified the following patch:
004eabfbd398192c0de92bafe1b31381a07d7a9c is first bad commit commit 004eabfbd398192c0de92bafe1b31381a07d7a9c Author: Roderick Colenbrander thunderbird2k@gmail.com Date: Thu Jul 9 21:20:12 2009 +0200
winex11: Add an XRender based GetSrcAreaStretch.
:040000 040000 8eb47f001f4635ac2ebb31c451b0bd5b46b11c78 ee9832dcd1175a51ccaca17f92674b3507a1be1d M dlls
http://bugs.winehq.org/show_bug.cgi?id=19393
Rosanne DiMesio dimesio@earthlink.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression
http://bugs.winehq.org/show_bug.cgi?id=19393
Jaime Rave jaimerave@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jaimerave@gmail.com
--- Comment #1 from Jaime Rave jaimerave@gmail.com 2009-07-20 12:07:40 --- The same problem is happening here. Ubuntu 9.04 and Wine 1.1.26.
http://bugs.winehq.org/show_bug.cgi?id=19393
--- Comment #2 from Roderick Colenbrander thunderbird2k@gmail.com 2009-07-20 12:53:09 --- Hi Rosanne,
Thanks for reporting this bug. What display drivers are you using?
Roderick
http://bugs.winehq.org/show_bug.cgi?id=19393
--- Comment #3 from Jaime Rave jaimerave@gmail.com 2009-07-20 13:53:47 --- Hi, I'm have an Intel X4500HD, and using the driver 2.7.99.902+git20090718.
http://bugs.winehq.org/show_bug.cgi?id=19393
--- Comment #4 from Rosanne DiMesio dimesio@earthlink.net 2009-07-20 15:01:57 --- (In reply to comment #2)
Hi Rosanne,
Thanks for reporting this bug. What display drivers are you using?
Roderick
nVidia 7600 GS, 185.18.14 driver
http://bugs.winehq.org/show_bug.cgi?id=19393
--- Comment #5 from Roderick Colenbrander thunderbird2k@gmail.com 2009-07-21 16:35:47 --- Could you both try the following fix? There is a rounding error in coordinates and this (depending on the driver) should reduce or even completely eliminate the issue. The issue is that a bitmap with a height of 1 is stretched interpolated incorrectly (actually the bitmap is a part of a large bitmap and that is what causes the issues). Bitmaps with a width or height larger than 1 don't have issues. In case of 1x a special optimization can be added which can fix the issue completely.
diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c index 6d290ba..9b6fc2b 100644 --- a/dlls/winex11.drv/xrender.c +++ b/dlls/winex11.drv/xrender.c @@ -1724,9 +1724,9 @@ static void set_xrender_transformation(Picture src_pict, float xscale, float ysc { #ifdef HAVE_XRENDERSETPICTURETRANSFORM XTransform xform = {{ - { XDoubleToFixed(xscale), XDoubleToFixed(0), XDoubleToFixed(xoffset) }, - { XDoubleToFixed(0), XDoubleToFixed(yscale), XDoubleToFixed(yoffset) }, - { XDoubleToFixed(0), XDoubleToFixed(0), XDoubleToFixed(1) } + { XDoubleToFixed(256*xscale), XDoubleToFixed(0), XDoubleToFixed(xoffset) }, + { XDoubleToFixed(0), XDoubleToFixed(256*yscale), XDoubleToFixed(yoffset) }, + { XDoubleToFixed(0), XDoubleToFixed(0), XDoubleToFixed(256) } }};
pXRenderSetPictureTransform(gdi_display, src_pict, &xform);
http://bugs.winehq.org/show_bug.cgi?id=19393
--- Comment #6 from Rosanne DiMesio dimesio@earthlink.net 2009-07-21 23:01:44 --- When I try to apply the patch I get the message:
patch: **** malformed patch at line 6: float xscale, float ysc
http://bugs.winehq.org/show_bug.cgi?id=19393
--- Comment #7 from Rosanne DiMesio dimesio@earthlink.net 2009-07-22 07:35:26 --- I managed to figure out that deleting the extra carriage returns created by copying and pasting bugzilla's line-wrapped text would fix the problem with applying the patch.
The patch mostly gets rid of the green at smaller window sizes (there's still a thin line of green at the top of the up arrow), but the black remains.
http://bugs.winehq.org/show_bug.cgi?id=19393
--- Comment #8 from Roderick Colenbrander thunderbird2k@gmail.com 2009-07-22 10:49:11 --- I have submitted a patch to wine-patches which will fix this issue.
http://bugs.winehq.org/show_bug.cgi?id=19393
Roderick Colenbrander thunderbird2k@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED
--- Comment #9 from Roderick Colenbrander thunderbird2k@gmail.com 2009-07-24 08:53:34 --- The fix is in git.
http://bugs.winehq.org/show_bug.cgi?id=19393
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #10 from Alexandre Julliard julliard@winehq.org 2009-08-07 12:58:04 --- Closing bugs fixed in 1.1.27.
-
wine-bugs＠winehq.org