[Bug 28696] New: ieframe/tests/intshcut.c: Uninitialised value in test_ReadAndWriteProperties
http://bugs.winehq.org/show_bug.cgi?id=28696
Bug #: 28696 Summary: ieframe/tests/intshcut.c: Uninitialised value in test_ReadAndWriteProperties Product: Wine Version: 1.3.30 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: ieframe AssignedTo: wine-bugs@winehq.org ReportedBy: dank@kegel.com Classification: Unclassified
While doing 'make intshcut.ok', valgrind complained:
Syscall param write(buf) points to uninitialised byte(s) at __write_nocancel (syscall-template.S:82) by WriteFile (file.c:547) by FileLockBytesImpl_WriteAt (filelockbytes.c:286) by StorageImpl_WriteAt (storage32.c:347) by StorageImpl_WriteBigBlock (storage32.c:4026) by BlockChainStream_Flush (storage32.c:6041) by StorageImpl_Flush (storage32.c:2984) by StgStreamImpl_Write (storage32.h:261) by PropertyStorage_WritePropertyToStream (stg_prop.c:1689) by PropertyStorage_PropertiesWriter (stg_prop.c:1786) by dictionary_enumerate (dictionary.c:189) by IPropertyStorage_fnCommit (stg_prop.c:1800) by test_ReadAndWriteProperties (intshcut.c:239) by func_intshcut (intshcut.c:403) by run_test (test.h:556) by main (test.h:624) Address 0x7f08afde is 150 bytes inside a block of size 8,260 alloc'd at RtlAllocateHeap (heap.c:254) by BlockChainStream_Construct (storage32.c:6009) by StorageImpl_Construct (storage32.c:2924) by Storage_Construct (storage32.c:5168) by create_storagefile (storage32.c:7384) by StgCreateStorageEx (storage32.c:7479) by create_shortcut (intshcut.c:820) by InternetShortcut_Create (intshcut.c:855) by CoCreateInstance (compobj.c:2641) by test_ReadAndWriteProperties (intshcut.c:204) by func_intshcut (intshcut.c:403) by run_test (test.h:556) by main (test.h:624) Uninitialised value was created by a stack allocation at test_ReadAndWriteProperties (intshcut.c:183)
https://bugs.winehq.org/show_bug.cgi?id=28696
--- Comment #1 from Austin English austinenglish@gmail.com --- ==7622== Syscall param write(buf) points to uninitialised byte(s) ==7622== at 0x4EA82603: __write_nocancel (in /usr/lib/libpthread-2.18.so) ==7622== by 0x7BC46BB8: NtWriteFile (file.c:1073) ==7622== by 0x7B83E0AA: WriteFile (file.c:563) ==7622== by 0x4D50C51: FileLockBytesImpl_WriteAt (filelockbytes.c:286) ==7622== by 0x4D83A32: StorageImpl_WriteAt (objidl.h:5753) ==7622== by 0x4D8A09C: StorageImpl_WriteBigBlock (storage32.c:4094) ==7622== by 0x4D8E0DE: BlockChainStream_Flush (storage32.c:6092) ==7622== by 0x4D88666: StorageImpl_Flush (storage32.c:3053) ==7622== by 0x4D81D7E: StorageBaseImpl_Flush (storage32.h:263) ==7622== by 0x4D824E0: StgStreamImpl_Write (stg_stream.c:253) ==7622== by 0x4D7F6F3: PropertyStorage_WritePropertyToStream (objidl.h:4384) ==7622== by 0x4D7FDFC: PropertyStorage_PropertiesWriter (stg_prop.c:1861) ==7622== by 0x4D4E90D: dictionary_enumerate (dictionary.c:189) ==7622== by 0x4D7FE8A: PropertyStorage_WritePropertiesToStream (stg_prop.c:1875) ==7622== by 0x4D802D1: PropertyStorage_WriteToStream (stg_prop.c:1990) ==7622== by 0x4D7C3D4: IPropertyStorage_fnCommit (stg_prop.c:826) ==7622== by 0x4956D19: test_ReadAndWriteProperties (propidl.h:540) ==7622== by 0x4957936: test_InternetShortcut (intshcut.c:390) ==7622== by 0x4957966: func_intshcut (intshcut.c:398) ==7622== by 0x496A50C: run_test (test.h:584) ==7622== Address 0x4758e76 is 150 bytes inside a block of size 8,260 alloc'd ==7622== at 0x7BC4C735: notify_alloc (heap.c:255) ==7622== by 0x7BC50F79: RtlAllocateHeap (heap.c:1716) ==7622== by 0x4D8DF70: BlockChainStream_Construct (storage32.c:6060) ==7622== by 0x4D88406: StorageImpl_Construct (storage32.c:2993) ==7622== by 0x4D8CA10: Storage_Construct (storage32.c:5232) ==7622== by 0x4D8FDE5: create_storagefile (storage32.c:7437) ==7622== by 0x4D901DF: StgCreateStorageEx (storage32.c:7531) ==7622== by 0x6321F46: create_shortcut (intshcut.c:820) ==7622== by 0x6322148: InternetShortcut_Create (intshcut.c:855) ==7622== by 0x4D3AE0E: CoCreateInstance (unknwn.h:226) ==7622== by 0x49569A4: test_ReadAndWriteProperties (intshcut.c:191) ==7622== by 0x4957936: test_InternetShortcut (intshcut.c:390) ==7622== by 0x4957966: func_intshcut (intshcut.c:398) ==7622== by 0x496A50C: run_test (test.h:584) ==7622== by 0x496A8FB: main (test.h:654) ==7622== Uninitialised value was created by a stack allocation ==7622== at 0x49567A2: test_ReadAndWriteProperties (intshcut.c:170) ==7622==
still present.
https://bugs.winehq.org/show_bug.cgi?id=28696
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download, source, testcase, | |valgrind
https://bugs.winehq.org/show_bug.cgi?id=28696
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|wine-bugs@winehq.org |bunglehead@gmail.com
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com --- I think I found where garbage value comes from, will send a fix once it's ready.
https://bugs.winehq.org/show_bug.cgi?id=28696
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com --- Sent - https://www.winehq.org/pipermail/wine-patches/2016-January/145569.html
https://bugs.winehq.org/show_bug.cgi?id=28696
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |41ff20886a2165005645f4da49b | |c7ef9e3650716 Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|bunglehead@gmail.com |wine-bugs@winehq.org
--- Comment #4 from Nikolay Sivov bunglehead@gmail.com --- Should be fixed now with 41ff20886a2165005645f4da49bc7ef9e3650716.
https://bugs.winehq.org/show_bug.cgi?id=28696
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.9.1.
-
wine-bugs＠winehq.org