[Bug 19355] New: Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Summary: Link to the previous version announcement in section
                    "changes since <previous version>"
           Product: WineHQ.org
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: www-unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hello.

In section “Changes since <version>” of Wine announcements I think it'd be nice
to have a hyperlink to the announcement on the given version (i.e.
http://www.winehq.org/announce/<version>), so that we can browse changes that
occurred previously.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Vince C.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Vince C.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|PC                          |All
         OS/Version|Linux                       |All

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID

--- Comment #1 from Ken Sharp   2009-07-23 09:13:35 ---
It's already there under "What's new".  Try clicking it.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
           Platform|All                         |Other
         OS/Version|All                         |other

--- Comment #2 from Ken Sharp   2009-07-23 09:14:19 ---
Invalid.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #3 from Vince C.   2009-07-23 11:58:39 ---
No, it's not there already. I think you misread me. So here's an example. In
announcement of Wine-1.1.26 there is:

«...
----------------------------------------------------------------

Bugs fixed in 1.1.26:

<list of bugs fixed>

----------------------------------------------------------------

Changes since 1.1.25:

<list of changes>

...»
____

My point is that

«Changes since 1.1.25»

should be

«Changes since <a href="http://www.winehq.org/announce/1.1.25">1.1.25</a>»

as we're currently reading the 1.1.26 release. A link to the announcement on
the previous release is what I'm talking about.

And in http://www.winehq.org/announce/1.1.25:

«...
----------------------------------------------------------------

Bugs fixed in 1.1.25:

<list of bugs fixed>

----------------------------------------------------------------

Changes since <a href="http://www.winehq.org/announce/1.1.24">1.1.24</a>:

<list of changes>

...»

And so on.

The «What's new» only points to the *current* release. I'm suggesting to link
to the announcement on the *previous* release from the announcement on the
*current* release.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #4 from Vince C.   2009-07-23 12:46:57 ---
Please reopen this bug.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #5 from Vitaliy Margolen   2009-07-23 23:03:00 ---
http://source.winehq.org/git/wine.git/?a=tags
http://www.winehq.org/announce/1.1.25
http://www.winehq.org/announce/1.1.24
and so on work too if you really need that information.

The text on announce page comes from git commit. Adding extra html code in
there is counter productive.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|INVALID                     |

--- Comment #6 from Alexandre Julliard   2009-07-24 02:57:45 ---
It comes from git but it's already formatted by php to add some urls, so
there's no reason we can't add one more.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #7 from Vince C.   2009-07-24 11:09:39 ---
Thanks Alexandre. I don't mind coping without if it's really too much work,
though. Since every announce has been formatted the same way for a long time
and I often want to jump to the previous versions from the announcement, I
thought I had to be not the only one person who'd find such a link useful.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #8 from André H.   2009-07-28 13:16:37 ---
confirming. in most serious projects you have such comfort

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #9 from Vince C.   2009-10-26 05:53:51 ---
Looks like this bug is not on top of the list. If I may be of any help, I'd be
glad to add the required code...

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #10 from André H.   2009-10-26 06:37:04 ---
yes, be free to send a patch.

i am just afraid that the announce-writers have a template for it locally, so
if you fix it in git the next announce maybe buggy again. i already had that
with some html-stuff.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #11 from Vince C.   2009-10-26 06:44:48 ---
(In reply to comment #10)
> yes, be free to send a patch.
>
> i am just afraid that the announce-writers have a template for it locally, so
> if you fix it in git the next announce maybe buggy again. i already had that
> with some html-stuff.

If I know how to make such a change I just don't know where to look for I don't
know where I can get a copy of these templates. (They surely copy theirs from
some repository, I hope?)

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #12 from André H.   2009-10-26 06:48:53 ---
the website source can be found here:
http://source.winehq.org/git/website.git

maybe you also want to read such things:
http://wiki.winehq.org/GitWine
http://wiki.winehq.org/SubmittingPatches

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #13 from Vince C.   2009-10-26 08:17:45 ---
Thanks André. Will try and find my way through the templates :-) . "See" you
soon I hope...

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #14 from Vince C.   2009-10-26 09:44:50 ---
Created an attachment (id=24364)
 --> (http://bugs.winehq.org/attachment.cgi?id=24364)
Add link to the previous version in the "Changes since" section

As promised, here's the patch. Affected file is:

/include/plugins/announce.php

Cheers.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #15 from André H.   2009-10-26 09:56:27 ---
-        }           
+        }
isnt so nice, fix that and try sending it to [e-mail]

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #16 from Vince C.   2009-10-26 09:58:07 ---
(In reply to comment #15)
> -
>    }           
> -
>    }
>
> isnt so nice, fix that and try sending it to [e-mail]

Erm... Sorry my editor (Geany) also eliminated trailing spaces... Should I
re-include them? I also work with tabs instead of spaces; change that as well?

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #17 from André H.   2009-10-26 10:05:42 ---
i just sent you my geany settings per mail.
you should not touch code just to edit the some whitespace-stuff.
also you should use four spaces as tab, but in some cases you can use the
intendation of the file.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #18 from Vince C.   2009-10-26 10:14:57 ---
Thanks. It's been faster to edit the patch by hand with nano (it's small enough
after all). I'll mail the patch right afterwards.

Thanks for your help.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Vince C.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24364|0                           |1
        is obsolete|                            |

--- Comment #19 from Vince C.   2009-10-26 10:25:05 ---
Created an attachment (id=24372)
 --> (http://bugs.winehq.org/attachment.cgi?id=24372)
Add link to the previous version in the "Changes since" section

. Spaces/tabs fixed
. Extra white space removal... removed

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #20 from Vince C.   2009-10-26 10:36:47 ---
Just a comment though:

- I've subscribed to wine bugzilla (wait for the activation mail, activate,
wait, wait, wait, wait, code, send patch) to the *sole* purpose of filing this
bug, create and submit this patch.

- Now I'll subscribe to the mailing list (wait for the activation mail,
activate, wait, send patch, wait, un-subscribe, wait, done) for the *sole*
purpose of 6 lines to patch...

Hope it's over now... :D

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #21 from André H.   2009-10-26 10:43:07 ---
un-subscribe maybe wasnt so clever. maybe the mailinglistserver gets confused
and wont list you mail...
this process seems heavy to you, but normally a developer continous working
somewhere else, so its more overhead for 1 patch then for 100 of course.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #22 from Vince C.   2009-10-26 10:50:09 ---
(In reply to comment #21)
> un-subscribe maybe wasnt so clever.

No no, you got me wrong: I haven't un-subscribed yet... I instead described the
whole process I'd follow to show the picture.

So, yes, I find this fairly heavy (send the patch to both places) since I was
driven to file the bug here as there didn't seem any better place. I just hate
to do twice the same job when I code ;) .

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #23 from André H.   2009-10-26 10:53:46 ---
you dont have to put the patch into bugzilla, wine-patches is enough. people
mostly put patches into bugzilla if they are not finished or dont get
committed, to leave them for public nearby the bug.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #24 from Vince C.   2009-10-26 11:04:32 ---
(In reply to comment #23)
> you dont have to put the patch into bugzilla, wine-patches is enough. people
> mostly put patches into bugzilla if they are not finished or dont get
> committed, to leave them for public nearby the bug.

Wish I knew that... I remember I sought a considerable amount of time to find
the best place to ask for a change on the web site. It turned out the mailing
lists were about changes to the wine distribution; inappropriate then. I fell
back onto bugzilla.

It'd be a good idea to have clear indications on who/where/what to contact to
suggest/submit changes to the web site.

Hmmm... maybe a new patch?... 8-<8-D

:lol:

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Alexander Scott-Johns  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexander.scott.johns+wineb
                   |                            |[e-mail]

--- Comment #25 from Alexander Scott-Johns   2009-10-26 11:52:39 ---
(In reply to comment #24)
> Wish I knew that... I remember I sought a considerable amount of time to find
> the best place to ask for a change on the web site. It turned out the mailing
> lists were about changes to the wine distribution; inappropriate then. I fell
> back onto bugzilla.

I think it's fine to talk about the website on the wine-devel mailing list
(although the response may be "file a bug" or "patches welcome").

Please also check http://source.winehq.org/git/tools.git which may in fact be
what creates AJ's announcements.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #26 from Vince C.   2009-10-26 15:26:57 ---
(In reply to comment #25)
> (In reply to comment #24)
> > Wish I knew that... I remember I sought a considerable amount of time to find
> > the best place to ask for a change on the web site. It turned out the mailing
> > lists were about changes to the wine distribution; inappropriate then. I fell
> > back onto bugzilla.
>
> I think it's fine to talk about the website on the wine-devel mailing list
> (although the response may be "file a bug" or "patches welcome").

Well, thanks a lot.

For now it's Ok. I just hope this patch will fall across some smart soul kind
enough to apply it before I get overwhelmed by the gazillions of mails from
Wine developers :-D .
> Please also check http://source.winehq.org/git/tools.git which may in fact be
> what creates AJ's announcements.

Not sure what it'll lead to. In fact a PHP script (i.e. announce.php, the
plugin script in question) just takes the plain text announcement and adds some
HTML code here and there. As far as I can see -- and if I've got it right -- if
my patch gets applied it'll add the link to all of the announcements, past
present and future (unless they're already cached somewhere), no matter what
tool generates the news. The PHP plugin script parses the text file at run-time
and adds links where appropriate, e.g. bug references link to WineHQ bugzilla.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #27 from Vince C.   2009-10-27 09:13:15 ---
I've had to unsubscribe... more than 50 messages each day *is* overwhelming...
Sorry. I've done all I could do so far. IMHO.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #28 from André H.   2009-10-27 11:32:33 ---
You may wanna choose Yes for the mailinglist-setting "Would you like to receive
list mail batched in a daily digest?", then you normally get one bundle of
mails in one mail per day. i use that for wine-patches.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #29 from Austin English   2009-10-27 12:08:57 ---
(In reply to comment #28)
> You may wanna choose Yes for the mailinglist-setting "Would you like to receive
> list mail batched in a daily digest?", then you normally get one bundle of
> mails in one mail per day. i use that for wine-patches.

Or subscribe and disable mail delivery. Your mail goes through fine, but you
receive no e-mail.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #30 from Vince C.   2009-10-27 15:34:50 ---
Thanks for your suggestions.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Vince C.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Difficulty|---                         |Minutes

--- Comment #31 from Vince C.   2010-01-11 08:35:28 ---
It's been several months now I've submitted my patch and it seems it hasn't
been applied yet. I know it's far less important than wine development but I've
done all I could do so far. Is there something wrong?

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

--- Comment #32 from Austin English   2010-01-11 09:47:51 ---
(In reply to comment #31)
> It's been several months now I've submitted my patch and it seems it hasn't
> been applied yet. I know it's far less important than wine development but I've
> done all I could do so far. Is there something wrong?

Please resend to wine-devel and ask for comments.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Difficulty|Minutes                     |---

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Vince C.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |ABANDONED

--- Comment #33 from Vince C.   2010-01-13 22:48:35 ---
Giving up.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #34 from Dmitry Timoshkov   2010-01-14 09:20:20 ---
Closing abandoned.

[Bug 19355] Link to the previous version announcement in section "changes since <previous version>"

http://bugs.winehq.org/show_bug.cgi?id=19355

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #35 from Jerome Leclanche  2010-08-28 19:07:30 CDT ---
Patch was resent today.