[Bug 36151] New: valgrind shows a couple warnings in dlls/msi/tests/package.c

https://bugs.winehq.org/show_bug.cgi?id=36151

Bug ID: 36151
           Summary: valgrind shows a couple warnings in
                    dlls/msi/tests/package.c
           Product: Wine
           Version: 1.7.17
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: msi
          Assignee: [e-mail]
          Reporter: [e-mail]

==2788== Invalid write of size 1
==2788==    at 0x53F4F41: save_table (table.c:932)
==2788==    by 0x53F869C: MSI_CommitTables (table.c:2203)
==2788==    by 0x53CF385: MsiDatabaseCommit (msiquery.c:843)
==2788==    by 0x4F7205E: test_MsiDatabaseCommit (package.c:8853)
==2788==    by 0x4F722D2: func_package (package.c:8924)
==2788==    by 0x4F94E4B: run_test (test.h:584)
==2788==    by 0x4F9523A: main (test.h:654)
==2788==  Address 0x4aa54ba is 0 bytes after a recently re-allocated block of
size 2 alloc'd
==2788==    at 0x7BC4C6B7: notify_alloc (heap.c:255)
==2788==    by 0x7BC50EFB: RtlAllocateHeap (heap.c:1716)
==2788==    by 0x53F238D: msi_alloc_zero (msipriv.h:1194)
==2788==    by 0x53F4D29: save_table (table.c:896)
==2788==    by 0x53F869C: MSI_CommitTables (table.c:2203)
==2788==    by 0x53CF385: MsiDatabaseCommit (msiquery.c:843)
==2788==    by 0x4F7205E: test_MsiDatabaseCommit (package.c:8853)
==2788==    by 0x4F722D2: func_package (package.c:8924)
==2788==    by 0x4F94E4B: run_test (test.h:584)
==2788==    by 0x4F9523A: main (test.h:654)
==2788==

==2788== Invalid read of size 4
==2788==    at 0x402DD10: memcpy (mc_replace_strmem.c:883)
==2788==    by 0x58C85DC: BlockChainStream_WriteAt (storage32.c:6319)
==2788==    by 0x58C950C: SmallBlockChainStream_WriteAt (storage32.c:7044)
==2788==    by 0x58C1889: StorageImpl_StreamWriteAt (storage32.c:2602)
==2788==    by 0x58BD805: StorageBaseImpl_StreamWriteAt (storage32.h:307)
==2788==    by 0x58C62E7: TransactedSnapshotImpl_StreamWriteAt
(storage32.c:5017)
==2788==    by 0x58BBD88: StorageBaseImpl_StreamWriteAt (storage32.h:307)
==2788==    by 0x58BC3F6: StgStreamImpl_Write (stg_stream.c:240)
==2788==    by 0x53F313A: write_stream_data (objidl.h:4384)
==2788==    by 0x53F5004: save_table (table.c:941)
==2788==    by 0x53F869C: MSI_CommitTables (table.c:2203)
==2788==    by 0x53CF385: MsiDatabaseCommit (msiquery.c:843)
==2788==    by 0x4F7205E: test_MsiDatabaseCommit (package.c:8853)
==2788==    by 0x4F722D2: func_package (package.c:8924)
==2788==    by 0x4F94E4B: run_test (test.h:584)
==2788==    by 0x4F9523A: main (test.h:654)
==2788==  Address 0x4aa54b8 is 0 bytes inside a recently re-allocated block of
size 2 alloc'd
==2788==    at 0x7BC4C6B7: notify_alloc (heap.c:255)
==2788==    by 0x7BC50EFB: RtlAllocateHeap (heap.c:1716)
==2788==    by 0x53F238D: msi_alloc_zero (msipriv.h:1194)
==2788==    by 0x53F4D29: save_table (table.c:896)
==2788==    by 0x53F869C: MSI_CommitTables (table.c:2203)
==2788==    by 0x53CF385: MsiDatabaseCommit (msiquery.c:843)
==2788==    by 0x4F7205E: test_MsiDatabaseCommit (package.c:8853)
==2788==    by 0x4F722D2: func_package (package.c:8924)
==2788==    by 0x4F94E4B: run_test (test.h:584)
==2788==    by 0x4F9523A: main (test.h:654)
==2788==

[Bug 36151] valgrind shows a couple warnings in dlls/msi/tests/package.c

https://bugs.winehq.org/show_bug.cgi?id=36151

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36151] valgrind shows a couple warnings in dlls/msi/tests/package.c

https://bugs.winehq.org/show_bug.cgi?id=36151

--- Comment #1 from Austin English  ---
Still in 1.7.41.

[Bug 36151] valgrind shows a couple warnings in dlls/msi/tests/package.c

https://bugs.winehq.org/show_bug.cgi?id=36151

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e6ce4de3930018b95bddbe8d259
                   |                            |cbbaa1309d1f0
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Austin English  ---
Fixed by
https://source.winehq.org/git/wine.git/commitdiff/e6ce4de3930018b95bddbe8d25...

[Bug 36151] valgrind shows a couple warnings in dlls/msi/tests/package.c

https://bugs.winehq.org/show_bug.cgi?id=36151

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.42.