[Bug 36638] New: valgrind shows a definite leak in wininet/tests/http.c

https://bugs.winehq.org/show_bug.cgi?id=36638

Bug ID: 36638
           Summary: valgrind shows a definite leak in wininet/tests/http.c
           Product: Wine
           Version: 1.7.19
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: wininet
          Assignee: [e-mail]
          Reporter: [e-mail]
        Depends on: 36637

==32063== Thread 1 wininet_test.exe.so:
==32063== 32 bytes in 1 blocks are definitely lost in loss record 111 of 360
==32063==    at 0x7BC4C75D: notify_alloc (heap.c:255)
==32063==    by 0x7BC50FA1: RtlAllocateHeap (heap.c:1716)
==32063==    by 0x4D45FA1: heap_alloc (internet.h:116)
==32063==    by 0x4D4FE13: alloc_async_task (internet.c:3856)
==32063==    by 0x4D44055: HttpSendRequestW (http.c:5556)
==32063==    by 0x4D44251: HttpSendRequestA (http.c:5614)
==32063==    by 0x497CC63: test_InternetCloseHandle (http.c:5195)
==32063==    by 0x497D671: func_http (http.c:5328)
==32063==    by 0x4994B90: run_test (test.h:584)
==32063==    by 0x4994F7F: main (test.h:654)
==32063==

[Bug 36638] valgrind shows a definite leak in wininet/tests/http.c

https://bugs.winehq.org/show_bug.cgi?id=36638

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36638] valgrind shows a definite leak in wininet/tests/http.c

https://bugs.winehq.org/show_bug.cgi?id=36638

--- Comment #1 from Bruno Jesus  ---
I can't find this =/ The callstack shows that an async call is queued [1] and
when the call is triggered it always frees the memory [2]. The only possible
thing I see is if the async call is not triggered after being queued.

[1] https://source.winehq.org/source/dlls/wininet/internet.c#L3873
[2] https://source.winehq.org/source/dlls/wininet/internet.c#L3834

[Bug 36638] valgrind shows a definite leak in wininet/tests/http.c

https://bugs.winehq.org/show_bug.cgi?id=36638
Bug 36638 depends on bug 36637, which changed state.

Bug 36637 Summary: wininet/tests/http.c crashes under valgrind
https://bugs.winehq.org/show_bug.cgi?id=36637

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

[Bug 36638] valgrind shows a definite leak in wininet/tests/http.c

https://bugs.winehq.org/show_bug.cgi?id=36638

--- Comment #2 from Austin English  ---
Some others:
==2460== 16 bytes in 2 blocks are definitely lost in loss record 83 of 786
==2460==    at 0x7BC51061: notify_alloc (heap.c:254)
==2460==    by 0x7BC5554F: RtlAllocateHeap (heap.c:1716)
==2460==    by 0x65753CE: InitializeSecurityContextW (wrapper.c:354)
==2460==    by 0x4BC3E7E: netcon_secure_connect_setup (netconnection.c:467)
==2460==    by 0x4BC47C4: NETCON_secure_connect (netconnection.c:617)
==2460==    by 0x4BB36F8: HTTP_HttpSendRequestW (http.c:4932)
==2460==    by 0x4BB451D: AsyncHttpSendRequestProc (http.c:5190)
==2460==    by 0x4BC05DE: INTERNET_WorkerThreadFunc (internet.c:3724)
==2460==    by 0x7BC9E2D7: process_rtl_work_item (threadpool.c:349)
==2460==    by 0x7BCA2224: threadpool_worker_proc (threadpool.c:2112)
==2460==    by 0x7BC913B3: ??? (signal_i386.c:2700)
==2460==    by 0x7BC9143B: call_thread_func (signal_i386.c:2759)
==2460==    by 0x7BC91391: ??? (signal_i386.c:2700)
==2460==    by 0x7BC9B3EE: start_thread (thread.c:487)
==2460==    by 0x4244249: start_thread (pthread_create.c:333)
==2460==    by 0x433FD6D: clone (clone.S:114)
==2460==

==2460== 36 bytes in 1 blocks are definitely lost in loss record 287 of 786
==2460==    at 0x7BC51061: notify_alloc (heap.c:254)
==2460==    by 0x7BC5554F: RtlAllocateHeap (heap.c:1716)
==2460==    by 0x4BA5A53: heap_alloc (internet.h:94)
==2460==    by 0x4BB05D4: get_redirect_url (http.c:3988)
==2460==    by 0x4BB3D35: HTTP_HttpSendRequestW (http.c:5041)
==2460==    by 0x4BB451D: AsyncHttpSendRequestProc (http.c:5190)
==2460==    by 0x4BC05DE: INTERNET_WorkerThreadFunc (internet.c:3724)
==2460==    by 0x7BC9E2D7: process_rtl_work_item (threadpool.c:349)
==2460==    by 0x7BCA2224: threadpool_worker_proc (threadpool.c:2112)
==2460==    by 0x7BC913B3: ??? (signal_i386.c:2700)
==2460==    by 0x7BC9143B: call_thread_func (signal_i386.c:2759)
==2460==    by 0x7BC91391: ??? (signal_i386.c:2700)
==2460==    by 0x7BC9B3EE: start_thread (thread.c:487)
==2460==    by 0x4244249: start_thread (pthread_create.c:333)
==2460==    by 0x433FD6D: clone (clone.S:114)
==2460==

==2460== 136 bytes in 1 blocks are definitely lost in loss record 587 of 786
==2460==    at 0x7BC51061: notify_alloc (heap.c:254)
==2460==    by 0x7BC5554F: RtlAllocateHeap (heap.c:1716)
==2460==    by 0x4BA5A53: heap_alloc (internet.h:94)
==2460==    by 0x4BB0E36: HTTP_build_req (http.c:4165)
==2460==    by 0x4BA72B3: build_request_header (http.c:692)
==2460==    by 0x4BB38DF: HTTP_HttpSendRequestW (http.c:4962)
==2460==    by 0x4BB451D: AsyncHttpSendRequestProc (http.c:5190)
==2460==    by 0x4BC05DE: INTERNET_WorkerThreadFunc (internet.c:3724)
==2460==    by 0x7BC9E2D7: process_rtl_work_item (threadpool.c:349)
==2460==    by 0x7BCA2224: threadpool_worker_proc (threadpool.c:2112)
==2460==    by 0x7BC913B3: ??? (signal_i386.c:2700)
==2460==    by 0x7BC9143B: call_thread_func (signal_i386.c:2759)
==2460==    by 0x7BC91391: ??? (signal_i386.c:2700)
==2460==    by 0x7BC9B3EE: start_thread (thread.c:487)
==2460==    by 0x4244249: start_thread (pthread_create.c:333)
==2460==    by 0x433FD6D: clone (clone.S:114)
==2460==

==2460== 192 bytes in 2 blocks are definitely lost in loss record 611 of 786
==2460==    at 0x7BC51061: notify_alloc (heap.c:254)
==2460==    by 0x7BC5554F: RtlAllocateHeap (heap.c:1716)
==2460==    by 0x4BC2702: heap_alloc_zero (internet.h:99)
==2460==    by 0x4BC3A21: create_netconn (netconnection.c:348)
==2460==    by 0x4BB2F44: open_http_connection (http.c:4782)
==2460==    by 0x4BB3686: HTTP_HttpSendRequestW (http.c:4923)
==2460==    by 0x4BB451D: AsyncHttpSendRequestProc (http.c:5190)
==2460==    by 0x4BC05DE: INTERNET_WorkerThreadFunc (internet.c:3724)
==2460==    by 0x7BC9E2D7: process_rtl_work_item (threadpool.c:349)
==2460==    by 0x7BCA2224: threadpool_worker_proc (threadpool.c:2112)
==2460==    by 0x7BC913B3: ??? (signal_i386.c:2700)
==2460==    by 0x7BC9143B: call_thread_func (signal_i386.c:2759)
==2460==    by 0x7BC91391: ??? (signal_i386.c:2700)
==2460==    by 0x7BC9B3EE: start_thread (thread.c:487)
==2460==    by 0x4244249: start_thread (pthread_create.c:333)
==2460==    by 0x433FD6D: clone (clone.S:114)
==2460==