[Bug 36287] New: valgrind shows some uninitialized memory use in kernel32/tests/format_msg.c

https://bugs.winehq.org/show_bug.cgi?id=36287

Bug ID: 36287
           Summary: valgrind shows some uninitialized memory use in
                    kernel32/tests/format_msg.c
           Product: Wine
           Version: 1.7.18
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]

==28883== Conditional jump or move depends on uninitialised value(s)
==28883==    at 0x7B844447: format_add_char (format_msg.c:300)
==28883==    by 0x7B8449BF: format_message (format_msg.c:432)
==28883==    by 0x7B844C59: FormatMessageA (format_msg.c:507)
==28883==    by 0x4A75F89: test_message_wrap (format_msg.c:1013)
==28883==    by 0x4A7B0C8: func_format_msg (format_msg.c:1785)
==28883==    by 0x4B0C7A8: run_test (test.h:584)
==28883==    by 0x4B0CB97: main (test.h:654)
==28883==  Uninitialised value was created by a client request
==28883==    at 0x7BC4C52C: mark_block_uninitialized (heap.c:209)
==28883==    by 0x7BC4C697: initialize_block (heap.c:240)
==28883==    by 0x7BC50FA3: RtlAllocateHeap (heap.c:1717)
==28883==    by 0x7B84586B: HeapAlloc (heap.c:271)
==28883==    by 0x7B844608: format_message (format_msg.c:337)
==28883==    by 0x7B844C59: FormatMessageA (format_msg.c:507)
==28883==    by 0x4A75F89: test_message_wrap (format_msg.c:1013)
==28883==    by 0x4A7B0C8: func_format_msg (format_msg.c:1785)
==28883==    by 0x4B0C7A8: run_test (test.h:584)
==28883==    by 0x4B0CB97: main (test.h:654)
==28883==

[Bug 36287] valgrind shows some uninitialized memory use in kernel32/tests/format_msg.c

https://bugs.winehq.org/show_bug.cgi?id=36287

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36287] valgrind shows some uninitialized memory use in kernel32/tests/format_msg.c

http://bugs.winehq.org/show_bug.cgi?id=36287

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Sebastian Lackner  ---
Created attachment 48851
  --> http://bugs.winehq.org/attachment.cgi?id=48851
kernel32: Fix a valgrind warning in format_add_char().

Does this patch help to fix the issue?

[Bug 36287] valgrind shows some uninitialized memory use in kernel32/tests/format_msg.c

https://bugs.winehq.org/show_bug.cgi?id=36287

--- Comment #2 from Austin English  ---
(In reply to Sebastian Lackner from comment #1)
> Created attachment 48851 [details]
> kernel32: Fix a valgrind warning in format_add_char().
>
> Does this patch help to fix the issue?

Works, thanks.

[Bug 36287] valgrind shows some uninitialized memory use in kernel32/tests/format_msg.c

https://bugs.winehq.org/show_bug.cgi?id=36287

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |87a78ed8788e002afb4abd652fc
                   |                            |40f1599a77c34
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Austin English  ---
https://source.winehq.org/git/wine.git/commitdiff/87a78ed8788e002afb4abd652f...

[Bug 36287] valgrind shows some uninitialized memory use in kernel32/tests/format_msg.c

https://bugs.winehq.org/show_bug.cgi?id=36287

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.21.