[Bug 45245] New: Add StartupWMClass also to bundled .desktop files such as wine-notepad.desktop
https://bugs.winehq.org/show_bug.cgi?id=45245
Bug ID: 45245 Summary: Add StartupWMClass also to bundled .desktop files such as wine-notepad.desktop Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: programs Assignee: wine-bugs@winehq.org Reporter: hein@kde.org Distribution: ---
Since the resolution of bug 32699, wine adds StartupWMClass=foo.exe to the .desktop files it generates, matching the name/instance string of the WM_CLASS it sets on wine windows. This has massively improved the integration of Wine clients with desktop environments and made the users of KDE Plasma (and likely Gnome Shell, which works the same way) much happier.
However, we've recently noticed that wine .desktop files installed in /usr and presumably pre-generated/bundled haven't been updated in the same way. For example, `wine-notepad.desktop` doesn't contain StartupWMClass=notepad.exe, so the integration doesn't work there.
Fixing this up would allow the "Pin" and "Start New Instance" actions and even listings of recently open files to work in the context menu of tasks like Notepad in KDE Plasma, for example.
https://bugs.winehq.org/show_bug.cgi?id=45245
tokktokk fdsfgs@krutt.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fdsfgs@krutt.org
https://bugs.winehq.org/show_bug.cgi?id=45245
--- Comment #1 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Eike Hein from comment #0)
However, we've recently noticed that wine .desktop files installed in /usr and presumably pre-generated/bundled haven't been updated in the same way. For example, `wine-notepad.desktop` doesn't contain StartupWMClass=notepad.exe, so the integration doesn't work there.
I don't think those files are part of plain Wine, what specific package are you using?
https://bugs.winehq.org/show_bug.cgi?id=45245
--- Comment #2 from Eike Hein hein@kde.org --- It's on Fedora and Neon (Ubuntu-based), so at least those two distros seem to install menu entries e.g. for Notepad and such, below a Wine category.
https://bugs.winehq.org/show_bug.cgi?id=45245
--- Comment #3 from Austin English austinenglish@gmail.com --- (In reply to Eike Hein from comment #2)
It's on Fedora and Neon (Ubuntu-based), so at least those two distros seem to install menu entries e.g. for Notepad and such, below a Wine category.
That's provided by the package. E.g., for Fedora, it's at: https://src.fedoraproject.org/rpms/wine/blob/master/f/wine-notepad.desktop
Looks like they have 11 of them: https://src.fedoraproject.org/rpms/wine/tree/master
https://bugs.winehq.org/show_bug.cgi?id=45245
--- Comment #4 from Eike Hein hein@kde.org --- Ah, thanks. Sorry, because it appeared cross-distro I figured it was bundled with wine proper. I'll forward this downstream, feel free to close or triage this as you see fit.
https://bugs.winehq.org/show_bug.cgi?id=45245
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTOURBUG
--- Comment #5 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Eike Hein from comment #4)
Ah, thanks. Sorry, because it appeared cross-distro I figured it was bundled with wine proper. I'll forward this downstream, feel free to close or triage this as you see fit.
That would be NOTOURBUG. It would be great if you could mention the downstream bug report here and close this bug when the downstream bug is finally fixed.
https://bugs.winehq.org/show_bug.cgi?id=45245
Jens Reyer jre.winesim@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jre.winesim@gmail.com
--- Comment #6 from Jens Reyer jre.winesim@gmail.com --- Just ftr:
Ubuntu now ships the Debian Wine packages, which don't bundle any desktop files. So at least future Neon versions shouldn't be affected.
https://bugs.winehq.org/show_bug.cgi?id=45245
Eike Hein hein@kde.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|NOTOURBUG |FIXED
--- Comment #7 from Eike Hein hein@kde.org --- Thanks Jens.
This can be read about here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902543
And here's the Fedora bug report, where this has been fixed: https://bugzilla.redhat.com/1594399
Closing now as requested.
https://bugs.winehq.org/show_bug.cgi?id=45245
Matteo Bruni matteo.mystral@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED Resolution|FIXED |NOTOURBUG
--- Comment #8 from Matteo Bruni matteo.mystral@gmail.com --- (In reply to Eike Hein from comment #7)
Thanks Jens.
This can be read about here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902543
And here's the Fedora bug report, where this has been fixed: https://bugzilla.redhat.com/1594399
Closing now as requested.
It's still NOTOURBUG, so changing resolution back. Thank you!
https://bugs.winehq.org/show_bug.cgi?id=45245
--- Comment #9 from Eike Hein hein@kde.org --- Sorry, I misunderstood this:
That would be NOTOURBUG. It would be great if you could mention the downstream bug report here and close this bug when the downstream bug is finally fixed.
We don't make a difference between RESOLVED and CLOSED on our tracker, so I went with the right-hand combobox :)
https://bugs.winehq.org/show_bug.cgi?id=45245
--- Comment #10 from Matteo Bruni matteo.mystral@gmail.com --- Oh, it's no worry :)
-
wine-bugs＠winehq.org