[Bug 54477] New: user32:msg - test_message_conversion()'s broadcast test fails on Windows 7 and 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54477

Bug ID: 54477
           Summary: user32:msg - test_message_conversion()'s broadcast
                    test fails on Windows 7 and 10
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]

user32:msg - test_message_conversion()'s broadcast test fails on Windows 7 and
10:

Windows 7:
msg.c:11208: Test failed: Got 1, error 1159.

Windows 10:
msg.c:11209: Test failed: Device broadcast was not received.

See https://test.winehq.org/data/patterns.html#user32:msg

This failure was detected by the TestBot and reported in MR2154.
But it was merged anyway!!!
https://gitlab.winehq.org/wine/wine/-/merge_requests/2154

It's clearly caused by the following commit:

commit 8675cad31c66b6620150a897545f705c1d17a59f
Author: Zebediah Figura 
Date:   Sun Feb 5 20:23:08 2023 -0600

user32/tests: Test WM_DEVICECHANGE Unicode conversion.

[Bug 54477] user32:msg - test_message_conversion()'s broadcast test fails on Windows 7 and 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54477

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |8675cad31c66b6620150a897545
                   |                            |f705c1d17a59f
           Keywords|                            |regression, source,
                   |                            |testcase
           Assignee|[e-mail]        |[e-mail]

[Bug 54477] user32:msg - test_message_conversion()'s broadcast test fails on Windows 7 and 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54477

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |9b9692466db9f2969af050c7947
                   |                            |069edf5636448
         Resolution|---                         |FIXED

--- Comment #1 from François Gouget  ---
This got promptly fixed by the commit below. Thanks for that!

commit 9b9692466db9f2969af050c7947069edf5636448
Author:     Zebediah Figura 
AuthorDate: Sun Feb 12 19:48:43 2023 -0600

user32/tests: Remove BroadcastSystemMessage() test for WM_DEVICECHANGE.

These are not uninteresting, but not consistent either, and it is not at
the
    moment behaviour that needs to be implemented.

This partially reverts 8675cad31c66b6620150a897545f705c1d17a59f.

Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54477

[Bug 54477] user32:msg - test_message_conversion()'s broadcast test fails on Windows 7 and 10

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54477

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 8.2.