[Bug 37592] New: Filenames in themed file dialog change size

https://bugs.winehq.org/show_bug.cgi?id=37592

Bug ID: 37592
           Summary: Filenames in themed file dialog change size
           Product: Wine
           Version: 1.6.1
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: uxtheme
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 50027
  --> https://bugs.winehq.org/attachment.cgi?id=50027
Video showing the bug

Open a file dialogue, increase the height to see the size better.

Bug affects Luna + Other freely available themes.

Choose a directory with lots of files.

Click into the file list, move through the file list with the keyboard - new
files are drawn smaller than the existing files, which makes things look
glitchy.

[Bug 37592] Filenames in themed file dialog change size

https://bugs.winehq.org/show_bug.cgi?id=37592

--- Comment #1 from Stuart Axon  ---
Online copy of video for those that don't fancy downloading and watching
https://www.youtube.com/watch?v=hNx96fzwkAo&feature=youtu.be

[Bug 37592] Filenames in themed file dialog change size

https://bugs.winehq.org/show_bug.cgi?id=37592

--- Comment #2 from Stuart Axon  ---
Created attachment 50053
  --> https://bugs.winehq.org/attachment.cgi?id=50053
BeebEm demonstrating this issue

There is no highlight, even though I'm navigating with the keyboard

[Bug 37592] Filenames in themed file dialog change size

https://bugs.winehq.org/show_bug.cgi?id=37592

--- Comment #3 from Stuart Axon  ---
Issue is worse in BeebEm as it doesn't let you resize the window - navigating
with the keyboard in Luna results in there being no highlight (see screenshot)

http://appdb.winehq.org/objectManager.php?sClass=version&iId=31272&i...

[Bug 37592] Filenames in themed file dialog change size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=37592

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|[e-mail]        |[e-mail]
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW

--- Comment #4 from Zhiyi Zhang  ---
Created attachment 70268
  --> https://bugs.winehq.org/attachment.cgi?id=70268
0001-uxtheme-Save-and-restore-system-metrics-in-96-DPI.txt

Confirmed with wine 6.12.

For example, the following steps will change the system metrics to incorrect
values.
1. Open winecfg, and set DPI to 192. Do not restart winecfg.
2. Change the theme to Light. UXTHEME_BackupSystemMetrics() backs up system
metrics in 96 DPI because the current DPI is still 96.
3. Restart winecfg and turn off theming. UXTHEME_RestoreSystemMetrics()
restores system metrics in
192 DPI because the current DPI is 192. So system metrics will be scaled to 1/2
of the original size.

[Bug 37592] Filenames in themed file dialog change size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=37592

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |7290db3e7a9652fcc39717b2fb4
                   |                            |92071dd52c641
         Resolution|---                         |FIXED

--- Comment #5 from Zhiyi Zhang  ---
Fixed by 7290db3e7a9652fcc39717b2fb492071dd52c641

[Bug 37592] Filenames in themed file dialog change size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=37592

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 6.17.

[Bug 37592] Filenames in themed file dialog change size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=37592

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |6.0.x

[Bug 37592] Filenames in themed file dialog change size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=37592

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|6.0.x                       |---

--- Comment #7 from Michael Stefaniuc  ---
Removing the 6.0.x milestone from bug fixes included in 6.0.3.