[Bug 38054] New: DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

https://bugs.winehq.org/show_bug.cgi?id=38054

Bug ID: 38054
           Summary: DoDragDrop() should abort when
                    IDropSource::QueryContinueDrag fails
           Product: Wine
           Version: 1.7.36
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ole32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 50692
  --> https://bugs.winehq.org/attachment.cgi?id=50692
IDrop_Example.exe

I've written some test code for DoDragDrop, and if
IDropSource::QueryContinueDrag returned a FAILED value (for example,
0xdeadbeef), DoDragDrop would about in Win8.

But wine will continue to do the job of DoDragDrop, so I'll see a MessageBox I
created in IDropTarget::DragEnter (In [MSDN], this is the 2nd step of
DoDragDrop)

Code sample:
https://gitcafe.com/endle/IDrop_Helper_Example/tree/DoDragDrop_should_stop

The .exe file was created with VS2013 Community

[MSDN]:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms678486%28v=vs.85%...

[Bug 38054] DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

https://bugs.winehq.org/show_bug.cgi?id=38054

--- Comment #1 from lizhenbo  ---
Created attachment 50693
  --> https://bugs.winehq.org/attachment.cgi?id=50693
+ole terminal output.txt

[Bug 38054] DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

https://bugs.winehq.org/show_bug.cgi?id=38054

lizhenbo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source, testcase

[Bug 38054] DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

https://bugs.winehq.org/show_bug.cgi?id=38054

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] ---
How do you test this bug?

[Bug 38054] DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

https://bugs.winehq.org/show_bug.cgi?id=38054

--- Comment #3 from lizhenbo  ---
(In reply to super_man from comment #2)
> How do you test this bug?

Compile my example code: 
https://gitcafe.com/endle/IDrop_Helper_Example/tree/DoDragDrop_should_stop

VS2013 Community is suggested

[Bug 38054] DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38054

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEEDINFO
     Ever confirmed|0                           |1

--- Comment #4 from Nikolay Sivov  ---
I don't see any difference from test program behavior, comparing to Win10.
Source code link is dead.

[Bug 38054] DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38054

lizhenbo  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEEDINFO                    |RESOLVED

--- Comment #5 from lizhenbo  ---
(In reply to Nikolay Sivov from comment #4)
> I don't see any difference from test program behavior, comparing to Win10.
> Source code link is dead.

I lost my previous test code as well. I tried to test this binary, and I think
wine's behaviour has changed after 2015

I saw there were lots of ole patches committed in 2016. I assume this bug has
been fixed by one/some of these patches

[Bug 38054] DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38054

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9194c47ede575a56961ad4ac001
                   |                            |de175ac32cee1

--- Comment #6 from Nikolay Sivov  ---
I was probably fixed with 9194c47ede575a56961ad4ac001de175ac32cee1.

[Bug 38054] DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38054

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  ---
Closing bugs fixed in 5.0-rc2.

[Bug 38054] DoDragDrop() should abort when IDropSource::QueryContinueDrag fails

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38054

mgruber  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from mgruber  ---
There's a bug on Wine 5.0 and 5.1 running WinSCP which calls that exact same
function and creates an infinite loop:
https://bugs.winehq.org/show_bug.cgi?id=48569