[Bug 30602] New: GTA2 crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30602

Bug #: 30602
           Summary: GTA2 crashes on exit
           Product: Wine
           Version: 1.3.13
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 40043
  --> http://bugs.winehq.org/attachment.cgi?id=40043
Crash from wine-1.3.12-151-g8872239.

You do not even need to play the game. In initial game's menu choose QUIT and
the game instead of clean exit crashes.

1. I did a regression test between 1.3.12 and 1.3.13:

8872239088c5e1b096cfc9203e008add68336ba4 is the first bad commit
commit 8872239088c5e1b096cfc9203e008add68336ba4
Author: Henri Verbeet 
Date:   Thu Jan 27 20:11:12 2011 +0100

ddraw: Link directly to wined3d.

:040000 040000 0b3a9f97320559e3a2fd6e0a31bd8b9a5af37650
cf827f4517285e725d1d49ce416b657c18b59694 M      dlls

2. No other bug report suffers from this commit.

3. Revert of this patch after git checkout makes that problem go away. (Can't
be cleanly reverted on top of wine-1.5.3-164-gdec3d50)

Crash log from wine-1.5.3 is the same as from wine-1.3.13.

The game is freely download-able from it's vendor at
http://www.rockstargames.com/classics/?id=3

There is another regression in 1.5.3 - needs to be run in game's native
resolution. I'm going to address this 2nd regression soon.

[Bug 30602] GTA2 crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30602

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
                URL|                            |http://www.rockstargames.co
                   |                            |m/classics/?id=3
                 CC|                            |[e-mail]
    Regression SHA1|                            |8872239088c5e1b096cfc9203e0
                   |                            |08add68336ba4

--- Comment #1 from Wylda  2012-05-05 09:02:07 CDT ---

Filling some fields...

[Bug 30602] GTA2 crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30602

--- Comment #2 from Wylda  2012-05-05 09:50:30 CDT ---
> I'm going to address this 2nd regression soon.

See bug 30603.

[Bug 30602] GTA2 crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30602

--- Comment #3 from Henri Verbeet  2012-06-14 08:11:21 CDT ---
Created attachment 40541
  --> http://bugs.winehq.org/attachment.cgi?id=40541
patch

The issue is that the game unloads ddraw (and as a result ddraw) from its
WM_DESTROY handler while the window is still registered with wined3d. That
means that when it returns from its own window proc to the wined3d one the
wined3d dll is already unmapped. The attached patch should help, although it
isn't particularly pretty.

[Bug 30602] GTA2 crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30602

--- Comment #4 from Wylda  2012-06-23 16:05:09 CDT ---

Hi Henri, yes the patch fixes the crash on exit. To make the game start again,
i had to use hack http://bugs.winehq.org/show_bug.cgi?id=30603#c2.

This patch and hack allows me to start and exit GTA2 cleanly again under
wine-1.5.7.

[Bug 30602] GTA2 crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30602

--- Comment #5 from Henri Verbeet  2012-06-28 18:10:54 CDT ---
Should be fixed by commit f95f4660602aad2e6564af3e3a933a68a36b4e82.

[Bug 30602] GTA2 crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30602

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f95f4660602aad2e6564af3e3a9
                   |                            |33a68a36b4e82
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Henri Verbeet  2012-07-07 09:53:05 CDT ---
Resolving FIXED, reopen if not.

[Bug 30602] GTA2 crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30602

--- Comment #7 from Wylda  2012-07-15 04:24:56 CDT ---

Confirming, FIXED in wine-1.5.7-190-gf95f466. Particular commit:
http://source.winehq.org/git/wine.git/commit/f95f4660602aad2e6564af3e3a933a6...

Thank you Henri!

PS: Sorry for bug not being closed on 1.5.8 release, i was on vacation that
time.

[Bug 30602] GTA2 crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=30602

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard  2012-07-17 13:52:11 CDT ---
Closing bugs fixed in 1.5.9.