[Bug 47031] New: widl generates invalid typelib when an interface extends IAccessible

https://bugs.winehq.org/show_bug.cgi?id=47031

Bug ID: 47031
           Summary: widl generates invalid typelib when an interface
                    extends IAccessible
           Product: Wine
           Version: 4.5
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: tools
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Background:

We're attempting to add accessibility support to Firefox when building with the
mingw toolchain which requires implementing the IAccessibility2 interface.
However, the typelib (tlb) file that ends up getting generated is invalidated.
The generated tlb be partially loaded using oleview.exe but throws up several
TYPE_E_ELEMENTNOTFOUND  errors and the inherited interfaces are apparently not
defined. The interfaces with invalid/undefined inherited interfaces varies
depending on the order in which the child interfaces are defined in the source
IDL.

Reproduction:

I've created a min-repro here: https://github.com/pospeselr/mingw-widl-bug
(you'll need to update the Makefile to point to your local instance of widl)

I tested this with the latest mingw ( commit
c61763cc740f8f4986755eeafce832baa3655ee8 ) which uses widl version 4.5.

Links:

Mozilla bug tracking mingw accessibility issues:
https://bugzilla.mozilla.org/show_bug.cgi?id=1520177

[Bug 47031] widl generates invalid typelib when an interface extends IAccessible

https://bugs.winehq.org/show_bug.cgi?id=47031

--- Comment #1 from Richard Pospesel  ---
Mingw bug: https://osdn.net/projects/mingw/ticket/39139

[Bug 47031] widl generates invalid typelib when importing types from multiple typelibs

https://bugs.winehq.org/show_bug.cgi?id=47031

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|widl generates invalid      |widl generates invalid
                   |typelib when an interface   |typelib when importing
                   |extends IAccessible         |types from multiple
                   |                            |typelibs
     Ever confirmed|0                           |1
          Component|tools                       |rpc
                 CC|                            |[e-mail]
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |download, source

--- Comment #2 from Zebediah Figura  ---
Thanks for the detailed report; I've sent a patch:
https://source.winehq.org/patches/data/163072.

[Bug 47031] widl generates invalid typelib when importing types from multiple typelibs

https://bugs.winehq.org/show_bug.cgi?id=47031

--- Comment #3 from Richard Pospesel  ---
Thanks for the fast turn around! I've applied the patch to my local instance of
mingw and can confirm our IAccessible2 related midl now generates parseable
typelibs (though there are other issues that I willl open bugs for).

[Bug 47031] widl generates invalid typelib when importing types from multiple typelibs

https://bugs.winehq.org/show_bug.cgi?id=47031

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |6c64d02117ecb9b259a55237f14
                   |                            |5fc9d5e70cdad>.
             Status|NEW                         |RESOLVED

--- Comment #4 from Zebediah Figura  ---
Committed as
https://source.winehq.org/git/wine.git/commitdiff/6c64d02117ecb9b259a55237f145fc9d5e70cdad.

[Bug 47031] widl generates invalid typelib when importing types from multiple typelibs

https://bugs.winehq.org/show_bug.cgi?id=47031

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 4.7.

[Bug 47031] widl generates invalid typelib when importing types from multiple typelibs

https://bugs.winehq.org/show_bug.cgi?id=47031

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|6c64d02117ecb9b259a55237f14 |6c64d02117ecb9b259a55237f14
                   |5fc9d5e70cdad>.             |5fc9d5e70cdad

[Bug 47031] widl generates invalid typelib when importing types from multiple typelibs

https://bugs.winehq.org/show_bug.cgi?id=47031

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.0.x

[Bug 47031] widl generates invalid typelib when importing types from multiple typelibs

https://bugs.winehq.org/show_bug.cgi?id=47031

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.x                       |---

--- Comment #6 from Michael Stefaniuc  ---
Removing the 4.0.x milestone from bug fixes included in 4.0.2.