[Bug 44866] New: propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

Bug ID: 44866
           Summary: propertystore_SetValue and propertystore_Commit
                    implies issue if they are called
           Product: Wine
           Version: 3.5
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: shell32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

If propertystore_SetValue or propertystore_Commit are called, they return
"E_NOTIMPL", this implie an error.

Sample:

005b:fixme:shell:propertystore_SetValue (0x1016f9e0)->(0x1017a550 0x101764a0):
stub
005b:trace:shell:IShellLinkW_fnQueryInterface
(0x1016f9e0)->({df0b3d60-548f-101b-8e65-08002b2bd119})
005b:err:shell:IShellLinkW_fnQueryInterface -- Interface: E_NOINTERFACE

If both return "S_OK", no ISupportErrorInfo is called and everything is ok.

Related bug : https://bugs.winehq.org/show_bug.cgi?id=22210
Source of solution : https://bugs.winehq.org/show_bug.cgi?id=44744#c11

I tested, and approve replacement of E_NOTIMPL by S_OK

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

GG  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.winehq.org/sho
                   |                            |w_bug.cgi?id=44744

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

GG  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.winehq.org/sho
                   |                            |w_bug.cgi?id=22210

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Maurer  ---
Did you already send in a patch?

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

--- Comment #2 from GG  ---
Nop, I started to read contribution guidelines, but I didn't understand the
good way to contribute.
So I opend this ticket to repport my solution...

Do you want make changes or I do make a patch and put it in this ticket ?

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

--- Comment #3 from GG  ---
Created attachment 60986
  --> https://bugs.winehq.org/attachment.cgi?id=60986
Patch to fix returns

Without response, I attach my patch :)

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Louis Lenders  ---
(In reply to GG from comment #3)
> Created attachment 60986 [details]
> Patch to fix returns
>
> Without response, I attach my patch :)

Hi, could you tell us what program gives errors/crashes because of this/you try
to fix?

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

--- Comment #5 from Gijs Vermeulen  ---
(In reply to Louis Lenders from comment #4)
It is for Autodesk Fusion 360. (Based on the OP's comment about the solution
coming from bug 44744)
It is also needed for bug 22210 (HTML-Kit Tools). (Also not sure what to do
with that bug since this one and the other one seem to need the same things)

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

--- Comment #6 from GG  ---
Patch submitted, but not yet reviewed
https://source.winehq.org/patches/data/144652

[Bug 44866] propertystore_SetValue and propertystore_Commit implies issue if they are called

https://bugs.winehq.org/show_bug.cgi?id=44866

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
    Regression SHA1|                            |794d30dca65843baee7e0cd5f05
                   |                            |4e1b1fbe96a95

--- Comment #7 from Louis Lenders  ---
(In reply to GG from comment #6)
> Patch submitted, but not yet reviewed
> https://source.winehq.org/patches/data/144652

Hi Guillaume, your patch is committed, thanks Gijs for resending it.
This bug is fixed in current git then.

[Bug 44866] Autodesk Fusion 360 fails to run: propertystore_SetValue and propertystore_Commit need fake success

https://bugs.winehq.org/show_bug.cgi?id=44866

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://www.appstreaming.aut
                   |                            |odesk.com/install/app/73e72
                   |                            |ada57b7480280f7a6f4a289729f
                   |                            |/
           Keywords|                            |download
            Summary|propertystore_SetValue and  |Autodesk Fusion 360 fails
                   |propertystore_Commit        |to run:
                   |implies issue if they are   |propertystore_SetValue and
                   |called                      |propertystore_Commit need
                   |                            |fake success

--- Comment #8 from Louis Lenders  ---
changed title a bit + add some fields

[Bug 44866] Autodesk Fusion 360 fails to run: propertystore_SetValue and propertystore_Commit need fake success

https://bugs.winehq.org/show_bug.cgi?id=44866

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 3.8.

[Bug 44866] Autodesk Fusion 360 fails to run: propertystore_SetValue and propertystore_Commit need fake success

https://bugs.winehq.org/show_bug.cgi?id=44866

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|794d30dca65843baee7e0cd5f05 |
                   |4e1b1fbe96a95               |
      Fixed by SHA1|                            |794d30dca65843baee7e0cd5f05
                   |                            |4e1b1fbe96a95