[Bug 26385] New: HTTP_ParseDay uses "sun" as variable name, which is GCC reserved word on Solaris

http://bugs.winehq.org/show_bug.cgi?id=26385

Summary: HTTP_ParseDay uses "sun" as variable name, which is
                    GCC reserved word on Solaris
           Product: Wine
           Version: 1.3.15
          Platform: x86
        OS/Version: Solaris
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

in dlls/wininet/http.c, lines 3583 and 3593 have a variable named "sun". 
Compilation of this file fails with "error: syntax error before numeric
constant".  This is because "sun" is redefined to "1" by GCC when compiling,
because it is GCC running on Solaris (and thus "sun" as in "Sun").

Redefining the variable as "Sun" is sufficient to compile the object.  To be
more careful, though, I would recommend simply spelling out all the day names.

[Bug 26385] HTTP_ParseDay uses "sun" as variable name, which is GCC reserved word on Solaris

http://bugs.winehq.org/show_bug.cgi?id=26385

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #1 from Juan Lang  2011-03-11 10:42:42 CST ---
Confirming.  Francois sent a patch:
http://www.winehq.org/pipermail/wine-patches/2011-March/099565.html
It failed to apply:
http://source.winehq.org/patches/data/71921

Francois, could you resend?

[Bug 26385] HTTP_ParseDay uses "sun" as variable name, which is GCC reserved word on Solaris

http://bugs.winehq.org/show_bug.cgi?id=26385

--- Comment #2 from François Gouget  2011-03-11 11:49:49 CST ---
Done:
http://www.winehq.org/pipermail/wine-patches/2011-March/099822.html

[Bug 26385] HTTP_ParseDay uses "sun" as variable name, which is GCC reserved word on Solaris

http://bugs.winehq.org/show_bug.cgi?id=26385

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch
                 CC|                            |[e-mail]

[Bug 26385] HTTP_ParseDay uses "sun" as variable name, which is GCC reserved word on Solaris

http://bugs.winehq.org/show_bug.cgi?id=26385

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Juan Lang  2011-03-14 14:39:56 CDT ---
Fixed by commit 4bacb3f24e3919d93330e82e25a1ba88a2aabd59.

[Bug 26385] HTTP_ParseDay uses "sun" as variable name, which is GCC reserved word on Solaris

http://bugs.winehq.org/show_bug.cgi?id=26385

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  2011-03-18 14:39:39 CDT ---
Closing bugs fixed in 1.3.16.