[Bug 42836] New: CCCP-Settings program fails to configure LAV Splitter settings, OK button does nothing and apply button never becomes enabled

https://bugs.winehq.org/show_bug.cgi?id=42836

Bug ID: 42836
           Summary: CCCP-Settings program fails to configure LAV Splitter
                    settings, OK button does nothing and apply button
                    never becomes enabled
           Product: Wine
           Version: 2.5
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

I'm running Wine 2.5 Staging on Debian Testing (x64 OS, but using 32-bit Wine).

This concerns the program CCCP-Settings.exe that comes with Combined Community
Codec Pack ( http://cccp-project.net/ ).  It is a tool that can invoke the
property pages from LAV Filters ( https://github.com/Nevcairiel/LAVFilters ).

When you run CCCP-Settings, there are buttons that open the property pages for
LAV Video Settings, LAV Audio Settings, and LAV Splitter Settings.
When you run these under Windows, the title bar says "Properties", you can
click to change settings, and the OK and Apply buttons work.
Under Wine, the title bar says "Properties for", the OK button dismisses the
dialog without saving any settings just like cancel, and the Apply button never
becomes enabled when you change any settings.

There are also other programs that can invoke the property pages for LAV
Filters, such as GraphStudio Next (
https://github.com/cplussharp/graph-studio-next ).  When you run GraphStudio
Next under Wine, the property page dialog boxes for LAV Filters work perfectly,
with functioning OK and Apply buttons.

So the issue is in how CCCP-Settings.exe works under Wine, not the LAV filters
property pages themselves.

[Bug 42836] CCCP-Settings program fails to configure LAV Splitter settings , OK button does nothing and apply button never becomes enabled

https://bugs.winehq.org/show_bug.cgi?id=42836

--- Comment #1 from Dan Weiss  ---
Created attachment 57932
  --> https://bugs.winehq.org/attachment.cgi?id=57932
Console log from Wine

[Bug 42836] CCCP-Settings program fails to configure LAV Splitter settings, OK button does nothing and apply button never becomes enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=42836

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from joaopa  ---
Confirming with wine-7.0
Tested with
https://web.archive.org/web/20161220184919/http://www.cccp-project.net/publi...

[Bug 42836] CCCP-Settings program fails to configure LAV Splitter settings, OK button does nothing and apply button never becomes enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=42836

--- Comment #3 from joaopa  ---
Can an administrator put the link at the UR place?

https://web.archive.org/web/20161220184919/http://www.cccp-project.net/publi...

[Bug 42836] CCCP-Settings program fails to configure LAV Splitter settings, OK button does nothing and apply button never becomes enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=42836

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://web.archive.org/web
                   |                            |/20161220184919/http://www.
                   |                            |cccp-project.net/public/Com
                   |                            |bined-Community-Codec-Pack-
                   |                            |2015-10-18.exe
           Keywords|                            |download

[Bug 42836] CCCP-Settings program fails to configure LAV Splitter settings, OK button does nothing and apply button never becomes enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=42836

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail] ---
The bug ist still present in Wine 8.02 (stable and staging) and clearly caused
by the Wine property site implementation. The property pages of all DirectShow
filters are affected in all programs that display them.

It works in GraphStudioNext, however, because it is using its own property page
site for displaying property pages, not the one from Wine/Microsoft.

Steps to reproduce:

(1) Download the LAV Filters installer and execute it with Wine
https://github.com/Nevcairiel/LAVFilters/releases
(2) Go to the start menu and open the LAV Video/Audio/Splitter configuration
(doesn't matter which one).
(3) Change some settings. Expected result: The Apply button gets enabled.
Actual result: The Apply button remains disabled.
(4) Click the OK button. Expected result: The settings/changes are written to
the registry (HKEY_CURRENT_USER\SOFTWARE\LAV). Actual result: Nothing is
written.

Specific property page implementations of DirectShow filters usually call the
SetPageDirty method of the underlying base class if settings are changed, which
responds by setting an IsDirty flag and calling the OnStatusChange method of
the IPropertyPageSite interface with PROPPAGESTATUS_DIRTY as parameter. This
enables the Apply button, which triggers an OnApplyChanges callback if clicked.

This mechanism obviously doesn't work in Wine.

[Bug 42836] CCCP-Settings program fails to configure LAV Splitter settings, OK button does nothing and apply button never becomes enabled

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=42836

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |quartz