[Bug 7959] X Error BadPixmap in X_FreePixmap from xrender.c XFreePixmap

[Wine Bugs]

http://bugs.winehq.org/show_bug.cgi?id=7959

------- Additional Comments From [e-mail]  2007-02-07 15:45 -------
Created an attachment (id=6981)
 --> (http://bugs.winehq.org/attachment.cgi?id=6981&action=view)
Minimal patch to fix

Huw,

Good work. That fixed it for me. In fact all that is needed is adding that
one line. Specifically, on a clean wine git tree I apply my user32 conformance
test patch to make it XFreePixmap error and then apply just this minimal patch
and XFreePixmap error is gone.

With this patch, I get the same behavior that I can only get in one of four
other ways:
1) Reverse applying the original patch that was rebase'd to be the broken one
2) Commenting out X_FreePixmap call for tile_xpm in UpdateDrawable
3) Commenting out UpdateDrawable call in SET_DRAWABLE in ExtEscape
4) WINEDEBUG=+synchronize (seems to avoid calling old_error_handler in
error_handler).

So I am pretty sure I am testing the underlying problem here (especially b/c of
pt's #1 & #2). Just to play it safe someone else should probably test it out
too on an actual app, but I'm pretty confident this will fix it.

As for the other patches, not sure if they're needed but that's your call Huw.
This fixes the XFreePixmap error by itself.

Thanks a lot!
Misha