[Bug 20497] New: Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

Summary: Smilebox cannot be installed
           Product: Wine
           Version: 1.1.32
          Platform: PC
               URL: http://www.smilebox.com/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=24404)
 --> (http://bugs.winehq.org/attachment.cgi?id=24404)
Console output after running "wine Downloads/SmileboxInstaller.exe"

The freely downloadable application Smilebox cannot be installed. The output
log of the shell is attached.

The problem is in supposedly in wininet.dll
I also downloaded the latest winetricks (as of today), and did "sh winetricks
wininet". This changes some of the errors, however, at the end the installer
crashes anyway.

[Bug 20497] Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, Installer

[Bug 20497] Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|wininet                     |-unknown

--- Comment #1 from Juan Lang   2009-10-29 19:19:39 ---
fixmes are not errors.  I don't think you can conclude that the problem is in
wininet, especially when 'winetricks wininet' doesn't solve it.  Changing
component to unknown.

[Bug 20497] Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #2 from Juan Lang   2009-12-03 23:45:37 ---
Confirming.  I'll attach the text from the error dialog in a second.  I also
tried with native wininet, but it crashes, due to native wininet not
implementing InternetGetCookieExA, at least not the version we install.

[Bug 20497] Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

--- Comment #3 from Juan Lang   2009-12-03 23:47:10 ---
Created an attachment (id=25070)
 --> (http://bugs.winehq.org/attachment.cgi?id=25070)
Error dialog output

The odd thing is, the HTTP status code (200) means, everything's ok.  I also
tried with native msxml3, no change.

[Bug 20497] Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Frédéric Delanoy  2011-05-13 17:27:45 CDT ---
(In reply to comment #0)
> Created an attachment (id=24404)

--> (http://bugs.winehq.org/attachment.cgi?id=24404) [details]
> Console output after running "wine Downloads/SmileboxInstaller.exe"
>
> The freely downloadable application Smilebox cannot be installed. The output
> log of the shell is attached.
>
> The problem is in supposedly in wininet.dll
> I also downloaded the latest winetricks (as of today), and did "sh winetricks
> wininet". This changes some of the errors, however, at the end the installer
> crashes anyway.

Can you provide a direct download link? Did not find how to download it from
main website

[Bug 20497] Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Abandoned?

[Bug 20497] Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

--- Comment #5 from Frédéric Delanoy  2012-05-02 11:41:34 CDT ---
Abandoned. Feel free to reopen if the bug appears again in the latest wine
version.

[Bug 20497] Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |ABANDONED

--- Comment #6 from Frédéric Delanoy  2012-05-02 11:53:57 CDT ---
Really setting the status

[Bug 20497] Smilebox cannot be installed

http://bugs.winehq.org/show_bug.cgi?id=20497

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Frédéric Delanoy  2012-05-02 11:54:49 CDT ---
Closing.

[Bug 20497] Smilebox cannot be installed (web update fails)

http://bugs.winehq.org/show_bug.cgi?id=20497

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Abandoned?                  |
             Status|CLOSED                      |REOPENED
                URL|http://www.smilebox.com/    |http://www.computerbild.de/
                   |                            |download/Smilebox-1298829.h
                   |                            |tml
                 CC|                            |[e-mail]
          Component|-unknown                    |wininet
         Resolution|ABANDONED                   |
            Summary|Smilebox cannot be          |Smilebox cannot be
                   |installed                   |installed (web update
                   |                            |fails)

--- Comment #8 from Anastasius Focht  2012-05-02 13:03:42 CDT ---
Hello,

I found a download here:
http://www.computerbild.de/download/Smilebox-1298829.html

(its a german site but that doesn't matter, the app is english).

The app puts itself here for reproduce:

--- snip ---
$ pwd
/home/focht/.wine/drive_c/users/focht/Application Data/Smilebox
--- snip ---

It seems the installer/app first "pings" the remote server using "HEAD"
request.
> From wireshark log:

--- snip ---
HEAD /clientFirewallCheck.txt HTTP/1.1
Host: secure.smilebox.com
Content-Length: 0
User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Smilebox)
Pragma: no-cache
Connection: Keep-Alive

HTTP/1.1 200 OK
Date: Wed, 02 May 2012 17:30:48 GMT
Server: Apache
Last-Modified: Wed, 04 Apr 2012 18:12:02 GMT
ETag: "1a-4bcde5c2c2080"
Accept-Ranges: bytes
Content-Length: 26
Keep-Alive: timeout=5, max=1000
Connection: Keep-Alive
Content-Type: text/plain; charset=utf-8
--- snip ---

There is a log file "smilebox.log" in app folder which tells that the HEAD
request succeeded (last line):

--- snip ---
[ Wed May 02 19:28:43.495 ] SmileboxStarter.exe: Platform=WinXP
[ Wed May 02 19:28:43.500 ] SmileboxStarter.exe: Starter active. Version:
1.0.0.14986
[ Wed May 02 19:28:43.505 ] SmileboxStarter.exe: Retrieved partner code from
registry: smileboxgerman
[ Wed May 02 19:28:43.513 ] SmileboxStarter.exe: Starter environment is good
check flag: true
[ Wed May 02 19:28:43.955 ] SmileboxStarter.exe: checkInternetConnection:
Network appears connected.
--- snip ---

Next the app tries to download XML file containing version data.
Wireshark log again:

--- snip ---
GET /version.xml?cb=919 HTTP/1.1
Accept: */*
Host: update.smilebox.com
Referer: http://www.smilebox.com
User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Smilebox)
Pragma: no-cache
Connection: Keep-Alive

HTTP/1.1 200 OK
Date: Wed, 02 May 2012 17:30:48 GMT
Server: Apache
Last-Modified: Thu, 12 Apr 2012 22:35:57 GMT
ETag: "3f-4bd82fabe0d40"
Accept-Ranges: bytes
Content-Length: 63
Keep-Alive: timeout=5, max=1000
Connection: Keep-Alive
Content-Type: application/xml

<version>
  <major>17657</major>
  <minor>1</minor>
</version>
--- snip ---

The XML data is in the message body of the response.
This request is repeated over and over.
> From application log:

--- snip ---
[ Wed May 02 19:28:43.983 ] SmileboxStarter.exe: About to download
http://update.smilebox.com/version.xml?cb=72414 to
C:\users\focht\Temp\smb2fec_32034.tmp
[ Wed May 02 19:28:43.988 ] SmileboxStarter.exe: Getting connection for
http://update.smilebox.com/version.xml?cb=72414
[ Wed May 02 19:28:44.393 ] SmileboxStarter.exe: Obtained remote file
connection to http://update.smilebox.com/version.xml?cb=72414
[ Wed May 02 19:28:44.399 ] SmileboxStarter.exe: getRemoteConnection: status
code is 200
[ Wed May 02 19:28:45.409 ] SmileboxStarter.exe: About to retry download of
http://update.smilebox.com/version.xml?cb=72414
[ Wed May 02 19:28:45.415 ] SmileboxStarter.exe: Getting connection for
http://update.smilebox.com/version.xml?cb=72414
[ Wed May 02 19:28:45.623 ] SmileboxStarter.exe: Obtained remote file
connection to http://update.smilebox.com/version.xml?cb=72414
[ Wed May 02 19:28:45.628 ] SmileboxStarter.exe: getRemoteConnection: status
code is 200
...
--- snip ---

Actually I don't see the message body data (XML) being processed here.
The resulting file in cache is empty (0 bytes).
The app tries to load and process the XML file later through msxml which fails
-> "err:msxml:doparse Failed to create parser context" messages

Unfortunately 'winetricks wininet' doesn't help to verify, it seems the app
expects a newer wininet.dll version than winetricks provides (missing
WININET.dll.InternetGetCookieExW export).

$ du -sh SmileboxInstaller.exe 
668K    SmileboxInstaller.exe

$ sha1sum SmileboxInstaller.exe 
f6641e30f00fc6d30a9e68fbcfdd8744cdfe9f29  SmileboxInstaller.exe

$ wine --version
wine-1.5.3-73-g93a0ca7

Regards

[Bug 20497] Smilebox cannot be installed (web update fails)

http://bugs.winehq.org/show_bug.cgi?id=20497

--- Comment #9 from Anastasius Focht  2012-05-02 13:05:16 CDT ---
Created attachment 40000
  --> http://bugs.winehq.org/attachment.cgi?id=40000
WINEDEBUG=+tid,+wininet

log of initial requests, WINEDEBUG=+tid,+wininet

[Bug 20497] Smilebox cannot be installed (web update fails)

http://bugs.winehq.org/show_bug.cgi?id=20497

--- Comment #10 from Anastasius Focht  2012-05-03 15:26:12 CDT ---
Hello,

there were some wininet commits today related to HTTP_QUERY_STATUS_CODE in
HttpQueryInfo (starting with 5240e40b69a28e883961a861ce82d05de59ddf44) so this
is no longer seen in traces:

--- snip ---
0009:trace:wininet:HTTP_GetCustomHeaderIndex L"Status", 0, 0
0009:trace:wininet:HTTP_GetCustomHeaderIndex Return: 5
0009:trace:wininet:HTTP_HttpQueryInfoW  returning number: 200
--- snip ---

Regards

[Bug 20497] Smilebox cannot be installed (web update fails)

http://bugs.winehq.org/show_bug.cgi?id=20497

--- Comment #11 from Frédéric Delanoy  2013-05-27 07:35:01 CDT ---
Still in 1.5.31

err:msxml:doparse Failed to create parser context

probably has something to do with it.

[Bug 20497] Smilebox cannot be installed (web update fails)

http://bugs.winehq.org/show_bug.cgi?id=20497

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from Sebastian Lackner  ---
Created attachment 48803
  --> http://bugs.winehq.org/attachment.cgi?id=48803
wininet: Don't update *lpdwIndex if buffer is not sufficient.

The application calls HttpQueryInfo* and provides a field index variable with
content 0. The first call is with a buffer size of zero, afterwards with an
allocated buffer ... the only problem is that wine always increments the field
index, even if the function fails with ERROR_INSUFFICIENT_BUFFER. The
application itself doesn't reset the index, and this has the effect that the
application never finds the expected header field and internally gets stuck...

The attached patch fixes the updater issue for me. When starting the program
afterwards it will tell that you that something went wrong, and bunch of
additional fixme's will scroll down - nevertheless this is probably a different
problem and should be discussed in a separate bug report. It will take really
long till the installation is finished, so don't give up. ;) The only way to
see the progress is by taking a look at the *.log file in the application
directory.

Could you guys please test yourself?

[Bug 20497] Smilebox cannot be installed (web update fails)

http://bugs.winehq.org/show_bug.cgi?id=20497

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #13 from Bruno Jesus  ---
(In reply to Sebastian Lackner from comment #12)
> Could you guys please test yourself?

The patch works, the application starts with it, thanks.

[Bug 20497] Smilebox cannot be installed (web update fails)

http://bugs.winehq.org/show_bug.cgi?id=20497

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |2e0921d065121fe4bf3b17a54ab
                   |                            |529f3fd4041fd
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Bruno Jesus  ---
Patch commited:
http://source.winehq.org/git/wine.git/commit/2e0921d065121fe4bf3b17a54ab529f...

Thanks Sebastian.

[Bug 20497] Smilebox cannot be installed (web update fails)

https://bugs.winehq.org/show_bug.cgi?id=20497

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.21.